From: Gabor Juhos <j4g8y7@gmail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] clk: qcom: apss-ipq-pll: remove 'pll_type' field from struct 'apss_pll_data'
Date: Sun, 24 Mar 2024 08:29:21 +0100 [thread overview]
Message-ID: <a34f1ab4-e505-4281-9a8f-b72c62beed5d@gmail.com> (raw)
In-Reply-To: <CAA8EJpp9jyCHgMSEBMumSz7xXUkMRm3wapjUdjzeOuJSpH5g5w@mail.gmail.com>
2024. 03. 22. 23:33 keltezéssel, Dmitry Baryshkov írta:
...
>> Although my opinion that it is redundant still stand, but I'm not against
>> keeping the pll_type. However if we keep that, then at least we should use
>> private enums (IPQ_APSS_PLL_TYPE_* or similar) for that in order to make it more
>> obvious that it means a different thing than the CLK_ALPHA_PLL_TYPE_* values.
>>
>> This solution would be more acceptable?
>
> This looks like a slight overkill, but yes, it is more acceptable. The
> logic should be type => functions, not the other way around.
>
>
If that is overkill, it does not worth the change. I will drop the patch and
send an updated series.
Regards,
Gabor
next prev parent reply other threads:[~2024-03-24 7:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 7:49 [PATCH v2 0/6] clk: qcom: apss-ipq-pll: various cleanups Gabor Juhos
2024-03-21 7:49 ` [PATCH v2 1/6] clk: qcom: apss-ipq-pll: reuse Stromer reg offsets from 'clk_alpha_pll_regs' Gabor Juhos
2024-03-22 18:29 ` Konrad Dybcio
2024-03-21 7:49 ` [PATCH v2 2/6] clk: qcom: apss-ipq-pll: move Huayra register map to 'clk_alpha_pll_regs' Gabor Juhos
2024-03-21 13:33 ` Dmitry Baryshkov
2024-03-22 18:30 ` Konrad Dybcio
2024-03-21 7:49 ` [PATCH v2 3/6] clk: qcom: apss-ipq-pll: remove 'pll_type' field from struct 'apss_pll_data' Gabor Juhos
2024-03-21 10:37 ` Dmitry Baryshkov
2024-03-22 20:59 ` Gabor Juhos
2024-03-22 22:33 ` Dmitry Baryshkov
2024-03-24 7:29 ` Gabor Juhos [this message]
2024-03-24 10:55 ` Dmitry Baryshkov
2024-03-21 7:49 ` [PATCH v2 4/6] clk: qcom: apss-ipq-pll: constify match data structures Gabor Juhos
2024-03-22 18:31 ` Konrad Dybcio
2024-03-21 7:49 ` [PATCH v2 5/6] clk: qcom: apss-ipq-pll: constify clk_init_data structures Gabor Juhos
2024-03-21 10:29 ` Dmitry Baryshkov
2024-03-22 18:31 ` Konrad Dybcio
2024-03-21 7:49 ` [PATCH v2 6/6] clk: qcom: clk-cbf-8996: use HUAYRA_APPS register map for cbf_pll Gabor Juhos
2024-03-21 10:28 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a34f1ab4-e505-4281-9a8f-b72c62beed5d@gmail.com \
--to=j4g8y7@gmail.com \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox