From: Stephen Boyd <sboyd@kernel.org>
To: Binbin Zhou <zhoubb.aaron@gmail.com>,
Binbin Zhou <zhoubinbin@loongson.cn>,
Conor Dooley <conor+dt@kernel.org>,
Huacai Chen <chenhuacai@loongson.cn>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Yinbo Zhu <zhuyinbo@loongson.cn>
Cc: Huacai Chen <chenhuacai@kernel.org>,
loongson-kernel@lists.loongnix.cn, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev, Binbin Zhou <zhoubinbin@loongson.cn>
Subject: Re: [PATCH v3 2/6] clk: clk-loongson2: Refactor driver for adding new platforms
Date: Thu, 11 Apr 2024 00:28:29 -0700 [thread overview]
Message-ID: <a39fadac1c4150ca51a8c22d749645e1.sboyd@kernel.org> (raw)
In-Reply-To: <fb020d1ca19e6f4cdcc95c87b2748869ca76b8ec.1712731524.git.zhoubinbin@loongson.cn>
Quoting Binbin Zhou (2024-04-10 19:58:07)
> The driver only supported loongson-2K1000 at first, but the clock
> structure of loongson-2K0500 and loongson-2K2000 are actually similar,
> and I tried to refactor the whole driver to adjust to the addition of
> the new platform.
>
> Briefly, I have divided all clocks into three categories according to
> their properties and their parent clocks: Independent PLLs, clocks based
> on frequency scales, and clock dividers.
>
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> ---
> drivers/clk/clk-loongson2.c | 459 ++++++++++++++++--------------------
> 1 file changed, 199 insertions(+), 260 deletions(-)
>
> diff --git a/drivers/clk/clk-loongson2.c b/drivers/clk/clk-loongson2.c
> index bacdcbb287ac..ff2ade6a471a 100644
> --- a/drivers/clk/clk-loongson2.c
> +++ b/drivers/clk/clk-loongson2.c
> @@ -6,6 +6,7 @@
>
> #include <linux/err.h>
> #include <linux/init.h>
> +#include <linux/clk.h>
Why is this included? I removed it and applied to clk-next.
next prev parent reply other threads:[~2024-04-11 7:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 2:58 [PATCH v3 0/6] Add Loongson-2k0500 and Loongson-2k2000 clock support Binbin Zhou
2024-04-11 2:58 ` [PATCH v3 1/6] dt-bindings: clock: Add Loongson-2K expand clock index Binbin Zhou
2024-04-11 7:23 ` Stephen Boyd
2024-04-11 2:58 ` [PATCH v3 2/6] clk: clk-loongson2: Refactor driver for adding new platforms Binbin Zhou
2024-04-11 7:28 ` Stephen Boyd [this message]
2024-04-11 2:58 ` [PATCH v3 3/6] dt-bindings: clock: loongson2: Add Loongson-2K0500 compatible Binbin Zhou
2024-04-11 7:29 ` Stephen Boyd
2024-04-11 2:58 ` [PATCH v3 4/6] clk: clk-loongson2: Add Loongson-2K0500 clock support Binbin Zhou
2024-04-11 7:29 ` Stephen Boyd
2024-04-11 2:58 ` [PATCH v3 5/6] dt-bindings: clock: loongson2: Add Loongson-2K2000 compatible Binbin Zhou
2024-04-11 7:29 ` Stephen Boyd
2024-04-11 2:58 ` [PATCH v3 6/6] clk: clk-loongson2: Add Loongson-2K2000 clock support Binbin Zhou
2024-04-11 7:29 ` Stephen Boyd
2024-04-11 4:31 ` [PATCH v3 0/6] Add Loongson-2k0500 and Loongson-2k2000 " Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a39fadac1c4150ca51a8c22d749645e1.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox