From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Xingyu Wu <xingyu.wu@starfivetech.com>
Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Conor Dooley <conor@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Rob Herring <robh+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Hal Feng <hal.feng@starfivetech.com>,
William Qiu <william.qiu@starfivetech.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 3/6] dt-bindings: soc: starfive: syscon: Add optional patternProperties
Date: Mon, 20 Mar 2023 08:40:57 +0100 [thread overview]
Message-ID: <a65697f4-0a75-23e2-517c-2784b0c382bc@linaro.org> (raw)
In-Reply-To: <ce674ea9-41ec-2862-c39c-207f0b6c45a2@starfivetech.com>
On 20/03/2023 08:29, Xingyu Wu wrote:
> On 2023/3/20 14:37, Krzysztof Kozlowski wrote:
>> On 20/03/2023 04:54, Xingyu Wu wrote:
>>> On 2023/3/19 20:28, Krzysztof Kozlowski wrote:
>>>> On 16/03/2023 04:05, Xingyu Wu wrote:
>>>>> Add optional compatible and patternProperties.
>>>>>
>>>>> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
>>>>> ---
>>>>> .../soc/starfive/starfive,jh7110-syscon.yaml | 39 ++++++++++++++++---
>>>>> 1 file changed, 33 insertions(+), 6 deletions(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
>>>>> index ae7f1d6916af..b61d8921ef42 100644
>>>>> --- a/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
>>>>> +++ b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
>>>>> @@ -15,16 +15,31 @@ description: |
>>>>>
>>>>> properties:
>>>>> compatible:
>>>>> - items:
>>>>> - - enum:
>>>>> - - starfive,jh7110-aon-syscon
>>>>> - - starfive,jh7110-stg-syscon
>>>>> - - starfive,jh7110-sys-syscon
>>>>> - - const: syscon
>>>>> + oneOf:
>>>>> + - items:
>>>>> + - enum:
>>>>> + - starfive,jh7110-aon-syscon
>>>>> + - starfive,jh7110-stg-syscon
>>>>> + - starfive,jh7110-sys-syscon
>>>>> + - const: syscon
>>>>> + - items:
>>>>> + - enum:
>>>>> + - starfive,jh7110-aon-syscon
>>>>> + - starfive,jh7110-stg-syscon
>>>>> + - starfive,jh7110-sys-syscon
>>>>> + - const: syscon
>>>>> + - const: simple-mfd
BTW, this also looks wrong. You just said that clock controller exists
only in few variants. Also, why sometimes the same device goes with
simple-mfd and sometimies without? It's the same device.
>>>>>
>>>>> reg:
>>>>> maxItems: 1
>>>>>
>>>>> +patternProperties:
>>>>> + # Optional children
>>>>> + "pll-clock-controller":
>>>>
>>>> It's not a pattern.
>>>
>>> Does it use 'properties' instead of 'patternProperties'?
>>
>> Yes.
>>
>>>
>>>>
>>>> Anyway should be clock-controller
>>>
>>> Will fix.
>>>
>>>>
>>>>> + type: object
>>>>> + $ref: /schemas/clock/starfive,jh7110-pll.yaml#
>>>>> + description: Clock provider for PLL.
>>>>> +
>>>>
>>>> You just added these bindings! So the initial submission was incomplete
>>>> on purpose?
>>>>
>>>> No, add complete bindings.
>>>
>>> Does you mean that it should drop the 'description', or add complete 'description',
>>> or add 'compatible', 'clocks' and 'clock-cells' of complete clock-controller bindings?
>>
>> It means it should be squashed with the patch which adds it.
>
> Should I drop the 'decription' here and keep the 'decription' in patch1?
There should be no this patch at all. However I do not understand what
you want to do with description. What's wrong with description?
>
>>
>>>
>>>>
>>>>> required:
>>>>> - compatible
>>>>> - reg
>>>>> @@ -38,4 +53,16 @@ examples:
>>>>> reg = <0x10240000 0x1000>;
>>>>> };
>>>>>
>>>>> + - |
>>>>> + syscon@13030000 {
>>>>
>>>> No need for new example... Just put it in existing one.
>>>>
>>>
>>> Actually, the PLL clock-controller are just set in sys-syscon resgisters. The stg-syscon and
>>> aon-syscon don't need it. So PLL clock-controller node only is added in sys-syscon node.
>>
>> So why having other examples if they are included here? Drop them.
>>
>
> Should I drop the old example of stg-syscon and add a new example of sys-syscon which
> include clock-controller child node?
No, there should be no stg-syscon example, it's useless.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-20 7:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 3:05 [PATCH v2 0/6] Add PLL clocks driver for StarFive JH7110 SoC Xingyu Wu
2023-03-16 3:05 ` [PATCH v2 1/6] dt-bindings: clock: Add StarFive JH7110 PLL clock generator Xingyu Wu
2023-03-19 12:25 ` Krzysztof Kozlowski
2023-03-20 2:41 ` Xingyu Wu
2023-03-16 3:05 ` [PATCH v2 2/6] clk: starfive: Add StarFive JH7110 PLL clock driver Xingyu Wu
2023-03-16 3:05 ` [PATCH v2 3/6] dt-bindings: soc: starfive: syscon: Add optional patternProperties Xingyu Wu
2023-03-19 12:28 ` Krzysztof Kozlowski
2023-03-20 3:54 ` Xingyu Wu
2023-03-20 6:37 ` Krzysztof Kozlowski
2023-03-20 7:29 ` Xingyu Wu
2023-03-20 7:40 ` Krzysztof Kozlowski [this message]
2023-03-20 8:26 ` Xingyu Wu
2023-03-20 8:36 ` Krzysztof Kozlowski
2023-03-20 9:16 ` Xingyu Wu
2023-03-16 3:05 ` [PATCH v2 4/6] dt-bindings: clock: jh7110-syscrg: Add PLL clock inputs Xingyu Wu
2023-03-19 12:25 ` Krzysztof Kozlowski
2023-03-16 3:05 ` [PATCH v2 5/6] clk: starfive: jh7110-sys: Modify PLL clocks source Xingyu Wu
2023-03-16 3:05 ` [PATCH v2 6/6] riscv: dts: starfive: jh7110: Add PLL clock node and modify syscrg node Xingyu Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a65697f4-0a75-23e2-517c-2784b0c382bc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hal.feng@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=william.qiu@starfivetech.com \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox