From: Andrew Lunn <andrew@lunn.ch>
To: Imran Shaik <quic_imrashai@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Ajit Pandey <quic_ajipan@quicinc.com>,
Taniya Das <quic_tdas@quicinc.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: qcom: Add support for Global Clock Controller on QCS8300
Date: Tue, 20 Aug 2024 16:06:03 +0200 [thread overview]
Message-ID: <a7afdd6d-47a1-41c7-8a0d-27919cf5af90@lunn.ch> (raw)
In-Reply-To: <20240820-qcs8300-gcc-v1-2-d81720517a82@quicinc.com>
> +static int gcc_qcs8300_probe(struct platform_device *pdev)
> +{
> + struct regmap *regmap;
> + int ret;
> +
> + regmap = qcom_cc_map(pdev, &gcc_qcs8300_desc);
> + if (IS_ERR(regmap))
> + return PTR_ERR(regmap);
> +
> + ret = qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks,
> + ARRAY_SIZE(gcc_dfs_clocks));
> + if (ret)
> + return ret;
> +
> + /* Keep some clocks always enabled */
> + qcom_branch_set_clk_en(regmap, 0x32004); /* GCC_CAMERA_AHB_CLK */
> + qcom_branch_set_clk_en(regmap, 0x32020); /* GCC_CAMERA_XO_CLK */
It would be good to document why. Why does the camera driver not
enable the clock when it loads?
> + qcom_branch_set_clk_en(regmap, 0x33004); /* GCC_DISP_AHB_CLK */
> + qcom_branch_set_clk_en(regmap, 0x33018); /* GCC_DISP_XO_CLK */
> + qcom_branch_set_clk_en(regmap, 0x7d004); /* GCC_GPU_CFG_AHB_CLK */
> + qcom_branch_set_clk_en(regmap, 0x34004); /* GCC_VIDEO_AHB_CLK */
> + qcom_branch_set_clk_en(regmap, 0x34024); /* GCC_VIDEO_XO_CLK */
Why cannot the display driver enable the clock when it loads?
Andrew
next prev parent reply other threads:[~2024-08-20 14:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 9:36 [PATCH 0/2] clk: qcom: Add support for GCC on QCS8300 Imran Shaik
2024-08-20 9:36 ` [PATCH 1/2] dt-bindings: clock: qcom: Add GCC clocks for QCS8300 Imran Shaik
2024-08-20 9:59 ` Krzysztof Kozlowski
2024-08-20 9:36 ` [PATCH 2/2] clk: qcom: Add support for Global Clock Controller on QCS8300 Imran Shaik
2024-08-20 14:06 ` Andrew Lunn [this message]
2024-08-21 8:24 ` Imran Shaik
2024-08-22 19:53 ` Andrew Lunn
2024-08-20 9:57 ` [PATCH 0/2] clk: qcom: Add support for GCC " Krzysztof Kozlowski
2024-08-20 10:08 ` Imran Shaik
2024-08-20 11:02 ` Krzysztof Kozlowski
2024-08-21 4:39 ` Imran Shaik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7afdd6d-47a1-41c7-8a0d-27919cf5af90@lunn.ch \
--to=andrew@lunn.ch \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox