From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Subject: Re: [PATCH v6 2/5] dt-bindings: media: Add qcom,x1e80100-camss
Date: Tue, 24 Jun 2025 17:02:49 +0200 [thread overview]
Message-ID: <a886e5ea-8561-4a34-ab2c-14f08458a0c0@linaro.org> (raw)
In-Reply-To: <3kprgpvzffupnjbh2aodsowwklliywpemzwpsftd2cng562yuw@37tpwmpemr2c>
On 25/04/2025 10:26, Dmitry Baryshkov wrote:
>>
>> vdd-csiphy0-1p2-supply = <&vreg_1p2_ex0>; <- individual supply in PCB
>> vdd-csiphy1-1p2-supply = <&vreg_1p2_ex1>; <- individual supply in PCB
>>
>> vdd-csiphy0-0p8-supply = <&vreg_0p9_ex0>; <- shared pin in the SoC
>> vdd-csiphy1-0p8-supply = <&vreg_0p9_ex0>; <- shared pin in the SoC
>
> What should driver do if:
>
> vdd-csiphy0-1p2-supply = <&vreg_1p2_ex0>; <- individual supply in PCB
> vdd-csiphy1-1p2-supply = <&vreg_1p2_ex1>; <- individual supply in PCB
>
> vdd-csiphy0-0p8-supply = <&vreg_0p9_ex0>; <- shared pin in the SoC
> vdd-csiphy1-0p8-supply = <&vreg_0p9_ex1>; <- should be shared pin
>
> I don't want to allow DT authors to make this kind of mistake.
I don't follow. What is the mistake here? Using wrong regulator? If so,
the job of the bindings and how we name here is not to create some
bullet-proof, wrong DTS solution.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-24 15:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 13:13 [PATCH v6 0/5] Add dt-bindings and dtsi changes for CAMSS on x1e80100 silicon Bryan O'Donoghue
2025-03-14 13:13 ` [PATCH v6 1/5] dt-bindings: clock: qcom,x1e80100-camcc: Fix the list of required-opps Bryan O'Donoghue
2025-03-16 17:12 ` Krzysztof Kozlowski
2025-03-14 13:14 ` [PATCH v6 2/5] dt-bindings: media: Add qcom,x1e80100-camss Bryan O'Donoghue
2025-04-24 6:40 ` Krzysztof Kozlowski
2025-04-24 9:34 ` Bryan O'Donoghue
2025-04-24 10:07 ` Krzysztof Kozlowski
2025-04-24 10:17 ` Bryan O'Donoghue
2025-04-24 10:45 ` Dmitry Baryshkov
2025-04-24 11:29 ` Bryan O'Donoghue
2025-04-24 11:32 ` Dmitry Baryshkov
2025-04-24 11:51 ` Bryan O'Donoghue
2025-04-25 8:26 ` Dmitry Baryshkov
2025-04-25 8:35 ` Bryan O'Donoghue
2025-04-25 8:51 ` Dmitry Baryshkov
2025-06-24 15:02 ` Krzysztof Kozlowski [this message]
2025-04-24 11:01 ` Vladimir Zapolskiy
2025-04-24 15:54 ` Krzysztof Kozlowski
2025-04-24 16:13 ` Bryan O'Donoghue
2025-04-24 20:08 ` Konrad Dybcio
2025-04-24 21:10 ` Bryan O'Donoghue
2025-04-24 22:38 ` Konrad Dybcio
2025-04-24 10:53 ` Vladimir Zapolskiy
2025-04-24 10:57 ` Krzysztof Kozlowski
2025-03-14 13:14 ` [PATCH v6 3/5] arm64: dts: qcom: x1e80100: Add CAMCC block definition Bryan O'Donoghue
2025-03-14 13:14 ` [PATCH v6 4/5] arm64: dts: qcom: x1e80100: Add CCI definitions Bryan O'Donoghue
2025-03-14 13:14 ` [PATCH v6 5/5] arm64: dts: qcom: x1e80100: Add CAMSS block definition Bryan O'Donoghue
2025-06-24 13:31 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a886e5ea-8561-4a34-ab2c-14f08458a0c0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox