public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bod@kernel.org>
To: Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Jagadeesh Kona <quic_jkona@quicinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Taniya Das <taniya.das@oss.qualcomm.com>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org, aiqun.yu@oss.qualcomm.com,
	tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com,
	yijie.yang@oss.qualcomm.com
Subject: Re: [PATCH 2/9] dt-bindings: clock: sm8450-camcc: Remove sc8280xp camcc to from sm8450 camcc
Date: Thu, 25 Sep 2025 09:29:55 +0100	[thread overview]
Message-ID: <a8ebec72-eee2-4a02-ac6b-57678aa7c50f@kernel.org> (raw)
In-Reply-To: <20250924-knp-mmclk-v1-2-d7ea96b4784a@oss.qualcomm.com>

On 25/09/2025 00:56, Jingyi Wang wrote:
> From: Taniya Das <taniya.das@oss.qualcomm.com>
> 
> SC8280XP camcc only requires the MMCX power domain, unlike SM8450 camcc
> which now supports both MMCX and MXC power domains. Hence move SC8280XP
> camcc from SM8450.
> 
> Fixes: 842fa7482915 ("dt-bindings: clock: qcom,sm8450-camcc: Move sc8280xp camcc to sa8775p camcc")
> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> ---
>   Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> index c1e06f39431e..dbfcc399f10b 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> @@ -63,7 +63,6 @@ allOf:
>           compatible:
>             contains:
>               enum:
> -              - qcom,sc8280xp-camcc
>                 - qcom,sm8450-camcc
>                 - qcom,sm8550-camcc
>       then:
> 

This is not a revert.

Where does the compat string go ?

You are missing the part where you move the compat string to where you 
think it should be...

Also why is this patch appearing in a series about _adding_ Kanaapali to 
CAMCC ?

NAK

---
bod

  reply	other threads:[~2025-09-25  8:30 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-24 23:56 [PATCH 0/9] Add support for Multimedia Clock controllers for Kaanapali Jingyi Wang
2025-09-24 23:56 ` [PATCH 1/9] dt-bindings: clock: qcom: document Kaanapali DISPCC clock controller Jingyi Wang
2025-10-09 10:48   ` Krzysztof Kozlowski
2025-09-24 23:56 ` [PATCH 2/9] dt-bindings: clock: sm8450-camcc: Remove sc8280xp camcc to from sm8450 camcc Jingyi Wang
2025-09-25  8:29   ` Bryan O'Donoghue [this message]
2025-09-25  8:44     ` Taniya Das
2025-09-25 12:47       ` Bryan O'Donoghue
2025-09-25 13:12       ` Bjorn Andersson
2025-09-25 13:14   ` Krzysztof Kozlowski
2025-09-25 21:20   ` Dmitry Baryshkov
2025-09-26  7:06     ` Taniya Das
2025-09-24 23:56 ` [PATCH 3/9] dt-bindings: clock: qcom: Add support for CAMCC for Kaanapali Jingyi Wang
2025-09-25  8:39   ` Bryan O'Donoghue
2025-09-25  8:46     ` Taniya Das
2025-09-25  9:01       ` Bryan O'Donoghue
2025-09-26  7:09         ` Taniya Das
2025-09-24 23:56 ` [PATCH 4/9] dt-bindings: clock: qcom: Add Kaanapali video clock controller Jingyi Wang
2025-09-25  9:02   ` Bryan O'Donoghue
2025-10-09 10:49   ` Krzysztof Kozlowski
2025-09-24 23:56 ` [PATCH 5/9] dt-bindings: clock: qcom: document the Kaanapali GPU Clock Controller Jingyi Wang
2025-09-25  9:04   ` Bryan O'Donoghue
2025-09-24 23:56 ` [PATCH 6/9] clk: qcom: dispcc: Add support for display clock controller Kaanapali Jingyi Wang
2025-09-24 23:56 ` [PATCH 7/9] clk: qcom: camcc: Add support for camera clock controller for Kaanapali Jingyi Wang
2025-09-25  9:10   ` Bryan O'Donoghue
2025-09-26  8:40     ` Taniya Das
2025-09-25 12:45   ` Bryan O'Donoghue
2025-09-26  7:10     ` Taniya Das
2025-09-24 23:56 ` [PATCH 8/9] clk: qcom: Add support for VideoCC driver " Jingyi Wang
2025-09-26  0:55   ` Bryan O'Donoghue
2025-09-24 23:56 ` [PATCH 9/9] drivers: clk: qcom: Add support for GPUCC and GFXCLK " Jingyi Wang
2025-09-25 13:17   ` Bjorn Andersson
2025-09-26  7:24     ` Taniya Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8ebec72-eee2-4a02-ac6b-57678aa7c50f@kernel.org \
    --to=bod@kernel.org \
    --cc=aiqun.yu@oss.qualcomm.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_jkona@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=taniya.das@oss.qualcomm.com \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=trilok.soni@oss.qualcomm.com \
    --cc=vladimir.zapolskiy@linaro.org \
    --cc=yijie.yang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox