Re: [PATCH] clk: vc5: Add support for IDT VersaClock 5P49V5923B

Stephen Boyd
2017-01-10T00:23:27Z

On 01/05, Marek Vasut wrote:
> On 01/05/2017 03:13 PM, Laurent Pinchart wrote:
> > Hi Marek,
>
> Hi!
>
> [...]
>
> >>>>> +static unsigned long vc5_mux_recalc_rate(struct clk_hw *hw,
> >>>>> + unsigned long parent_rate)
> >>>>> +{
> >>>>> + struct vc5_driver_data *vc5 =
> >>>>> + container_of(hw, struct vc5_driver_data, clk_mux);
> >>>>> + unsigned long idiv;
> >>>>> + u8 div;
> >>>>> +
> >>>>> + /* FIXME: Needs locking ? */
> >>>
> >>> Let's fix it then :-)
> >>
> >> I would like to get feedback on this one, does it ?
> >
> > That's a question for Mike or Stephen I believe.
>
> OK

What's the question?

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project