Linux clock framework development
 help / color / mirror / Atom feed
From: Imran Shaik <imran.shaik@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Brian Masney <bmasney@redhat.com>,
	Dmitry Baryshkov <lumag@kernel.org>
Cc: Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
	Taniya Das <taniya.das@oss.qualcomm.com>,
	Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 07/19] clk: qcom: dispcc-qcm2290: Switch to DT index based clk lookup
Date: Wed, 8 Jul 2026 16:48:52 +0530	[thread overview]
Message-ID: <a99edc48-d429-4523-a446-5908ce24b307@oss.qualcomm.com> (raw)
In-Reply-To: <f76c745d-9bc8-4850-8776-45e8b04710f3@oss.qualcomm.com>



On 03-07-2026 12:45 pm, Konrad Dybcio wrote:
> On 7/2/26 8:31 PM, Imran Shaik wrote:
>> Update the QCM2290 DISPCC driver to use the DT index based parent clock
>> lookup to align with the latest convention. While updating the parent data,
>> fix the MDSS MDP clock source parent to use gcc_disp_gpll0_div_clk_src
>> instead of gcc_disp_gpll0_clk_src. This parent is currently unused by the
>> frequency tables, but should be corrected to match the hardware clock plan.
> 
> That change is invalid according to the agatti clock docs -
> DISP_CC_MDSS_MDP_CLK_SRC RCG leg 4 takes GPLL0_OUT_MAIN as
> an input
> 

The HW clock plan naming convention is slightly misleading. Though the 
DISPCC HW clock plan specifies the GPLL0_OUT_MAIN, it is actually 
sourced from external gcc_disp_gpll0_div_clk_src(300MHz) clock.

The above mapping is correctly handled for the mdss_ahb_clk_src already. 
But it is incorrect for the mdss_mdp_clk_src, hence fixing it now.

I will split this fix to a separate patch as Dmitry suggested in the 
other thread.

Thanks,
Imran


  reply	other threads:[~2026-07-08 11:19 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02 18:31 [PATCH v5 00/19] clk: qcom: Add DISPCC and GPUCC support for the Qualcomm Shikra SoC Imran Shaik
2026-07-02 18:31 ` [PATCH v5 01/19] clk: qcom: gcc-qcm2290: Keep the critical clocks always-on from probe Imran Shaik
2026-07-04  0:12   ` Dmitry Baryshkov
2026-07-06 13:01   ` Konrad Dybcio
2026-07-02 18:31 ` [PATCH v5 02/19] dt-bindings: clock: qcom,qcm2290-dispcc: Add DSI1 PHY and sleep clocks Imran Shaik
2026-07-03  6:13   ` Krzysztof Kozlowski
2026-07-02 18:31 ` [PATCH v5 03/19] dt-bindings: clock: qcom,qcm2290-dispcc: Add missing power-domains property Imran Shaik
2026-07-03  6:15   ` Krzysztof Kozlowski
2026-07-02 18:31 ` [PATCH v5 04/19] dt-bindings: clock: qcom: Add Qualcomm Shikra Display clock controller Imran Shaik
2026-07-03  6:14   ` Krzysztof Kozlowski
2026-07-02 18:31 ` [PATCH v5 05/19] dt-bindings: clock: qcom: Add Qualcomm Shikra GPU " Imran Shaik
2026-07-03  6:14   ` Krzysztof Kozlowski
2026-07-02 18:31 ` [PATCH v5 06/19] clk: qcom: dispcc-qcm2290: Move to the latest common qcom_cc_probe() model Imran Shaik
2026-07-03  7:13   ` Konrad Dybcio
2026-07-08 11:17     ` Imran Shaik
2026-07-02 18:31 ` [PATCH v5 07/19] clk: qcom: dispcc-qcm2290: Switch to DT index based clk lookup Imran Shaik
2026-07-03  7:15   ` Konrad Dybcio
2026-07-08 11:18     ` Imran Shaik [this message]
2026-07-04  0:17   ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 08/19] clk: qcom: dispcc-qcm2290: Set HW_CTRL_TRIGGER flag for GDSC Imran Shaik
2026-07-03  7:24   ` Konrad Dybcio
2026-07-08 11:19     ` Imran Shaik
2026-07-02 18:31 ` [PATCH v5 09/19] clk: qcom: qcm2290: Set POLL_CFG_GDSCR flag for DISPCC and GPUCC GDSCs Imran Shaik
2026-07-03  7:28   ` Konrad Dybcio
2026-07-04  0:18   ` Dmitry Baryshkov
2026-07-08 11:19     ` Imran Shaik
2026-07-02 18:31 ` [PATCH v5 10/19] clk: qcom: qcm2290: Add RETAIN_FF_ENABLE " Imran Shaik
2026-07-04  0:19   ` Dmitry Baryshkov
2026-07-08 11:20     ` Imran Shaik
2026-07-06 13:02   ` Konrad Dybcio
2026-07-02 18:31 ` [PATCH v5 11/19] clk: qcom: qcm2290: Update DISPCC and GPUCC GDSC *wait_val values Imran Shaik
2026-07-03  7:19   ` Konrad Dybcio
2026-07-04  0:19     ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 12/19] clk: qcom: gpucc-qcm2290: Drop pm_clk handling Imran Shaik
2026-07-03  7:29   ` Konrad Dybcio
2026-07-04  0:19   ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 13/19] clk: qcom: gpucc-qcm2290: Move to the latest common qcom_cc_probe() model Imran Shaik
2026-07-03  7:11   ` Konrad Dybcio
2026-07-04  0:20   ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 14/19] clk: qcom: gpucc-qcm2290: Keep the critical clocks always-on from probe Imran Shaik
2026-07-03  7:30   ` Konrad Dybcio
2026-07-04  0:21   ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 15/19] clk: qcom: gpucc-qcm2290: Park RCG's clk source at XO during disable Imran Shaik
2026-07-03  7:42   ` Konrad Dybcio
2026-07-04  0:23   ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 16/19] clk: qcom: Add support for Qualcomm GPU Clock Controller on Shikra Imran Shaik
2026-07-02 18:31 ` [PATCH v5 17/19] arm64: dts: qcom: agatti: Add DSI1 PHY and sleep clocks to DISPCC node Imran Shaik
2026-07-02 18:31 ` [PATCH v5 18/19] arm64: dts: qcom: agatti: Add missing CX power domain to DISPCC Imran Shaik
2026-07-03  7:09   ` Konrad Dybcio
2026-07-04  0:24   ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 19/19] arm64: dts: qcom: shikra: Add support for DISPCC/GPUCC nodes Imran Shaik
2026-07-06 13:00   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a99edc48-d429-4523-a446-5908ce24b307@oss.qualcomm.com \
    --to=imran.shaik@oss.qualcomm.com \
    --cc=ajit.pandey@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=bmasney@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jagadeesh.kona@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=lumag@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=taniya.das@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox