Re: [PATCH v2 1/5] clk: x86: Move clk-pmc-atom register defines to include/linux/platform_data/x86/pmc_atom.h

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2860 bytes --]

On Sun, 7 Jan 2024, Hans de Goede wrote:

> Move the register defines for the Atom (Bay Trail, Cherry Trail) PMC
> clocks to include/linux/platform_data/x86/pmc_atom.h.
> 
> This is a preparation patch to extend the S0i3 readiness checks
> in drivers/platform/x86/pmc_atom.c with checking that the PMC
> clocks are off on suspend entry.
> 
> Note these are added to include/linux/platform_data/x86/pmc_atom.h rather
> then to include/linux/platform_data/x86/clk-pmc-atom.h because the former
> already has all the other Atom PMC register defines.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/clk/x86/clk-pmc-atom.c             | 13 +------------
>  include/linux/platform_data/x86/pmc_atom.h | 13 +++++++++++++
>  2 files changed, 14 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/clk/x86/clk-pmc-atom.c b/drivers/clk/x86/clk-pmc-atom.c
> index 2974dd0ec6f4..5ec9255e33fa 100644
> --- a/drivers/clk/x86/clk-pmc-atom.c
> +++ b/drivers/clk/x86/clk-pmc-atom.c
> @@ -11,23 +11,12 @@
>  #include <linux/err.h>
>  #include <linux/io.h>
>  #include <linux/platform_data/x86/clk-pmc-atom.h>
> +#include <linux/platform_data/x86/pmc_atom.h>
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  
>  #define PLT_CLK_NAME_BASE	"pmc_plt_clk"
>  
> -#define PMC_CLK_CTL_OFFSET		0x60
> -#define PMC_CLK_CTL_SIZE		4
> -#define PMC_CLK_NUM			6
> -#define PMC_CLK_CTL_GATED_ON_D3		0x0
> -#define PMC_CLK_CTL_FORCE_ON		0x1
> -#define PMC_CLK_CTL_FORCE_OFF		0x2
> -#define PMC_CLK_CTL_RESERVED		0x3
> -#define PMC_MASK_CLK_CTL		GENMASK(1, 0)
> -#define PMC_MASK_CLK_FREQ		BIT(2)
> -#define PMC_CLK_FREQ_XTAL		(0 << 2)	/* 25 MHz */
> -#define PMC_CLK_FREQ_PLL		(1 << 2)	/* 19.2 MHz */
> -
>  struct clk_plt_fixed {
>  	struct clk_hw *clk;
>  	struct clk_lookup *lookup;
> diff --git a/include/linux/platform_data/x86/pmc_atom.h b/include/linux/platform_data/x86/pmc_atom.h
> index b8a701c77fd0..557622ef0390 100644
> --- a/include/linux/platform_data/x86/pmc_atom.h
> +++ b/include/linux/platform_data/x86/pmc_atom.h
> @@ -43,6 +43,19 @@
>  				BIT_ORED_DEDICATED_IRQ_GPSC | \
>  				BIT_SHARED_IRQ_GPSS)
>  
> +/* External clk generator settings */
> +#define PMC_CLK_CTL_OFFSET		0x60
> +#define PMC_CLK_CTL_SIZE		4
> +#define PMC_CLK_NUM			6
> +#define PMC_CLK_CTL_GATED_ON_D3		0x0
> +#define PMC_CLK_CTL_FORCE_ON		0x1
> +#define PMC_CLK_CTL_FORCE_OFF		0x2
> +#define PMC_CLK_CTL_RESERVED		0x3
> +#define PMC_MASK_CLK_CTL		GENMASK(1, 0)
> +#define PMC_MASK_CLK_FREQ		BIT(2)
> +#define PMC_CLK_FREQ_XTAL		(0 << 2)	/* 25 MHz */
> +#define PMC_CLK_FREQ_PLL		(1 << 2)	/* 19.2 MHz */

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Noting the last two look like:
#define PMC_CLK_FREQ_XTAL	FIELD_PREP(PMC_MASK_CLK_FREQ, 0) /* 25 MHz */
#define PMC_CLK_FREQ_PLL	FIELD_PREP(PMC_MASK_CLK_FREQ, 1) /* 19.2 MHz */


-- 
 i.