From: Drew Fustini <fustini@kernel.org>
To: Troy Mitchell <troy.mitchell@linux.dev>
Cc: Icenowy Zheng <uwu@icenowy.me>, Guo Ren <guoren@kernel.org>,
Fu Wei <wefu@redhat.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Michal Wilczynski <m.wilczynski@samsung.com>,
Yao Zi <ziyao@disroot.org>, Han Gao <rabenda.cn@gmail.com>,
linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: thead: th1520-ap: describe gate clocks with clk_gate
Date: Sat, 16 Aug 2025 16:16:39 -0700 [thread overview]
Message-ID: <aKERV0c7jat//279@x1> (raw)
In-Reply-To: <aKA9QxKo3fg-bdNa@troy-wujie14pro-arch>
On Sat, Aug 16, 2025 at 04:11:47PM +0800, Troy Mitchell wrote:
> On Thu, Aug 14, 2025 at 01:11:35AM +0800, Icenowy Zheng wrote:
> > Similar to previous situation of mux clocks, the gate clocks of
> > clk-th1520-ap drivers are also using a helper that creates a temporary
> > struct clk_hw and abandons the struct clk_hw in struct ccu_common, which
> > prevents clock gates to be clock parents.
> >
> > Do the similar refactor of dropping struct ccu_common and directly use
> > struct clk_gate here.
> >
> > This patch mimics the refactor done on struct ccu_mux at [1].
> >
> > [1] https://lore.kernel.org/all/20250722080535.60027-2-ziyao@disroot.org/
> Should we remove this link to the cover-letter?
> - Troy
Good point. Yes, I think this would be better than a link as it is now
in master:
54edba916e29 ("clk: thead: th1520-ap: Describe mux clocks with clk_mux")
There is already v2 posted so no need for v3 just for this. I can fixup
when applying.
Thanks,
Drew
next prev parent reply other threads:[~2025-08-16 23:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 17:11 [PATCH 0/2] clk: thead: th1520-ap: allow gate cascade and fix padctrl0 Icenowy Zheng
2025-08-13 17:11 ` [PATCH 1/2] clk: thead: th1520-ap: describe gate clocks with clk_gate Icenowy Zheng
2025-08-14 3:12 ` Guo Ren
2025-08-14 5:02 ` Icenowy Zheng
2025-08-14 6:41 ` Guo Ren
2025-08-14 6:47 ` Icenowy Zheng
2025-08-15 23:45 ` Drew Fustini
2025-08-16 8:11 ` Troy Mitchell
2025-08-16 23:16 ` Drew Fustini [this message]
2025-08-13 17:11 ` [PATCH 2/2] clk: thead: th1520-ap: fix parent of padctrl0 clock Icenowy Zheng
2025-08-14 3:08 ` Guo Ren
2025-08-14 5:03 ` Icenowy Zheng
2025-08-15 23:45 ` Drew Fustini
2025-08-16 8:01 ` Troy Mitchell
2025-08-13 17:16 ` [PATCH 0/2] clk: thead: th1520-ap: allow gate cascade and fix padctrl0 Icenowy Zheng
2025-08-14 3:10 ` Guo Ren
2025-08-15 23:28 ` Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKERV0c7jat//279@x1 \
--to=fustini@kernel.org \
--cc=guoren@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=m.wilczynski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=rabenda.cn@gmail.com \
--cc=sboyd@kernel.org \
--cc=troy.mitchell@linux.dev \
--cc=uwu@icenowy.me \
--cc=wefu@redhat.com \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox