From: Brian Masney <bmasney@redhat.com>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mo Elbadry <elbadrym@google.com>,
Rom Lemarchand <romlem@google.com>,
William Kennington <wak@google.com>,
Yuxiao Zhang <yuxiaozhang@google.com>,
"wthai@nvidia.com" <wthai@nvidia.com>,
"leohu@nvidia.com" <leohu@nvidia.com>,
"dkodihalli@nvidia.com" <dkodihalli@nvidia.com>,
"spuranik@nvidia.com" <spuranik@nvidia.com>
Subject: Re: [PATCH v15 3/3] clk: aspeed: add AST2700 clock driver
Date: Mon, 22 Dec 2025 11:59:56 -0500 [thread overview]
Message-ID: <aUl5DPMq8jC1xjRu@redhat.com> (raw)
In-Reply-To: <TY2PPF5CB9A1BE64DCD487138F3BAC4FD34F2FCA@TY2PPF5CB9A1BE6.apcprd06.prod.outlook.com>
Hi Ryan,
On Mon, Oct 27, 2025 at 06:24:59AM +0000, Ryan Chen wrote:
> Hello Stephen,
> Will this be accepted in clk-next?
Given that aspeed is a SoC vendor, and you already have multiple clk
drivers, I think at this point your best bet is to do what the other SoC
vendors currently do. I think you should:
- Create a new subdirectory drivers/clk/aspeed/
- Move the existing aspeed clk drivers into this subdirectory, and
update the Makefiles / Kconfigs as appropriate.
- Add a new entry to the MAINTAINERS file for the aspeed clk drivers.
You probably also want to have that entry cover the reset driver,
and any other aspeed-specific drivers as well.
- Post that patch set. Include this new clk driver as a separate patch
in that series. Feel free to CC me to the series and I'll review it
for you.
- After it's reviewed, wait a week or two, and send Stephen a
'GIT PULL' using git request-pull. I can help you with the workflow
if needed.
One important detail is that you want to base your branch for the GIT
PULL on the lowest common denominator, which is usually the latest rc1
from Linus. So even if Linus is at rc5, try to base yours on rc1, unless
there's some issue, and you need to document why. Stephen should get the
merge to newer rcX branches from Linus, and not you.
When you send a PULL to Stephen, you can use 'b4 am' to assemble the
contents of your branch. When I sent him a PULL a few months ago, I
included the b4 commands that I used.
https://lore.kernel.org/all/aL8MXYrR5uoBa4cB@x1/
If he accepts the pull, you'll still need to post your patches to the
clk mailinglist, and have them reviewed on list. Folks from aspeed
should do that review publicly on the list.
Brian
next prev parent reply other threads:[~2025-12-22 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 7:25 [PATCH v15 0/3] Add support for AST2700 clk driver Ryan Chen
2025-10-10 7:25 ` [PATCH v15 1/3] dt-bindings: clock: ast2700: modify soc0/1 clock define Ryan Chen
2025-10-10 7:25 ` [PATCH v15 2/3] reset: aspeed: register AST2700 reset auxiliary bus device Ryan Chen
2025-10-10 7:25 ` [PATCH v15 3/3] clk: aspeed: add AST2700 clock driver Ryan Chen
2025-10-27 6:24 ` Ryan Chen
2025-12-22 16:59 ` Brian Masney [this message]
2025-12-24 5:39 ` Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUl5DPMq8jC1xjRu@redhat.com \
--to=bmasney@redhat.com \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dkodihalli@nvidia.com \
--cc=elbadrym@google.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=leohu@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=romlem@google.com \
--cc=ryan_chen@aspeedtech.com \
--cc=sboyd@kernel.org \
--cc=spuranik@nvidia.com \
--cc=wak@google.com \
--cc=wthai@nvidia.com \
--cc=yuxiaozhang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).