[PATCH] clk: xgene: Fix mapping leak in xgene_pllclk_init()

[PATCH] clk: xgene: Fix mapping leak in xgene_pllclk_init()

[Geert Uytterhoeven]

If xgene_register_clk_pll() fails, the mapped register block is never
unmapped.

Fixes: 308964caeebc45eb ("clk: Add APM X-Gene SoC clock driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/clk/clk-xgene.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/clk-xgene.c b/drivers/clk/clk-xgene.c
index ba3b1057e4f0c61d..abb6c8fcdc91fad3 100644
--- a/drivers/clk/clk-xgene.c
+++ b/drivers/clk/clk-xgene.c
@@ -188,6 +188,8 @@ static void xgene_pllclk_init(struct device_node *np, enum xgene_pll_type pll_ty
 		of_clk_add_provider(np, of_clk_src_simple_get, clk);
 		clk_register_clkdev(clk, clk_name, NULL);
 		pr_debug("Add %s clock PLL\n", clk_name);
+	} else {
+		iounmap(reg);
 	}
 }
 
-- 
2.43.0

Re: [PATCH] clk: xgene: Fix mapping leak in xgene_pllclk_init()

[Brian Masney]

On Thu, Mar 05, 2026 at 11:11:16AM +0100, Geert Uytterhoeven wrote:
> If xgene_register_clk_pll() fails, the mapped register block is never
> unmapped.
> 
> Fixes: 308964caeebc45eb ("clk: Add APM X-Gene SoC clock driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Brian Masney <bmasney@redhat.com>

Re: [PATCH] clk: xgene: Fix mapping leak in xgene_pllclk_init()

[Stephen Boyd]

Quoting Geert Uytterhoeven (2026-03-05 02:11:16)
> If xgene_register_clk_pll() fails, the mapped register block is never
> unmapped.
> 
> Fixes: 308964caeebc45eb ("clk: Add APM X-Gene SoC clock driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Applied to clk-next