From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FCC544BC9B for ; Fri, 27 Feb 2026 16:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772208087; cv=none; b=lGGPRYkhiOm+BrJLZ6K9qHZb+8trmxvcfW/NRsrUaAs7HgV74+2ltulUew4R7cyUu1wm6MpY7BObYNvNVPRunfJZdnObddtp1i9jt98tpowXOHgto0TIBiTRFaUDeeSxIh5TifbE1XWopwAEFkGQpY2leEqbvneLQS6s2QUhkpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772208087; c=relaxed/simple; bh=uG30mxTLvgev7yhGcukdOHSvL8riXeEx3HzvZgQdC0g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YQf3bsZyUvRy0s03krkbCHTWbrmzm7AQ6XoKNw/IIx5JDzsbjAPj1ELNANzZwaz7AN9VXqquMbHuoeuf84O2L1OWo97iKNpglEZ6EO4ECh1awJ4QUdrXhK5otfWqp3QJobpOmkNJbZcA80f0L9ccfhE6KSTWmirWvemqGXaMYBY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KH49a/Mi; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=fHbBfayd; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KH49a/Mi"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="fHbBfayd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772208080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RrFYWHheWeN4qF9K8AbBYu4TLD27jVlJtkV6clM5Tt0=; b=KH49a/Mi0PY+6EoBfeFJycoEEbyzzbHvHL04cvejrh/DwfoRbXHbjecYl9h4zftuB/YtT3 7z1Ecyts9h2+HY7q2TD8/xxJ5ZUTeX4trOevaJiaOoMnlWjr0d3dVL4sPuKjJeSkk7WnEg Zan1yKtn/9QgrjbtH1WuLwokSjePvw8= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-365-nJJkqHF3PK6qk6_Ue6vCkg-1; Fri, 27 Feb 2026 11:01:17 -0500 X-MC-Unique: nJJkqHF3PK6qk6_Ue6vCkg-1 X-Mimecast-MFC-AGG-ID: nJJkqHF3PK6qk6_Ue6vCkg_1772208077 Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-94de3e732f6so28352946241.1 for ; Fri, 27 Feb 2026 08:01:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772208077; x=1772812877; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=RrFYWHheWeN4qF9K8AbBYu4TLD27jVlJtkV6clM5Tt0=; b=fHbBfaydj8Z9HjG176bwgF21Ydk4toZPEnrRk5FiPraBMn+ozMxdM1hNXPh8SFIs80 GB92NopO14s+PfMCRJ+btkTabOSZcEH09ghTEvujHBW23LgxTxKiSxKDT06X74MYRlnA dhI1XuFiqQn4IwEnBGp712CnBa7y664k+hc3PVR1ENZh6Lg9YhhPWOV45pJ8mU4Mf0EU 3p/QNeUI8xwKICAN5FjdrgBVdSN1YT6dB6kmG31Lw/HlVFSzdKaVXYj39D21IVn4wcN+ t2+kzhx/CTdkMo2ojC49G/oUltKrTiXOuSntPxeE0AAjpJnLy4zpck2eGA+6OCS0lIHO g01Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772208077; x=1772812877; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RrFYWHheWeN4qF9K8AbBYu4TLD27jVlJtkV6clM5Tt0=; b=O1OMEFzcLo1W6v9xu9dr+H5JL/U7qm1phxr1e1rfc3Fvdn8OcaPsBhLqPnzjA5EujG Ta74TpEOQAc2n4d43LzUhF3ZB4x7gsra+cv/A481dHxf+6wK78E3/ZgsQhejRJECYzue qF5LBUhhO0JaQk0Tz0RZQn2+bVIPURgVPnaBff2GkhboWK4IzbKxM39QnjBK8mLX1xh8 XMvLvEHULgX9fkWYKZcXJkHGG+ZOv75C45WW43gwNlYV2KGdqCgi582lKnMf+ju13acA RN8S0odgY83MY7lbPBMqtBei1QzEjGrdcE3S9mPoW1LoYmH2h+Aue/l2j4Y4SUWiuD2/ Ur/Q== X-Forwarded-Encrypted: i=1; AJvYcCVakNv/+JKOXrt1DeOpOSJwTBVtBZUO14DzVhsv36ix5fDRVy0vyqwGDymtw7iWzL97uGdzPtdhG7U=@vger.kernel.org X-Gm-Message-State: AOJu0YyTPJ57niW65I8dGpEs4oVj57T4is1ItQC0zINYOUL4L07yUTxv l9+/dj2rndWFKWjA/6xmt/6fuOeshJ2vicMu24zPW0nkf5SrZo0lRROCOI3hFVZDPOFVDUHKmD7 vRjsLcy8vHXDdAg97w1inmkPTodk16Csyf5t3+LCFfekcnyippWJX4FDlg9d8Sg== X-Gm-Gg: ATEYQzwGJfieEzM3wPb7bRJoqSIhPTZ03WWRV2gbbPUDBVBl5YrlweuNHdKAGeCXOpt WzhZYB7FgiFAQzDKqNVoe25A/uChv6hMLi04NItcJKSxeQN1XChKUkmQWvhmisl/CRvoq8jwHMR w4qPNaxmSAsp2AWbwgT+qqdFaJqkOWqvLiFkAso0LNeHQA2ryDM+1C8bweD9myXRHA8lobDtbKO +GvET6DeeEE9/NFLbykYPNkjmhnOQSoXMQRjMv4T4YsGIaaB/lxxHlLD2lXK/k2fAux6NYuvQny IBocJTZ/QWKPdHoiR2fOS1/UCnZzuwUvCOZJgRyAxx6ZUJcxllntJSfIB5GlY9gbqvHsmVRdWUE 4YTmHrM3YKNef3jGDIh0vbllbyaez5SU1Zko5n9PVqRx1z2qMw+MLOQP7 X-Received: by 2002:a05:6102:3f10:b0:5f5:3969:f762 with SMTP id ada2fe7eead31-5ff3256618dmr1939726137.31.1772208075605; Fri, 27 Feb 2026 08:01:15 -0800 (PST) X-Received: by 2002:a05:6102:3f10:b0:5f5:3969:f762 with SMTP id ada2fe7eead31-5ff3256618dmr1939502137.31.1772208074497; Fri, 27 Feb 2026 08:01:14 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-899c715a87esm44464306d6.4.2026.02.27.08.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 08:01:13 -0800 (PST) Date: Fri, 27 Feb 2026 11:01:12 -0500 From: Brian Masney To: Biju Das Cc: Chris Brandt , geert , Michael Turquette , Stephen Boyd , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" Subject: Re: [PATCH 11/13] clk: renesas: rzg2l-cpg: drop determine_rate op and use CLK_ROUNDING_FW_MANAGED flag Message-ID: References: <20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com> <20260226-clk-det-rate-fw-managed-v1-11-4421dd2f6dc6@redhat.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) On Fri, Feb 27, 2026 at 03:57:28PM +0000, Biju Das wrote: > > -----Original Message----- > > From: Brian Masney > > Sent: 27 February 2026 15:48 > > Subject: Re: [PATCH 11/13] clk: renesas: rzg2l-cpg: drop determine_rate op and use > > CLK_ROUNDING_FW_MANAGED flag > > > > Hi Biju, > > > > On Fri, Feb 27, 2026 at 03:23:19PM +0000, Biju Das wrote: > > > > -----Original Message----- > > > > From: Geert Uytterhoeven > > > > Sent: 27 February 2026 15:09 > > > > Subject: Re: [PATCH 11/13] clk: renesas: rzg2l-cpg: drop > > > > determine_rate op and use CLK_ROUNDING_FW_MANAGED flag > > > > > > > > On Fri, 27 Feb 2026 at 16:01, Brian Masney wrote: > > > > > On Fri, Feb 27, 2026 at 09:20:09AM +0100, Geert Uytterhoeven wrote: > > > > > > On Thu, 26 Feb 2026 at 19:18, Brian Masney wrote: > > > > > > > This clk driver has a noop determine_rate clk op. Drop this > > > > > > > empty function, and enable the CLK_ROUNDING_FW_MANAGED flag. > > > > > > > > > > > > > > Signed-off-by: Brian Masney > > > > > > > > > > > > Thanks for your patch! > > > > > > > > > > > > > --- a/drivers/clk/renesas/rzg2l-cpg.c > > > > > > > +++ b/drivers/clk/renesas/rzg2l-cpg.c > > > > > > > > > > > @@ -1041,7 +1034,7 @@ rzg2l_cpg_sipll5_register(const struct cpg_core_clk *core, > > > > > > > init.name = core->name; > > > > > > > parent_name = __clk_get_name(parent); > > > > > > > init.ops = &rzg2l_cpg_sipll5_ops; > > > > > > > - init.flags = 0; > > > > > > > + init.flags = CLK_ROUNDING_FW_MANAGED; > > > > > > > > > > > > Iff this is the Right Thing To Do (TM), it needs a comment, as > > > > > > this clock is not managed by firmware. > > > > > > > > > > Before I start a larger discussion on patch 1 with more people > > > > > about a name for this flag, help me understand why this provider > > > > > has a noop determine rate. Is the hardware eventually programmed > > > > > with a rate that's close enough to what was passed in? Or it > > > > > doesn't really matter what the clock rate is, just as long as it > > > > > is running? Or should the determine_rate function be filled out in this particular case? > > > > > > > > I'd like to defer to Biju, who added the empty round^Wdetermine rate function. > > > > > > PLL is capable of generating any frequency. that is the reason. > > > > > > But we could, call rzg2l_cpg_get_foutpostdiv_rate() from > > > determine_rate() as modified rzg2l_cpg_get_foutpostdiv_rate()[1] can > > > return errors > > > > > > [1] > > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tr > > > ee/drivers/clk/renesas/rzg2l-cpg.c?h=next-20260227#n590 > > > > OK. So how do you all want to proceed here? > > > > Do you want to fill out the determine rate in this driver? If so, we can just drop this particular > > patch from this series. > > We plan to fill out the determine rate later, as it can return error. OK, if you are planning to fill out the determine rate, then I'll just skip over this driver to avoid the code churn. Brian