From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Maxime Ripard <maxime@cerno.tech>,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Tim Gover <tim.gover@raspberrypi.com>,
Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH] clk: bcm: dvp: Select the reset framework
Date: Tue, 08 Sep 2020 16:42:35 +0200 [thread overview]
Message-ID: <aaa5053e14d8dfd0aa818d9cd4230548eb374306.camel@suse.de> (raw)
In-Reply-To: <20200903082636.3844629-1-maxime@cerno.tech>
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
On Thu, 2020-09-03 at 10:26 +0200, Maxime Ripard wrote:
> The DVP driver depends both on the RESET_SIMPLE driver but also on the
> reset framework itself. Let's make sure we have it enabled.
>
> Fixes: 1bc95972715a ("clk: bcm: Add BCM2711 DVP driver")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> drivers/clk/bcm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/bcm/Kconfig b/drivers/clk/bcm/Kconfig
> index 784f12c72365..ec738f74a026 100644
> --- a/drivers/clk/bcm/Kconfig
> +++ b/drivers/clk/bcm/Kconfig
> @@ -5,6 +5,7 @@ config CLK_BCM2711_DVP
> depends on ARCH_BCM2835 ||COMPILE_TEST
> depends on COMMON_CLK
> default ARCH_BCM2835
> + select RESET_CONTROLLER
> select RESET_SIMPLE
> help
> Enable common clock framework support for the Broadcom BCM2711
Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
I guess this should go through the clk tree right?
Thanks!
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-08 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 8:26 [PATCH] clk: bcm: dvp: Select the reset framework Maxime Ripard
2020-09-08 14:42 ` Nicolas Saenz Julienne [this message]
2020-09-10 7:53 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaa5053e14d8dfd0aa818d9cd4230548eb374306.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=dave.stevenson@raspberrypi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maxime@cerno.tech \
--cc=mturquette@baylibre.com \
--cc=phil@raspberrypi.com \
--cc=sboyd@kernel.org \
--cc=tim.gover@raspberrypi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox