From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: "Herve Codina (Schneider Electric)" <herve.codina@bootlin.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
Pascal Eberhard <pascal.eberhard@se.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 2/3] watchdog: rzn1: Use dev_err_probe()
Date: Fri, 13 Mar 2026 18:12:05 +0100 [thread overview]
Message-ID: <abRFZafNDwf_nG-J@ninjato> (raw)
In-Reply-To: <20260313092417.294356-3-herve.codina@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On Fri, Mar 13, 2026 at 10:24:15AM +0100, Herve Codina (Schneider Electric) wrote:
> In the probe() function the following pattern is present several times:
> if (err) {
> dev_err(dev, ...);
> return err;
> }
>
> Replace them by dev_err_probe() calls.
>
> Signed-off-by: Herve Codina (Schneider Electric) <herve.codina@bootlin.com>
I am a fan of such changes, though :)
> clk_rate = clk_get_rate(clk);
> - if (!clk_rate) {
> - dev_err(dev, "failed to get the clock rate\n");
> - return -EINVAL;
> - }
> + if (!clk_rate)
> + return dev_err_probe(dev, -EINVAL, "failed to get the clock\n");
Wrong error string, we handle "clock rate" here.
With that fixed:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-03-13 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 9:24 [PATCH v2 0/3] watchdog: rzn1: Add support for direct hardware reset Herve Codina (Schneider Electric)
2026-03-13 9:24 ` [PATCH v2 1/3] watchdog: rzn1: Fix reverse xmas tree declaration Herve Codina (Schneider Electric)
2026-03-13 17:09 ` Wolfram Sang
2026-03-13 9:24 ` [PATCH v2 2/3] watchdog: rzn1: Use dev_err_probe() Herve Codina (Schneider Electric)
2026-03-13 17:12 ` Wolfram Sang [this message]
2026-03-13 9:24 ` [PATCH v2 3/3] clk: renesas: r9a06g032: Enable watchdog reset sources Herve Codina (Schneider Electric)
2026-03-13 17:15 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abRFZafNDwf_nG-J@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=geert+renesas@glider.be \
--cc=herve.codina@bootlin.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=miquel.raynal@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=pascal.eberhard@se.com \
--cc=sboyd@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox