From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 480AA3C9ECD for ; Fri, 13 Mar 2026 17:12:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773421930; cv=none; b=GQ1nq8a8iLJU39iTSXalKKDjJNcWMJEsAPAny73lIOaBXESXd+UQuYPdUrIwa5cNThrh1gUU5Afqv+gyuwPtemqIkfsnuTi3o5c4JuV+QS5U/UVzr9g74Rm3AG4jLGtwqoIeATNkmS9nRodq+e4NXuBCuD0fRY3uJKMhR/Nnzg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773421930; c=relaxed/simple; bh=O5iNi9gq2K/Xj6jBGUUooeQQxIc+FNKg/ElhWnnk/kc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tkXLcHep5e498hdTyDRS5G1q8kPSYNP4S4HyaxBycEBftqpj+RDsuO69laJjaKz4cxHOX0ClkMFPS3S5yCNkPj2B2CnGPFOr1QDwPVNBP7EUjUHlQVerAt/XJQPNA5QcsRwTupHse4eCi/7IGrpLvAIPschJTFmsHTfE9O1t/CQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=K5WsMc0v; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="K5WsMc0v" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=RScD gpusaFCjKqFXN1DPhYO1G0PQt+fxfmMxwvNGDVY=; b=K5WsMc0vDQi/9494fNzL OS6ZEI42mq+htgxDwZ1qcs5bT5pN+DcMPQGqgg3AUI4CU525fLTNV7H8pmU4S7mc 11RolFrLCA+nv+nPimxLX6PyXUXaz/m9F45tmDRAX+bgYrY1VtRUt/d/52NBPw1I 7Ubqf2LZERmZto/kCd9ZqXL8eMalN7yjnWy/Bx2QPlYXyuP8h4U8DFbmBNVgIJnn o9a4NebkPQEiXeBhfPDhmIGoLg7Bzai9kH4dZXUhqUL0olnKN7GNMajSUDXlj1MX z1J6JiJcCflp3arqufTxkHbSpZXCxn1Z3R2tNZgbJVhaEoEwkibWOyMMfwpENMOo Qw== Received: (qmail 388208 invoked from network); 13 Mar 2026 18:12:06 +0100 Received: by mail.zeus03.de with UTF8SMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 13 Mar 2026 18:12:06 +0100 X-UD-Smtp-Session: l3s3148p1@dprw9+pMTLAujnuR Date: Fri, 13 Mar 2026 18:12:05 +0100 From: Wolfram Sang To: "Herve Codina (Schneider Electric)" Cc: Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Wim Van Sebroeck , Guenter Roeck , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Pascal Eberhard , Miquel Raynal , Thomas Petazzoni Subject: Re: [PATCH v2 2/3] watchdog: rzn1: Use dev_err_probe() Message-ID: References: <20260313092417.294356-1-herve.codina@bootlin.com> <20260313092417.294356-3-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PU7k8Px3u5FH65Nq" Content-Disposition: inline In-Reply-To: <20260313092417.294356-3-herve.codina@bootlin.com> --PU7k8Px3u5FH65Nq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 13, 2026 at 10:24:15AM +0100, Herve Codina (Schneider Electric)= wrote: > In the probe() function the following pattern is present several times: > if (err) { > dev_err(dev, ...); > return err; > } >=20 > Replace them by dev_err_probe() calls. >=20 > Signed-off-by: Herve Codina (Schneider Electric) I am a fan of such changes, though :) > clk_rate =3D clk_get_rate(clk); > - if (!clk_rate) { > - dev_err(dev, "failed to get the clock rate\n"); > - return -EINVAL; > - } > + if (!clk_rate) > + return dev_err_probe(dev, -EINVAL, "failed to get the clock\n"); Wrong error string, we handle "clock rate" here. With that fixed: Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --PU7k8Px3u5FH65Nq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmm0RWUACgkQFA3kzBSg KbaJKw//T4S2VjebxxFN6wbjjbI1R15Xx9PYH9hOVj48in0IzA2zNxOoiG3SOeKR 3jPmD414zXntvMeHluGRaEWBPXpIvPUtbI+q1C1BvEBBa2o/dwBXa1Ez+py6R7ui irazyeOhMaG39mq+6looW1cQPfltNaXCaDr2TCmW/riYg3YDNlEaPsfVdVXCYotx DZVnlWsMR5mw8WB0eUnonpPrv07fDPo//iZHa0bxzlR4PY2X7HW8vJKf5YxGMviE 8UCrQJD/LuEykphRxEtTh3CNs70IN1ZDLPMY9Jm/If+FbLHqVrDQktN2de3WTqFN IDguAEBkwrPKWT48y2LKqT9LbtG7zzoifnQnMbDo+Tcof5hUX2Yyu+Tsgl2xgqSR P9A9P5uKvzTcgINc+KN6shMUG81bFPBDyHO4AE0s5Ek6ZAVFm9Dh9mhCqHLNNoX/ 2p6ELHaazHcWVyIjKhhj5HmdW5LI2cC3asK2C+JuF/aQyAJ5aJ9ZAhVEW6I3QnIx uddDNlgCzaEew14lc6pe8/RUVHmvjNCIjPmE6OZGIPBg27T5ncMzr70r7xZJSbol dQYW7QA7xB44ZE0SBHMgxX5IHGSr9rQKfT/upMTUeRFMkmDhq8kAONlmTR40fTgm 6PjW0DtwxRapDm66TuQ4HML3PEh0rf/sphIBjXp95W4xNs1V+0g= =nc4T -----END PGP SIGNATURE----- --PU7k8Px3u5FH65Nq--