From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-mmc@vger.kernel.org
Cc: Stephen Boyd <sboyd@kernel.org>, Haibo Chen <haibo.chen@nxp.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Jesse T <mr.bossman075@gmail.com>
Subject: Re: [PATCH 1/5] clk: imx: imxrt1050: fix IMXRT1050_CLK_LCDIF_APB offsets
Date: Wed, 19 Oct 2022 00:36:00 +0200 [thread overview]
Message-ID: <ac5c75e0-2921-84ef-90c3-93e526358d7c@benettiengineering.com> (raw)
In-Reply-To: <20221017235602.86250-1-giulio.benetti@benettiengineering.com>
Hi Jesse,
On 18/10/22 01:55, Giulio Benetti wrote:
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> drivers/clk/imx/clk-imxrt1050.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c
> index 9539d35588ee..26108e9f7e67 100644
> --- a/drivers/clk/imx/clk-imxrt1050.c
> +++ b/drivers/clk/imx/clk-imxrt1050.c
> @@ -140,7 +140,7 @@ static int imxrt1050_clocks_probe(struct platform_device *pdev)
> hws[IMXRT1050_CLK_USDHC1] = imx_clk_hw_gate2("usdhc1", "usdhc1_podf", ccm_base + 0x80, 2);
> hws[IMXRT1050_CLK_USDHC2] = imx_clk_hw_gate2("usdhc2", "usdhc2_podf", ccm_base + 0x80, 4);
> hws[IMXRT1050_CLK_LPUART1] = imx_clk_hw_gate2("lpuart1", "lpuart_podf", ccm_base + 0x7c, 24);
> - hws[IMXRT1050_CLK_LCDIF_APB] = imx_clk_hw_gate2("lcdif", "lcdif_podf", ccm_base + 0x74, 10);
> + hws[IMXRT1050_CLK_LCDIF_APB] = imx_clk_hw_gate2("lcdif", "lcdif_podf", ccm_base + 0x70, 28);
> hws[IMXRT1050_CLK_DMA] = imx_clk_hw_gate("dma", "ipg", ccm_base + 0x7C, 6);
> hws[IMXRT1050_CLK_DMA_MUX] = imx_clk_hw_gate("dmamux0", "ipg", ccm_base + 0x7C, 7);
> imx_check_clk_hws(hws, IMXRT1050_CLK_END);
I've forgotten to add you in Cc, can you please take a look at it?
You've written the driver so you maybe can give me a feedback.
Same for patch 2/5
Thank you very much!
Best regards
--
Giulio Benetti
CEO/CTO@Benetti Engineering sas
prev parent reply other threads:[~2022-10-18 22:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 23:55 [PATCH 1/5] clk: imx: imxrt1050: fix IMXRT1050_CLK_LCDIF_APB offsets Giulio Benetti
2022-10-17 23:55 ` [PATCH 2/5] clk: imx: imxrt1050: add IMXRT1050_CLK_LCDIF_PIX clock gate Giulio Benetti
2022-10-17 23:56 ` [PATCH 3/5] mmc: sdhci-esdhc-imx: improve imxrt1050 data Giulio Benetti
2022-10-18 3:06 ` Bough Chen
2022-10-26 11:25 ` Ulf Hansson
2022-10-17 23:56 ` [PATCH 4/5] ARM: dts: imxrt1050: remove mmc max-frequency property Giulio Benetti
2022-10-18 3:01 ` Bough Chen
2022-10-18 17:29 ` Giulio Benetti
2022-10-17 23:56 ` [PATCH 5/5] ARM: dts: imx: prepend a 0 in the memory address to make it clear it's 32MB Giulio Benetti
2022-10-18 22:36 ` Giulio Benetti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac5c75e0-2921-84ef-90c3-93e526358d7c@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=haibo.chen@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mr.bossman075@gmail.com \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox