From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34CEE20E715 for ; Sat, 6 Sep 2025 18:34:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757183687; cv=none; b=OmVsx7Q8qnC72BNySPEXk10EyFuwVJRYcItjN8GXaeKuvvESaLgvP04fj3t4wfiRNxCrbxtaRKktMea2w2wZ87BiG64MIWm/yhWYoRASSkiiL8Zt5nj9xRJN2soRJAXoUoZe0hqey4s+NO2EWouwbFL4wHmRyWDHHpzFleNsj7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757183687; c=relaxed/simple; bh=Kkrp4Wv1v/M1RmFI3yiMxghk8W27Ki+YUXdi7Wn8+6s=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=BmP7oply1MbvWEYCFnUAyyUvvPslAB4GMbDwk2CmWBODQIf/vNZXzRyDviCpkBzj7nweb4sIl0kw3wT45kqjy85OK5ZKKJeOYMdnAt4ocJITVeOS9KQhxBPu6vnGAywSSoMx+iC0PILeReacJqy6+6vQPcquz0ldChuVpxfdIX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=D6bnonCn; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="D6bnonCn" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3e5190bca95so717679f8f.0 for ; Sat, 06 Sep 2025 11:34:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1757183684; x=1757788484; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=Qnerf/c2JmfLDaWdwE5/5ZjM5iHDZF/Oj+pWXPinn3Y=; b=D6bnonCns3tQkXf9YWAEBfLZlzrFSTJNavY5C/w5Pjr9eVuTcv8fOQ6+kLn5a+4ZYg O6REoQHaDE0LjIk9aUz3OKWqhnV78mQuw/oiAmarmEEXlTYs+qztIqAMRXnqBbt90iOV BPu5uuKqVIZNNfMt68Oht4bB0y5v3m56g85sZ8u/ihiC8F2+Dav766StrogA88SIsLBY wanow9tXrdEStFOYdnzZ35HPVOL5CyiYJk/PtQc+lCurSYFYAUuH82RpewweRWeUq/Fn uChyp0d8vW5bYHOXonpGl4gHrL+q4o4oNHmqbWJYN7wsSMeZ4SwRcBfr/nZvphtJyZ/m NBmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757183684; x=1757788484; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Qnerf/c2JmfLDaWdwE5/5ZjM5iHDZF/Oj+pWXPinn3Y=; b=Y17A/nqJ0QAbBLg5vbfEkBDYg9u+CZC6pEU9XPTmO8bMbhs/ktEFeOpYs4tnTVLnd5 uecHyvgwG9nIlvefxgumvtwXFo0WX4vCGOKVQMWWFkXQHYs5CYjljiQk8x+dgTOCf+Ua MRNaMk99ww9JI5dImBGIcPDtNu40lbb2V2eEToXb8IElXbmMjO/xEzZcBIXD4vC+e6sj 9XUj1MXiLEmqgnD0gH4dRKU9Th8MX9mrjzgSlGBOKNefjO1cOrDSKM9VJCVmezgRdROz +maGpT2rtHN54A5x3LZb0nznYyh7EqYGvkN4crfUXcg94txGYK2pYjRKkzAlSJZn/cVL LzGQ== X-Forwarded-Encrypted: i=1; AJvYcCUURqVCWt96Qpbe7q4FVOtDGWJUzL+DgYNFY3c8j9MY1lsvZAb0lyq6gd1LPl0l6izxGRPu8UmWiVQ=@vger.kernel.org X-Gm-Message-State: AOJu0YypwxpZo0A5CyCch6Bpkii3FJznOBveWaXJ1Tb7LWGyZ+EM76lM 1D4IXFdhPadatvCwWVF0LTcq2Qft7kh94v/Jzb8nI/5rFmsQY+U4ZEoWU3gruc6cTB4= X-Gm-Gg: ASbGncuBGuNPll+T6cYqDn6Ynjnvo+R+Y709BiRFy/7ltP4Sda1KJH1XlwRYVuOeJyN d14M0qimksLQmUGAmXUelnVGwj4r/LAJgdN/VJGPH4FuGcA8RlKhPJmd+zIwH/mGHj/4f9CnMkM ah61ueKY1uvfgR7Vz6UI6IwndKlAuy9oH3c0Lku+TAH2WW9FqFIQL0JiCWHtJ2JxsMBEpaGxNIX KoLy5hItIXgYHb0npmigiPzY3ilykkc8h04/9lr+Yf2bQS+rXC9X4qYNAcKSok1oZLl6H6B2Rrn vUw1EmtN2wYUp1Cz0sgmcVc4vRodtampp6A5QqGOM5VL1g1Zj1yPUev5DGEFTHX2DoNzjYZ590Y R8xEX3EQ/p25mt/bvQM3QX4KScRdYlBI= X-Google-Smtp-Source: AGHT+IGm0fa7QgRHF7b6Hmgbln8RYhjeirstMPYGWUhdpZoD+rT+0Ec/cadTeuSZa533WVVHZ2EoIA== X-Received: by 2002:a5d:5f88:0:b0:3a4:d6ed:8df8 with SMTP id ffacd0b85a97d-3e6440eef4emr1810219f8f.39.1757183684539; Sat, 06 Sep 2025 11:34:44 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.139]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3df4fd372c1sm13719925f8f.29.2025.09.06.11.34.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Sep 2025 11:34:44 -0700 (PDT) Message-ID: Date: Sat, 6 Sep 2025 21:34:42 +0300 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: claudiu beznea Subject: Re: [PATCH v3 05/32] clk: at91: clk-peripheral: switch to clk_parent_data To: Ryan.Wanner@microchip.com, mturquette@baylibre.com, sboyd@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com Cc: varshini.rajendran@microchip.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh@kernel.org References: <657143d460ed5f2f726413385895c0c80ddddef9.1752176711.git.Ryan.Wanner@microchip.com> Content-Language: en-US In-Reply-To: <657143d460ed5f2f726413385895c0c80ddddef9.1752176711.git.Ryan.Wanner@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Ryan, On 7/10/25 23:06, Ryan.Wanner@microchip.com wrote: > From: Claudiu Beznea > > Use struct clk_parent_data instead of parent_hw for peripheral clocks. I would prefer a description as provided for other conversions: Use struct clk_parent_data instead of struct parent_hw as this leads to less usage of __clk_get_hw() in SoC specific clock drivers and simpler conversion of existing SoC specific clock drivers from parent_names to modern clk_parent_data structures. > > Signed-off-by: Claudiu Beznea > [ryan.wanner@microchip.com: Add SAMA7D65 and SAM9X7 SoCs to the use the > structs.] > Signed-off-by: Ryan Wanner > --- > drivers/clk/at91/clk-peripheral.c | 16 ++++++++-------- > drivers/clk/at91/pmc.h | 4 ++-- > drivers/clk/at91/sam9x7.c | 2 +- > drivers/clk/at91/sama7d65.c | 2 +- > drivers/clk/at91/sama7g5.c | 2 +- > 5 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/clk/at91/clk-peripheral.c b/drivers/clk/at91/clk-peripheral.c > index c173a44c800a..ed97b3c0a66b 100644 > --- a/drivers/clk/at91/clk-peripheral.c > +++ b/drivers/clk/at91/clk-peripheral.c > @@ -97,7 +97,7 @@ static const struct clk_ops peripheral_ops = { > > struct clk_hw * __init > at91_clk_register_peripheral(struct regmap *regmap, const char *name, > - const char *parent_name, struct clk_hw *parent_hw, > + const char *parent_name, struct clk_parent_data *parent_data, > u32 id) > { > struct clk_peripheral *periph; > @@ -105,7 +105,7 @@ at91_clk_register_peripheral(struct regmap *regmap, const char *name, > struct clk_hw *hw; > int ret; > > - if (!name || !(parent_name || parent_hw) || id > PERIPHERAL_ID_MAX) > + if (!name || !(parent_name || parent_data) || id > PERIPHERAL_ID_MAX) > return ERR_PTR(-EINVAL); > > periph = kzalloc(sizeof(*periph), GFP_KERNEL); > @@ -114,8 +114,8 @@ at91_clk_register_peripheral(struct regmap *regmap, const char *name, > > init.name = name; > init.ops = &peripheral_ops; > - if (parent_hw) > - init.parent_hws = (const struct clk_hw **)&parent_hw; > + if (parent_data) > + init.parent_data = (const struct clk_parent_data *)parent_data; > else > init.parent_names = &parent_name; > init.num_parents = 1; > @@ -448,7 +448,7 @@ struct clk_hw * __init > at91_clk_register_sam9x5_peripheral(struct regmap *regmap, spinlock_t *lock, > const struct clk_pcr_layout *layout, > const char *name, const char *parent_name, > - struct clk_hw *parent_hw, > + struct clk_parent_data *parent_data, > u32 id, const struct clk_range *range, > int chg_pid, unsigned long flags) > { > @@ -457,7 +457,7 @@ at91_clk_register_sam9x5_peripheral(struct regmap *regmap, spinlock_t *lock, > struct clk_hw *hw; > int ret; > > - if (!name || !(parent_name || parent_hw)) > + if (!name || !(parent_name || parent_data)) > return ERR_PTR(-EINVAL); > > periph = kzalloc(sizeof(*periph), GFP_KERNEL); > @@ -465,8 +465,8 @@ at91_clk_register_sam9x5_peripheral(struct regmap *regmap, spinlock_t *lock, > return ERR_PTR(-ENOMEM); > > init.name = name; > - if (parent_hw) > - init.parent_hws = (const struct clk_hw **)&parent_hw; > + if (parent_data) > + init.parent_data = (const struct clk_parent_data *)parent_data; > else > init.parent_names = &parent_name; > init.num_parents = 1; > diff --git a/drivers/clk/at91/pmc.h b/drivers/clk/at91/pmc.h > index b43f6652417f..b6f2aca1e1fd 100644 > --- a/drivers/clk/at91/pmc.h > +++ b/drivers/clk/at91/pmc.h > @@ -226,13 +226,13 @@ at91_clk_sama7g5_register_master(struct regmap *regmap, > > struct clk_hw * __init > at91_clk_register_peripheral(struct regmap *regmap, const char *name, > - const char *parent_name, struct clk_hw *parent_hw, > + const char *parent_name, struct clk_parent_data *parent_data, > u32 id); > struct clk_hw * __init > at91_clk_register_sam9x5_peripheral(struct regmap *regmap, spinlock_t *lock, > const struct clk_pcr_layout *layout, > const char *name, const char *parent_name, > - struct clk_hw *parent_hw, > + struct clk_parent_data *parent_data, > u32 id, const struct clk_range *range, > int chg_pid, unsigned long flags); > > diff --git a/drivers/clk/at91/sam9x7.c b/drivers/clk/at91/sam9x7.c > index edd5fd3a1fa5..d7dc5f381ebe 100644 > --- a/drivers/clk/at91/sam9x7.c > +++ b/drivers/clk/at91/sam9x7.c > @@ -922,7 +922,7 @@ static void __init sam9x7_pmc_setup(struct device_node *np) > hw = at91_clk_register_sam9x5_peripheral(regmap, &pmc_pcr_lock, > &sam9x7_pcr_layout, > sam9x7_periphck[i].n, > - NULL, sam9x7_pmc->chws[PMC_MCK], > + NULL, &AT91_CLK_PD_HW(sam9x7_pmc->chws[PMC_MCK]), > sam9x7_periphck[i].id, > &range, INT_MIN, > sam9x7_periphck[i].f); > diff --git a/drivers/clk/at91/sama7d65.c b/drivers/clk/at91/sama7d65.c > index 17725c175d3b..372e530f4107 100644 > --- a/drivers/clk/at91/sama7d65.c > +++ b/drivers/clk/at91/sama7d65.c > @@ -1306,7 +1306,7 @@ static void __init sama7d65_pmc_setup(struct device_node *np) > &sama7d65_pcr_layout, > sama7d65_periphck[i].n, > NULL, > - sama7d65_mckx[sama7d65_periphck[i].p].hw, > + &AT91_CLK_PD_HW(sama7d65_mckx[sama7d65_periphck[i].p].hw), > sama7d65_periphck[i].id, > &sama7d65_periphck[i].r, > sama7d65_periphck[i].chgp ? 0 : > diff --git a/drivers/clk/at91/sama7g5.c b/drivers/clk/at91/sama7g5.c > index 733e4fc6a515..f28fe419ae5e 100644 > --- a/drivers/clk/at91/sama7g5.c > +++ b/drivers/clk/at91/sama7g5.c > @@ -1181,7 +1181,7 @@ static void __init sama7g5_pmc_setup(struct device_node *np) > &sama7g5_pcr_layout, > sama7g5_periphck[i].n, > NULL, > - sama7g5_mckx[sama7g5_periphck[i].p].hw, > + &AT91_CLK_PD_HW(sama7g5_mckx[sama7g5_periphck[i].p].hw), > sama7g5_periphck[i].id, > &sama7g5_periphck[i].r, > sama7g5_periphck[i].chgp ? 0 :