From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1636E3DA7E0; Fri, 8 May 2026 12:12:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778242365; cv=none; b=JP1h/GepETdlelhvZOLPKAvXNgG0EwKRfYEBZljf3HrrBCRpj1icfgtA6S0hBhmaIRuyL9GzIEaly2Al6h+EEc1k6ALTvFOvuEGyR61oLwZVgTDIxICT5dkGiznBnFNMgEqm4eOIJMmQCh1r0BTffoFSde/Fcqi8Y8vexdL2M6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778242365; c=relaxed/simple; bh=8wQJi7Z/6oiDDjXY4PUnzHS4rctTBv4o5UzgnqFWSBM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u3N+W646pcdmZm0BnxEoRSKAMDx6y6VvbcnOs1lpszqIaVtsy8wa7lxNRdk6C5sVEpV0OezQ5oQJ7sRWdXC0HYAQZiFIaDCpt9vEIDRTx+RxsKJbi2Xfm120PxnkdxNj1nmElZ+0leBhsRDNnmzD6+F1yDZMcnf2RsMlLC9IJpo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=igUGQkq1; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=GdGtGgnT; arc=none smtp.client-ip=80.241.56.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="igUGQkq1"; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="GdGtGgnT" Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4gBp0T75jZz9tqy; Fri, 8 May 2026 14:12:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1778242362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tSZZrgOpw7cfjEQSWr1n0bcdUbY4FHu0Sk24TvUJj0A=; b=igUGQkq1Qgum4i5uly3XIvnas34fiFJEzCz1YSgK3g4judFZN28XucXGKTb0C5y7RSyf+G /jubVnTcJ/wLe9D6yOFcPHAXC1evYIt9luCy/g3IrsCjDSjkyiaZse9R2xI4dgVDuTS5RK T8qc5mVNDt+v7VCGALOmkwEt2QJNmnfzzyhND34pZK5IXfaFc+t5nfVqx/z4Zu7zIdYQx5 BpG4SEFjCACMt1JpsomqcATItCbCwSDNPczkQ5f4da70920RHoKKKiOovGKdW4HYav/UMN 9VFn+z5oNS0UL0Bv0cyYqc8YzNXTCrXwKYysz4fcRPtpd9KX017K4RlLmpEzIQ== Authentication-Results: outgoing_mbo_mout; dkim=pass header.d=mailbox.org header.s=mail20150812 header.b=GdGtGgnT; spf=pass (outgoing_mbo_mout: domain of marek.vasut@mailbox.org designates 2001:67c:2050:b231:465::202 as permitted sender) smtp.mailfrom=marek.vasut@mailbox.org Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1778242360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tSZZrgOpw7cfjEQSWr1n0bcdUbY4FHu0Sk24TvUJj0A=; b=GdGtGgnTJkUqospHm6XSwRHJEXRKCDhqIib8UOwm27/2aixmEcsvbroWxpOKQScz6O+LH6 +2D9KVeXOU70h+toSAPyI7rZwbUlzsrZBXpg8/qmW2hJwAlarlYcX1YWBjts43zXYrB82v Ds6Up4Bmm4XXFYU+NbQjHS5nW0ZVQ6rK3+ImRdnMamp9ktBzRu/u8+xouxBzVaUx0XNNfW DgX+OAW2u3qRpLeWW/XHKf2Ir5tSOKjg/Xk6FqF1dS+EmVY2lb0SJ9m3LqOSMYdVcmpXCt sZXsa69OB0jIvn0N5I/zcDdYU57pj8lBCkcr6LGEK36geCH9JqvJLZJkoVtqDQ== Date: Fri, 8 May 2026 14:12:31 +0200 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH/RFC 10/14] dt-bindings: power: Document Renesas R-Car X5H Module Controller To: Geert Uytterhoeven Cc: Geert Uytterhoeven , Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm , Saravana Kannan , Michael Turquette , Stephen Boyd , Philipp Zabel , Ulf Hansson , "Rafael J . Wysocki" , Kevin Hilman , Florian Fainelli , Wolfram Sang , Marek Vasut , Kuninori Morimoto , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <053c312d07445517d8f9c84bfe3cc8fb72d4cd9a.1776793163.git.geert+renesas@glider.be> <39879eae-39dd-4b4d-9469-d238cd7d120a@mailbox.org> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MBO-RS-META: zu4rz6kobcocxfr7aqatpn5ssy85cf67 X-MBO-RS-ID: f4fb5f452a7f67cf7c3 X-Rspamd-Queue-Id: 4gBp0T75jZz9tqy On 5/8/26 9:47 AM, Geert Uytterhoeven wrote: Hello Geert, > On Thu, 7 May 2026 at 23:53, Marek Vasut wrote: >> On 4/21/26 8:11 PM, Geert Uytterhoeven wrote: >>> + '#power-domain-cells': >>> + description: | >>> + - The first power domain specifier cell must be either the Module >>> + Power Domain Gating (MPDG) register index (0x00-0x3f) from the >>> + datasheet, or a Power Domain number, as defined in >>> + , >>> + - The second power domain specifier cell must be the module number >>> + (0x00-0xff), composed of the Module System Reset (MSRES) register index >>> + in the high nibble, and the Module Reset Destination bitfield index in >>> + the low nibble. >>> + const: 2 >>> + >>> + '#reset-cells': >>> + description: >>> + The single reset specifier cell must be the module number (0x00-0xff). >>> + const: 1 >> Just one more question -- the power-domain-cells second cell and >> reset-cells are always going to be identical values, correct ? If so, it > > Yes they are. > >> would be nice to keep the description: aligned, and maybe even indicate >> in the description that those two values have to be the same. > > I thought that was obvious (but apparently it is not)? The descriptions > are identical, except for the latter not explaining again what a module > number is composed of... Please do spell it out in the document, this is a complicated topic and every little bit of extra clarity helps. Thank you ! -- Best regards, Marek Vasut