Re: [PATCH RFC 3/4] clk: qcom: tcsrcc-glymur: Migrate tcsr_pcie_N_clkref_en to clk_ref common helper

Bjorn Andersson
2026-04-09T13:19:46Z

On Wed, Apr 01, 2026 at 09:47:38PM -0700, Qiang Yu wrote:
> On Wed, Apr 01, 2026 at 10:05:12PM +0530, Taniya Das wrote:
> > On 4/1/2026 12:05 PM, Qiang Yu wrote:
> > > diff --git a/drivers/clk/qcom/tcsrcc-glymur.c b/drivers/clk/qcom/tcsrcc-glymur.c
[..]
> > > +static const char * const tcsr_pcie_4_regulators[] = {
> > > + "vdda-refgen-0p9",
> > > + "vdda-refgen-1p2",
> > > + "vdda-qreftx1-0p9",
> > > + "vdda-qrefrpt0-0p9",
> > > + "vdda-qrefrpt1-0p9",
> > > + "vdda-qrefrpt2-0p9",
> > > + "vdda-qrefrx2-0p9",
> > > +};
> > > +
> >
> > TCSR clock refs are just not for PCIe alone, they would have supplies
> > for all the ref clocks. These supplies can also be shared across other
> > clock refs. I think it is not the correct way to handle the supplies, as
> > TCSR does not have the complete supplies map.
> >
> We have complete supplies map. You can get it on ipcatlog. Here is example
> for other instances eg USB and EDP:
> - Glymur (eDP): CXO PAD -> TX0 -> RPT0 -> RX0 -> eDP
> - Glymur (USB4_2): CXO PAD -> TX0 -> RPT0 -> RPT1 -> RX1 -> USB4_2
> - Glymur (USB3): CXO PAD -> TX0 -> RPT3 -> RPT4 -> RX4 -> USB3_SS3
>
> I only add supplies for PCIe in this series because USB and EDP vote these
> LDO in their PHY driver. They can remove them in PHY dts node and add same
> regulator list here.
>

The regulators are reference counted. Can't we add the USB and eDP
handling here as well now, and then after they are voted here we remove
them from the PHY?

Regards,
Bjorn

> - Qiang Yu
> >
> > > +static const struct qcom_clk_ref_desc tcsr_cc_glymur_clk_descs[] = {
> > > + [TCSR_EDP_CLKREF_EN] = {
> > > + .name = "tcsr_edp_clkref_en",
> > > + .offset = 0x60,
> > > },
> > > -};
> > >
> >
> >
> > --
> > Thanks,
> > Taniya Das
> >