From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8807227511B; Tue, 15 Jul 2025 08:35:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752568513; cv=none; b=dw0ZeV4ClWPgfC762YQJLBLbkOGG/Kgu7RMjdh4Hrv/b7dK5PLUZJ3oCr/BCtttwTAGmqeLcSUektQWvgSjpPJtEu/TvzNQ1ChIXyC7fV6xS60WvwOJw8rNMga2ZKblUGlLLXP9JcvZm0/9mcEDbQmYlxPGTv4jK9ehkITvWrNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752568513; c=relaxed/simple; bh=RfYBnV1ozw7/0znDlV6t07ddJF9wwhWNft6BOgQgo/g=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=CMtCrqCrEeNMC1gYxn5JKSUD3f6YAS28+4rbtmjKhbAt6ipamu34jXBRmGTTotoObZqxUPDPvnq0yMe43YmXQisRqdf4EOsDuRn3caumTfbIIBMzOnME7biUVEs6253VZHIUD4ZDJZ6oxlB2aISXpENhUgn7bU5nveSEGXDyws0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=6Kz8zsOs; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="6Kz8zsOs" Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56F7msBA003670; Tue, 15 Jul 2025 10:34:52 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= FBjN96Vc9/YNSk2Vr1T4bmQLG/82VFC8eOZQTen3I6w=; b=6Kz8zsOss7e1leYL 0yWjGq2eCmjxyopEMUGq5nLk/lVCP/5UuwaEGdk9eHB1lVOA14Y5v8e7v2604bDj 9dOg4+XxUcy4mGdA849Vq7OwKKFV7ZLQHQTB+p/eKdHt2M+5IPYOA4d4i+X1PUGZ XEy/fzBIOvT/BlICLrxEkHQXkHWIGMcf1b4i2aDBkhx0i7rknVKNeiGM0syvgazC Im6F3srR/14ZUbNY+qlLPq/qN4Lln86FmW4SZslYjcNMM8HxZdKK9MTvAQEsn88e prIiVBPYZ9tXi8+eZrm+cwnqSWVVmpKf//bprensYcG5yp7g/iwgnuWZAeO20PrH uNtETQ== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 47ud4mmg2r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Jul 2025 10:34:52 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id A93E84002D; Tue, 15 Jul 2025 10:33:28 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id C23DEB63555; Tue, 15 Jul 2025 10:32:10 +0200 (CEST) Received: from [10.48.86.185] (10.48.86.185) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 15 Jul 2025 10:32:09 +0200 Message-ID: Date: Tue, 15 Jul 2025 10:32:09 +0200 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/16] arm64: dts: st: add LPDDR channel to stm32mp257f-dk board To: Rob Herring CC: Will Deacon , Mark Rutland , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Philipp Zabel , Jonathan Corbet , Gatien Chevallier , Michael Turquette , Stephen Boyd , Gabriel Fernandez , Krzysztof Kozlowski , Le Goffic , , , , , , , References: <20250711-ddrperfm-upstream-v2-0-cdece720348f@foss.st.com> <20250711-ddrperfm-upstream-v2-6-cdece720348f@foss.st.com> <20250715032020.GB4144523-robh@kernel.org> Content-Language: en-US From: Clement LE GOFFIC In-Reply-To: <20250715032020.GB4144523-robh@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-14_03,2025-07-14_01,2025-03-28_01 Hi Rob, Thanks for the review ! On 7/15/25 05:20, Rob Herring wrote: > On Fri, Jul 11, 2025 at 04:48:58PM +0200, Clément Le Goffic wrote: >> Add 32bits LPDDR4 channel to the stm32mp257f-dk board. >> >> Signed-off-by: Clément Le Goffic >> --- >> arch/arm64/boot/dts/st/stm32mp257f-dk.dts | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/st/stm32mp257f-dk.dts b/arch/arm64/boot/dts/st/stm32mp257f-dk.dts >> index a278a1e3ce03..a97b41f14ecc 100644 >> --- a/arch/arm64/boot/dts/st/stm32mp257f-dk.dts >> +++ b/arch/arm64/boot/dts/st/stm32mp257f-dk.dts >> @@ -54,6 +54,13 @@ led-blue { >> }; >> }; >> >> + lpddr_channel: lpddr4-channel { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + compatible = "jedec,lpddr4-channel"; > > Not tested because this doesn't match the binding. Hmm, I've tested with make dtbs_check and dt_binding_check and it didn't complain on my side. What I have miss ? > >> + io-width = <32>; >> + }; > > What would multiple channels look like? I think this needs some work. > Like it should perhaps be within the memory node. It's a lot to just say > 32-bit LPDDR4 x1. I guess something like two channels node following each other in the DT. It can be in the memory node I don't know what are the stakes here. I was inspired by the lpddr node here: arch/arm/boot/dts/samsung/exynos5422-odroid-core.dtsi:336 Best regard, Clément