Re: [PATCH v2 7/7] clk: qcom: Add support for global clock controller on Hawi

[Mike Tipton <mike.tipton@oss.qualcomm.com>]

On Thu, Apr 09, 2026 at 01:51:41PM -0700, Vivek Aknurwar wrote:
> Add support for the global clock controller (GCC) on the
> Qualcomm Hawi SoC.
> 
> Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Vivek Aknurwar <vivek.aknurwar@oss.qualcomm.com>
> ---
>  drivers/clk/qcom/Kconfig    |    9 +
>  drivers/clk/qcom/Makefile   |    1 +
>  drivers/clk/qcom/gcc-hawi.c | 3657 +++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 3667 insertions(+)

[..]

> +
> +static u32 gcc_hawi_critical_cbcrs[] = {

This should be const now since qcom_cc_driver_data::clk_cbcrs was
recently made const.

> +	0xa0004, /* GCC_CAM_BIST_MCLK_AHB_CLK */
> +	0x26004, /* GCC_CAMERA_AHB_CLK */
> +	0x26028, /* GCC_CAMERA_RSC_CORE_CLK */
> +	0x26024, /* GCC_CAMERA_XO_CLK */
> +	0x9f004, /* GCC_EVA_AHB_CLK */
> +	0x9f018, /* GCC_EVA_XO_CLK */
> +	0x71004, /* GCC_GPU_CFG_AHB_CLK */
> +	0x7101c, /* GCC_GPU_RSC_CORE_CLK */
> +	0x67084, /* GCC_PCIE_1_RSC_CORE_CLK */
> +	0x43014, /* GCC_PCIE_LINK_XO_CLK */
> +	0x6b088, /* GCC_PCIE_RSC_CORE_CLK */
> +	0x52010, /* GCC_PCIE_RSCC_CFG_AHB_CLK */
> +	0x52010, /* GCC_PCIE_RSCC_XO_CLK */
> +	0x32004, /* GCC_VIDEO_AHB_CLK */
> +	0x32028, /* GCC_VIDEO_XO_CLK */
> +};

[..]

> +
> +static struct qcom_cc_driver_data gcc_hawi_driver_data = {

This should be const now since qcom_cc_desc::driver_data was recently
made const.

> +	.clk_cbcrs = gcc_hawi_critical_cbcrs,
> +	.num_clk_cbcrs = ARRAY_SIZE(gcc_hawi_critical_cbcrs),
> +	.dfs_rcgs = gcc_hawi_dfs_clocks,
> +	.num_dfs_rcgs = ARRAY_SIZE(gcc_hawi_dfs_clocks),
> +	.clk_regs_configure = clk_hawi_regs_configure,
> +};
> +
> +static const struct qcom_cc_desc gcc_hawi_desc = {
> +	.config = &gcc_hawi_regmap_config,
> +	.clks = gcc_hawi_clocks,
> +	.num_clks = ARRAY_SIZE(gcc_hawi_clocks),
> +	.resets = gcc_hawi_resets,
> +	.num_resets = ARRAY_SIZE(gcc_hawi_resets),
> +	.gdscs = gcc_hawi_gdscs,
> +	.num_gdscs = ARRAY_SIZE(gcc_hawi_gdscs),
> +	.use_rpm = true,
> +	.driver_data = &gcc_hawi_driver_data,
> +};
> +

Thanks,
Mike