Re: [PATCH 3/4] dt-bindings: clock: add doc for Siflower sf21-topcrm

[Yao Zi <me@ziyao.cc>]

On Mon, May 18, 2026 at 08:12:14PM +0800, Chuanhong Guo wrote:
> Hi!
> 
> On Mon, May 18, 2026 at 4:50 AM Conor Dooley <conor@kernel.org> wrote:

...

> > > +examples:
> > > +  - |
> > > +    #include <dt-bindings/clock/siflower,sf21-topcrm.h>

Though it isn't a big problem, the include is unnecessary, either, since
you don't make use of any constants from the binding header in the
example.

> > > +    / {
> >
> > Replace this / with "soc".
> 
> Will do so in v2.
> 
> >
> > > +        #address-cells = <1>;
> > > +        #size-cells = <1>;
> > > +
> > > +        xin25m: clock-25000000 {
> > > +            compatible = "fixed-clock";
> > > +            #clock-cells = <0>;
> > > +            clock-frequency = <25000000>;
> > > +        };
> >
> > Delete this node, it's not needed in the example. The tooling will fill
> > it in.
> 
> Oh, I didn't know that. I'll drop it in v2.
> 
> >
> > Also, please test your bindings since this doesn't pass.
> >
> > pw-bot: changes-requested
> 
> It's failing on the example as root node missing "model" and "compatible".
> and it will be fixed after changing "/" to "soc".
> I'll remember to run the full dt check instead of using DT_SCHEMA_FILES
> for my single file next time.

Alternatively you could choose to drop the outer node and keep the
clock-controller node only.

> 
> -- 
> Regards,
> Chuanhong Guo

Best regards,
Yao Zi