From: Brian Masney <bmasney@redhat.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Saravana Kannan <saravanak@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Bjorn Andersson <andersson@kernel.org>,
Hans de Goede <johannes.goede@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Jens Glathe <jens.glathe@oldschoolsolutions.biz>
Subject: Re: [PATCH v2 2/5] clk: qcom: common: introduce qcom_cc_sync_state()
Date: Thu, 25 Jun 2026 09:25:20 -0400 [thread overview]
Message-ID: <aj0sQLsPAwZPUR-K@redhat.com> (raw)
In-Reply-To: <b790c13d-0a4e-48c9-b8e1-743481c5e6b6@oss.qualcomm.com>
On Thu, Jun 25, 2026 at 02:19:21PM +0200, Konrad Dybcio wrote:
> On 6/25/26 1:38 PM, Brian Masney wrote:
> > My next version of this series that I haven't posted yet allows chaining
> > the sync_state callbacks at the driver core level. It doesn't require
> > any of the QC clk driver changes, and will allow us to play nicely with
> > the pmdomain subsystem, and any others the move to sync_state in the
> > future.
> >
> > I think I see the confusion between us the last few rounds of review. In
> > this series, I added qcom_cc_sync_state() and converted 6 drivers over to
> > use it. (I excluded clk-cbf-8996.c since it is separate.) Only the 6
> > drivers today that called icc_sync_state() now call qcom_cc_sync_state() ->
> > icc_sync_state(). So from my vantage point it is the same overall
> > functionality.
> >
> > I didn't look at this from the perspective of qcom_cc_sync_state() would
> > be common infrastructure, and a newly added driver in the future that may
> > not interact with the ICC framework may use this. Is this correct?
>
> Aaah right, my mistake. I assumed that adding that binding
> qcom_cc_sync_state to all qcom clock drivers was the next step.
OK cool... I'm glad we figured this out. Email can be tough sometime! :)
Brian
next prev parent reply other threads:[~2026-06-25 13:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 21:09 [PATCH v2 0/5] clk: implement sync_state support Brian Masney
2026-06-16 21:09 ` [PATCH v2 1/5] clk: introduce stub clk_sync_state() Brian Masney
2026-06-16 21:09 ` [PATCH v2 2/5] clk: qcom: common: introduce qcom_cc_sync_state() Brian Masney
2026-06-25 9:44 ` Konrad Dybcio
2026-06-25 11:38 ` Brian Masney
2026-06-25 12:19 ` Konrad Dybcio
2026-06-25 13:25 ` Brian Masney [this message]
2026-06-16 21:09 ` [PATCH v2 3/5] clk: qcom: convert from icc_sync_state() to qcom_cc_sync_state() Brian Masney
2026-06-25 9:44 ` Konrad Dybcio
2026-06-16 21:09 ` [PATCH v2 4/5] clk: qcom: cbf-8996: add clk_sync_state() call Brian Masney
2026-06-25 9:38 ` Konrad Dybcio
2026-06-16 21:09 ` [PATCH v2 5/5] clk: implement sync_state support Brian Masney
2026-06-17 9:25 ` [PATCH " dongxuyang
2026-06-17 14:24 ` [PATCH v2 " Ulf Hansson
2026-06-17 15:02 ` Brian Masney
2026-06-17 15:29 ` Ulf Hansson
2026-06-18 21:12 ` Brian Masney
2026-06-22 10:35 ` Konrad Dybcio
2026-06-22 14:45 ` Brian Masney
2026-06-17 8:10 ` [PATCH v2 0/5] " Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aj0sQLsPAwZPUR-K@redhat.com \
--to=bmasney@redhat.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jens.glathe@oldschoolsolutions.biz \
--cc=johannes.goede@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=saravanak@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox