From: Brian Masney <bmasney@redhat.com>
To: David Carlier <devnexen@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Xukai Wang <kingxukai@zohomail.com>,
Conor Dooley <conor.dooley@microchip.com>,
Troy Mitchell <TroyMitchell988@gmail.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: canaan: Clear rate fields before reprogramming dividers
Date: Thu, 18 Jun 2026 12:55:15 -0400 [thread overview]
Message-ID: <ajQi85kD1jVeqrQW@redhat.com> (raw)
In-Reply-To: <20260618045030.12581-1-devnexen@gmail.com>
On Thu, Jun 18, 2026 at 05:50:30AM +0100, David Carlier wrote:
> The rate set_rate helpers perform a read-modify-write on the divider
> and multiplier registers but only ever OR the new value in, without
> first masking off the existing field. The first write after reset lands
> on a zeroed field and looks correct, but any later reprogramming leaves
> the old bits set: the field becomes the bitwise OR of the previous and
> new encodings, corrupting the divider or multiplier.
>
> Mask off each field before writing the new value so reprogramming a
> clock to a different rate produces the intended register contents.
>
> Fixes: a7b7c7c6c016 ("clk: canaan: Add clock driver for Canaan K230")
> Signed-off-by: David Carlier <devnexen@gmail.com>
Reviewed-by: Brian Masney <bmasney@redhat.com>
prev parent reply other threads:[~2026-06-18 16:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 4:50 [PATCH] clk: canaan: Clear rate fields before reprogramming dividers David Carlier
2026-06-18 8:18 ` Xukai Wang
2026-06-18 16:55 ` Brian Masney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajQi85kD1jVeqrQW@redhat.com \
--to=bmasney@redhat.com \
--cc=TroyMitchell988@gmail.com \
--cc=conor.dooley@microchip.com \
--cc=devnexen@gmail.com \
--cc=kingxukai@zohomail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox