From: Brian Masney <bmasney@redhat.com>
To: Colin Foster <colin.foster@in-advantage.com>
Cc: "Datta, Shubhrajyoti" <shubhraj@amd.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
Michal Simek <michal.simek@amd.com>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Subject: Re: [PATCH v1 0/3] clock-wizard fixups
Date: Tue, 23 Jun 2026 09:40:42 -0400 [thread overview]
Message-ID: <ajqM2m1d7-YnI5rZ@redhat.com> (raw)
In-Reply-To: <ajqEMXmTnpOA7tVs@colin-ia-desktop>
Hi Colin,
On Tue, Jun 23, 2026 at 08:03:45AM -0500, Colin Foster wrote:
> On Thu, May 07, 2026 at 05:29:41PM +0530, Datta, Shubhrajyoti wrote:
> > [You don't often get email from shubhraj@amd.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> >
> > On 5/7/2026 1:35 AM, Colin Foster wrote:
> > > The clock-wizard driver had a hard-coded 20KHz minimum accuracy. This
> > > led to out-of-tree drivers silently failing to set clock rates instead
> > > of dealing with the best-effort.
> > >
> > > Remove this 20KHz restriction to match the Versal clock wizard driver.
> > > There also was a bug in the difference calculation that is addressed in
> > > the first patch.
> > >
> > > The second patch optimizes the search if an exact match is found.
> > >
> > > The third removes the restriction.
> >
> > LGTM
> >
> >
> > Reviewed-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
>
> Are there any actions required from me? Hoping this doesn't slip through
> the cracks.
No there is nothing else that you need to do. Stephen hasn't made the
clk pull to Linus yet. He should assemble it this week.
For the series:
Reviewed-by: Brian Masney <bmasney@redhat.com>
prev parent reply other threads:[~2026-06-23 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 20:05 [PATCH v1 0/3] clock-wizard fixups Colin Foster
2026-05-06 20:05 ` [PATCH v1 1/3] clk: clocking-wizard: fix clock difference detection Colin Foster
2026-05-06 20:05 ` [PATCH v1 2/3] clk: clocking-wizard: optimize clock search Colin Foster
2026-05-06 20:05 ` [PATCH v1 3/3] clk: clocking-wizard: remove 20kHz restriction Colin Foster
2026-05-07 11:59 ` [PATCH v1 0/3] clock-wizard fixups Datta, Shubhrajyoti
2026-06-23 13:03 ` Colin Foster
2026-06-23 13:40 ` Brian Masney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajqM2m1d7-YnI5rZ@redhat.com \
--to=bmasney@redhat.com \
--cc=colin.foster@in-advantage.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=shubhraj@amd.com \
--cc=shubhrajyoti.datta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox