Linux clock framework development
 help / color / mirror / Atom feed
From: Drew Fustini <fustini@kernel.org>
To: Brian Masney <bmasney@redhat.com>
Cc: Rosen Penev <rosenp@gmail.com>,
	linux-clk@vger.kernel.org,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:CLANG/LLVM BUILD SUPPORT:Keyword:b(?i:clang|llvm)b"
	<llvm@lists.linux.dev>
Subject: Re: [PATCH] clk: thead: allow COMPILE_TEST builds
Date: Mon, 6 Jul 2026 13:32:41 -0700	[thread overview]
Message-ID: <akwQ6Tg2KR9wWXfx@x1> (raw)
In-Reply-To: <akvj9WXsHJw5-n2p@redhat.com>

On Mon, Jul 06, 2026 at 01:20:53PM -0400, Brian Masney wrote:
> Hi Rosen,
> 
> On Sun, Jun 28, 2026 at 08:28:14PM -0700, Rosen Penev wrote:
> > CLK_THEAD_TH1520_AP already allows COMPILE_TEST, but the parent clock
> > Makefile only descends into drivers/clk/thead for ARCH_THEAD.  Use the
> > TH1520 AP clock symbol for the directory gate instead.
> > 
> > This lets the driver build on other 64-bit architectures selected for
> > compile testing without selecting the T-HEAD platform.
> > 
> > Tested with:
> > make LLVM=1 ARCH=loongarch drivers/clk/thead/
> > 
> > Assisted-by: Codex:GPT-5.5
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > ---
> >  drivers/clk/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
> > index 68145ad91035..d651e4ed3462 100644
> > --- a/drivers/clk/Makefile
> > +++ b/drivers/clk/Makefile
> > @@ -157,7 +157,7 @@ obj-$(CONFIG_ARCH_SUNXI)		+= sunxi/
> >  obj-y					+= sunxi-ng/
> >  obj-$(CONFIG_CLK_TEGRA)			+= tegra/
> >  obj-y					+= tenstorrent/
> > -obj-$(CONFIG_ARCH_THEAD)		+= thead/
> > +obj-$(CONFIG_CLK_THEAD_TH1520_AP)	+= thead/
> 
> Right now, CLK_THEAD_TH1520_AP is the only Kconfig defined in the thead
> subdirectory. What about when/if someone adds a second Kconfig, and
> that's the only one that's enabled?
> 
> Would it be better to have this as obj-y?
> 
> Brian

I think obj-y would make sense. AP is just one of several TH1520 SoC
subsystems with a clock controller. Support may some day be added for
the other controllers.

Thanks,
Drew

      reply	other threads:[~2026-07-06 20:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29  3:28 [PATCH] clk: thead: allow COMPILE_TEST builds Rosen Penev
2026-07-06 17:20 ` Brian Masney
2026-07-06 20:32   ` Drew Fustini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akwQ6Tg2KR9wWXfx@x1 \
    --to=fustini@kernel.org \
    --cc=bmasney@redhat.com \
    --cc=justinstitt@google.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=morbo@google.com \
    --cc=mturquette@baylibre.com \
    --cc=nathan@kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=rosenp@gmail.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox