From: Brian Masney <bmasney@redhat.com>
To: "Duje Mihanović" <dujemihanovic32@gmail.com>
Cc: linux-clk@vger.kernel.org, Rosen Penev <rosenp@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Marvell PXA1908 SOC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:CLANG/LLVM BUILD SUPPORT:Keyword:b(?i:clang|llvm)b"
<llvm@lists.linux.dev>
Subject: Re: [PATCH] clk: mmp: allow COMPILE_TEST builds
Date: Mon, 20 Jul 2026 16:08:12 -0400 [thread overview]
Message-ID: <al6ALM2eIWots1Zr@redhat.com> (raw)
In-Reply-To: <YBsaITDCQyaUWFnnWTe4Fw@gmail.com>
Hi Duje,
On Mon, Jul 20, 2026 at 04:46:40PM +0200, Duje Mihanović wrote:
> On Sunday, 19 July 2026 23:43:49 Central European Summer Time Rosen Penev
> wrote:
>
> [...]
>
> > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
> > index 4b2c089f46a1..8383f9f1da51 100644
> > --- a/drivers/clk/Makefile
> > +++ b/drivers/clk/Makefile
> > @@ -130,7 +130,7 @@ obj-y +=
> mediatek/
> > obj-$(CONFIG_ARCH_MESON) += meson/
> > obj-y += microchip/
> > ifeq ($(CONFIG_COMMON_CLK), y)
> > -obj-$(CONFIG_ARCH_MMP) += mmp/
> > +obj-$(CONFIG_COMMON_CLK_MMP) += mmp/
>
> Could it be possible to select mmp unconditionally, like most of the other
> subtrees are? AFAICT, that would also require creating new Kconfig symbols for
> the PXA168, PXA910 and PXA1928 clocks, but I suspect it may be the more proper
> choice in the long term.
Just by sheer numbers, the CONFIG_COMMON_CLK_XXX approach is the most
common use case right now.
x1:~/src/linux/linux-next ((next-20260720) %)$ grep "CONFIG_COMMON_CLK" drivers/clk/Makefile | grep "+=" | wc -l
68
x1:~/src/linux/linux-next ((next-20260720) %)$ grep "obj-y" drivers/clk/Makefile | wc -l
25
I have no strong opinions about this either way other than to drive
consistency across various drivers as much as possible.
Currently the mmp directory currently only has COMMON_CLK_PXA1908
defined. When the other PXA* drivers are introduced, will there be a
CONFIG_COMMON_CLK_MMA_COMMON that all of the drivers will use?
If so, we could put that MMA_COMMON in the toplevel clk Makefile.
If not, then yes I agree that obj-y will be fine.
Brian
prev parent reply other threads:[~2026-07-20 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 21:43 [PATCH] clk: mmp: allow COMPILE_TEST builds Rosen Penev
2026-07-20 14:46 ` Duje Mihanović
2026-07-20 20:08 ` Brian Masney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al6ALM2eIWots1Zr@redhat.com \
--to=bmasney@redhat.com \
--cc=dujemihanovic32@gmail.com \
--cc=justinstitt@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=mturquette@baylibre.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rosenp@gmail.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox