From: Julia Lawall <julia.lawall@lip6.fr>
To: matthias.bgg@kernel.org
Cc: ulrich.hecht+renesas@gmail.com,
laurent.pinchart@ideasonboard.com, ck.hu@mediatek.com,
p.zabel@pengutronix.de, airlied@linux.ie, robh+dt@kernel.org,
mark.rutland@arm.com, mturquette@baylibre.com,
sboyd@codeaurora.org, lee.jones@linaro.org,
sean.wang@mediatek.com, gregkh@linuxfoundation.org,
rdunlap@infradead.org, linux@armlinux.org.uk,
dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org,
Matthias Brugger <mbrugger@suse.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, matthias.bgg@gmail.com,
mchehab@kernel.org, pi-cheng.chen@linaro.org,
davem@davemloft.net, linux-kernel@vger.kernel.org,
kbuild-all@01.org
Subject: Re: [resend PATCH v4 2/5] clk: mediatek: mt2701-mmsys: switch to platform device probing (fwd)
Date: Wed, 18 Jul 2018 16:54:57 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1807181654200.3113@hadrien> (raw)
Please check on whether the kfree is still needed.
julia
---------- Forwarded message ----------
Date: Wed, 18 Jul 2018 22:03:48 +0800
From: kbuild test robot <lkp@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [resend PATCH v4 2/5] clk: mediatek: mt2701-mmsys: switch to
platform device probing
In-Reply-To: <20180717220328.792-3-matthias.bgg@kernel.org>
References: <20180717220328.792-3-matthias.bgg@kernel.org>
TO: matthias.bgg@kernel.org
Hi Matthias,
I love your patch! Perhaps something to improve:
[auto build test WARNING on sof-driver-fuweitax/master]
[also build test WARNING on v4.18-rc5 next-20180718]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/matthias-bgg-kernel-org/arm-arm64-mediatek-Fix-mmsys-device-probing/20180718-191916
base: https://github.com/fuweitax/linux master
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
>> drivers/clk/mediatek/clk-mt2701-mm.c:128:1-6: WARNING: invalid free of devm_ allocated data
# https://github.com/0day-ci/linux/commit/555e11caac5f7729e8927939046adbfa2264f9f5
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 555e11caac5f7729e8927939046adbfa2264f9f5
vim +128 drivers/clk/mediatek/clk-mt2701-mm.c
e98621182 Shunli Wang 2016-11-04 122
555e11caa Matthias Brugger 2018-07-18 123 static int clk_mt2701_mm_remove(struct platform_device *pdev)
555e11caa Matthias Brugger 2018-07-18 124 {
555e11caa Matthias Brugger 2018-07-18 125 struct clk_mt2701_mm_priv *private = platform_get_drvdata(pdev);
555e11caa Matthias Brugger 2018-07-18 126
555e11caa Matthias Brugger 2018-07-18 127 kfree(private->clk_data);
555e11caa Matthias Brugger 2018-07-18 @128 kfree(private);
555e11caa Matthias Brugger 2018-07-18 129
555e11caa Matthias Brugger 2018-07-18 130 return 0;
555e11caa Matthias Brugger 2018-07-18 131 }
555e11caa Matthias Brugger 2018-07-18 132
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next reply other threads:[~2018-07-18 14:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 14:54 Julia Lawall [this message]
2018-07-18 14:58 ` [resend PATCH v4 2/5] clk: mediatek: mt2701-mmsys: switch to platform device probing (fwd) Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1807181654200.3113@hadrien \
--to=julia.lawall@lip6.fr \
--cc=airlied@linux.ie \
--cc=ck.hu@mediatek.com \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=pi-cheng.chen@linaro.org \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sean.wang@mediatek.com \
--cc=ulrich.hecht+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox