From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3532DC0650F for ; Thu, 8 Aug 2019 19:51:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FA082173E for ; Thu, 8 Aug 2019 19:51:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732327AbfHHTvi (ORCPT ); Thu, 8 Aug 2019 15:51:38 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:46774 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730678AbfHHTvi (ORCPT ); Thu, 8 Aug 2019 15:51:38 -0400 X-IronPort-AV: E=Sophos;i="5.64,362,1559512800"; d="scan'208";a="394890790" Received: from abo-12-105-68.mrs.modulonet.fr (HELO hadrien) ([85.68.105.12]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 21:51:35 +0200 Date: Thu, 8 Aug 2019 21:51:35 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Stephen Boyd cc: Jonas Gorski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Michael Turquette , Philippe Mathieu-Daud?? , Florian Fainelli , linux-kernel@vger.kernel.org, kbuild-all@01.org Subject: Re: [PATCH] clk: fix devm_platform_ioremap_resource.cocci warnings In-Reply-To: <20190808194821.825AD21743@mail.kernel.org> Message-ID: References: <20190808194821.825AD21743@mail.kernel.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Thu, 8 Aug 2019, Stephen Boyd wrote: > Quoting Julia Lawall (2019-08-08 09:10:53) > > From: kbuild test robot > > > > drivers/clk/bcm/clk-bcm63xx-gate.c:174:1-9: WARNING: Use devm_platform_ioremap_resource for hw -> regs > > > > Use devm_platform_ioremap_resource helper which wraps > > platform_get_resource() and devm_ioremap_resource() together. > > > > Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci > > > > Fixes: 1c099779c1e2 ("clk: add BCM63XX gated clock controller driver") > > Is it fixing anything? As far as I can tell it's reducing lines of code > with another function. No, it doesn't fix anything. julia > > > CC: Jonas Gorski > > Signed-off-by: kbuild test robot > > Signed-off-by: Julia Lawall > >