From: Julia Lawall <julia.lawall@inria.fr>
To: Liam Beguin <liambeguin@gmail.com>,
mturquette@baylibre.com, sboyd@kernel.org
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
kbuild-all@lists.01.org
Subject: [PATCH] clk: fix for_each_child.cocci warnings
Date: Wed, 7 Apr 2021 21:02:32 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2104072100410.11549@hadrien> (raw)
From: kernel test robot <lkp@intel.com>
For_each_child_of_node should have of_node_put() before goto.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
CC: Liam Beguin <lvb@xiphos.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
url: https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408
base: f40ddce88593482919761f74910f42f4b84c004b
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago
clk-lmk04832.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/clk/clk-lmk04832.c
+++ b/drivers/clk/clk-lmk04832.c
@@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev
if (ret) {
dev_err(lmk->dev, "missing reg property in child: %s\n",
child->full_name);
+ of_node_put(child);
goto err_disable_oscin;
}
next reply other threads:[~2021-04-07 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 19:02 Julia Lawall [this message]
2021-04-08 0:31 ` [PATCH] clk: fix for_each_child.cocci warnings Stephen Boyd
2021-04-08 1:50 ` Liam Beguin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2104072100410.11549@hadrien \
--to=julia.lawall@inria.fr \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=liambeguin@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox