From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 459A037F315
	for <linux-clk@vger.kernel.org>; Fri, 24 Jul 2026 18:43:18 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1784918606; cv=none; b=Wz/i5G24qMk+Tb9JnkEzJs3WMH1v7DsmIqhwIs3W6pEP8o4zeb+X9gw2Hvjk/C0SwUAvI6bX1UBo22ffe75OQgOeYX/ofCme6fArOqMFj8nZ6UlKzWE7U663T2hvgPIGBGgZF8MT44/goyNWMAOlGzrQ4WjkFmWmCgDiCCtuXo4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1784918606; c=relaxed/simple;
	bh=GP9IFwbiigSeJPvzqMICj3Nx5GxSPoOIThc5SA+/644=;
	h=From:To:Subject:Date:Message-ID:MIME-Version; b=jCZkIl435dJ+MLZV000PzOFiBkv0IRbqYMkREaqPL5N6ZYfREEs5v2UbLWEtDQoDqz738qsuP2nM0xiPL7GDib+oYesXgjIQg8fOrjHAX9YiFXLBuVauHp6DOge88s5wKUiDKVaVEVzOxlqxEmFDWuXCIvZvn5gzjvjLH+02y/s=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qNZK/yFG; arc=none smtp.client-ip=209.85.128.45
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qNZK/yFG"
Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-495590dde14so8977305e9.0
        for <linux-clk@vger.kernel.org>; Fri, 24 Jul 2026 11:43:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20251104; t=1784918595; x=1785523395; darn=vger.kernel.org;
        h=content-transfer-encoding:mime-version:message-id:date:subject:to
         :from:from:to:cc:subject:date:message-id:reply-to:content-type;
        bh=3tiB/j/1EHf64fdSZiWk3JUWgesb+0DTWJ3IdcA3OOA=;
        b=qNZK/yFG+LxzWYckKMFzv251Twubgzt5S9CdwpQpkiZSBmIjyQEJ2I8DQdxEjva/oP
         7z+nF8TnCxZA/e1g69MGplCVd1nzJRD8ee1wvY3uTO/CK7hwWzRkqGVgIWYZEx/n2Q70
         DqEwS07yZ+Qi67R/UcyewtZKmIHXabzU3XaK+tBNjGvHUDefapKmJbkeaiz2STx8Mmj3
         Jcez03TpDEfDCpCikMkSetrnHbkHiO0qGJsHcrdbsZMV3w6ub/D0mJMphQksJvWXSiou
         XvbqLlx1wtZjpcf3IBRAZV+0+zmxmWH71Csq+wQbXFu10HrzPd7rIzYu0nbTZ9SFB7KZ
         8d9w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20251104; t=1784918595; x=1785523395;
        h=content-transfer-encoding:mime-version:message-id:date:subject:to
         :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to:content-type;
        bh=3tiB/j/1EHf64fdSZiWk3JUWgesb+0DTWJ3IdcA3OOA=;
        b=RTzPmq7n7uG8whn6WMGK5ls9IEE6TY+BHjsf/g59UWQBQOSnFiPIJyrTzmA6Is0iBc
         TEx5gDXly2iLdSbPr9FkpRLpsTP8UTUv/2pFEsIFrdXSNfY1yhvoDNQFuJQ2lwiGIXQk
         /8v2TV/OHMFeYrE4lDtPzphc8KUhZ7rl/bvbJPspVy/UP2py5gxurvjTJpKV6LpRNnJ9
         SuESlTFCqCR+LUz+jx+b5zZT3Py6ZklSoKYL1LgfDJAjTdnUjIDoihG8y+T08JQUgLlb
         Nykjz3w+i6MBJ6bmc1c0I2lsQKjYLDCxfmZTZp+fTyEytpU+DFDh4v7dmLxta+qPPWO+
         YuOA==
X-Forwarded-Encrypted: i=1; AHgh+RoqlGNMCdE6gnZ0wXlbgEoNtMZFKJFmbIWx+zZu5vOOqPyJOB8PH4IR7CbLBSHq03AsfYev+3OB7S4=@vger.kernel.org
X-Gm-Message-State: AOJu0Yx/AYXcSSn3OyVWyCSUpN3eAy3UP16m4wFTWoNrBbKbdGPmN/dM
	A/3lEI2GZKgRmWvboSS1XjLaztLuMgfRrWSLjCceS1KNgRV4dQ1Ahhy1
X-Gm-Gg: AR+sD12Gm6JvzcONKhI0ychgUfunN24WmDQb4fF6j9XhMBFCCdotYu+lzVjEptHoI2e
	1hdU5d85/ammRbK/ANiEV9ZmM1yXLp8GXFpUUooHiU3YII3lmsvQtX0y+hvx8YbTQJtB8KOXreN
	iQFGa3hFaOcYEGYURhu+vxdK5VfA++qDBj6xw4lzeI05+2ic/SA8UZeaArY9Xay9UFrWyXPsUrp
	0BdVa6Dqm9OAnQL+P4sop15ZiFOqOQPz4Vm/opy9AsUbuiaP7gMEdyJfqbJMTi3xc0Tq+7+exWz
	+K4EXt1LrGtSwvz1IY5F0F8EAAc54VCbVYjl3Gh92Q3wdXXZQfVRJ539MrYIIJRadIoR2EeNcaQ
	NuLwXHxmdZAiF9HsKvr6j8k/+QVuVwBEjUr7N1YG7YZmoP3SIb23DvbxVyWz1nvJN59PnK/h47S
	8YErWrS5+Sxd2eONa6Z3VGwyPpsmN6KPatW50qdjVNDMBwwGVBAGjcjqC7NWVGX4No
X-Received: by 2002:a05:600c:4ed1:b0:495:5d6d:9cb3 with SMTP id 5b1f17b1804b1-49573d13756mr94264605e9.37.1784918594458;
        Fri, 24 Jul 2026 11:43:14 -0700 (PDT)
Received: from Ansuel-XPS24.localdomain (host-87-3-249-180.retail.telecomitalia.it. [87.3.249.180])
        by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-47f85bd850asm25701300f8f.15.2026.07.24.11.43.13
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Fri, 24 Jul 2026 11:43:14 -0700 (PDT)
From: Christian Marangi <ansuelsmth@gmail.com>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Christian Marangi <ansuelsmth@gmail.com>,
	Felix Fietkau <nbd@nbd.name>,
	linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] clk: en7523: Add support for selecting SCU serdes
Date: Fri, 24 Jul 2026 20:43:00 +0200
Message-ID: <20260724184304.192962-1-ansuelsmth@gmail.com>
X-Mailer: git-send-email 2.53.0
Precedence: bulk
X-Mailing-List: linux-clk@vger.kernel.org
List-Id: <linux-clk.vger.kernel.org>
List-Subscribe: <mailto:linux-clk+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-clk+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This small series is a split from the Airoha AN7581 USB PHY series [1].

[1] https://lore.kernel.org/all/20260702093812.15918-1-ansuelsmth@gmail.com/

Christian Marangi (2):
  dt-bindings: clock: airoha: Add PHY binding for Serdes port
  clk: en7523: Add support for selecting the Serdes port in SCU

 .../bindings/clock/airoha,en7523-scu.yaml     |  24 +-
 drivers/clk/Kconfig                           |   1 +
 drivers/clk/clk-en7523.c                      | 218 +++++++++++++++++-
 include/dt-bindings/soc/airoha,scu-ssr.h      |  11 +
 4 files changed, 248 insertions(+), 6 deletions(-)
 create mode 100644 include/dt-bindings/soc/airoha,scu-ssr.h

-- 
2.53.0


From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37C8444CACB
	for <linux-clk@vger.kernel.org>; Fri, 24 Jul 2026 18:43:20 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1784918608; cv=none; b=Gq+r7klAbPS17mRY9ScupyL2w19sDgRzpb8TkH7wkUVZkfhBjaJhuEVdRjdsGFwWwqP1H9qVx7w4AXn1l6gSxDyca2fqGpPFH8ySKCjK4kfVq3QNDbUWqQyhUVqA2e9mThYcRET4NPAe/W/FVMgojq3Z12+YXWb+108w50ap3LU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1784918608; c=relaxed/simple;
	bh=S3Q/+d2FsBlN/P12XJtwUtJEKsGGawcHMg9yNFW2tL4=;
	h=From:To:Subject:Date:Message-ID:In-Reply-To:References:
	 MIME-Version; b=T2wo7/2umOiPquXT9b7XPC7jRKahk56qKinn2l0bNL1EPAkapkhA6qnom53K8DAdYvnD6T3Htl1uJBu4V+2fBpdfFf2727iBjCzetzOIeWed2+fidrlz9+bEkFThPsgbvx6FtiqcVjsRtqKF+p6JlRMho4OiCrEq2aFVSh2RZiw=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZMGS2RdJ; arc=none smtp.client-ip=209.85.128.50
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZMGS2RdJ"
Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-49553515a8bso8893725e9.1
        for <linux-clk@vger.kernel.org>; Fri, 24 Jul 2026 11:43:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20251104; t=1784918596; x=1785523396; darn=vger.kernel.org;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:to:from:from:to:cc:subject:date:message-id
         :reply-to:content-type;
        bh=crj6kaAmoeOOOLVaGiQbQt/QdMV68EZw3l9HAE3uANU=;
        b=ZMGS2RdJ0GtqRkA211F+SMByk3aayyin9mlCmoGtbusutxbss4XSPX+o46CA8rqO7v
         v0vdGlCH+E2k9EHIh6hbQox9D+UDAbbTcH0wj6ULkxr9n/I60DFJE70SxFFgHLrVeObS
         5jfQDkakgHGEdhmk5v8mxmjqrzxOqfI9Db7QqqEB8iroXWEKwceowkgIvUVKUgdYYYoF
         End0LE7JK+zhYFMxYUPHQY6Qn5cz1eKTG5SUF7bG28Hxv6Z4wjIKRjkEBv4f2I4hEmO4
         KrhwJvANOi+UzjeSrFqoRo3usX5/8aIExYkoBg/KORA3fXA0T8qolVURRlpTLcYlxfQE
         7Zxg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20251104; t=1784918596; x=1785523396;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to
         :cc:subject:date:message-id:reply-to:content-type;
        bh=crj6kaAmoeOOOLVaGiQbQt/QdMV68EZw3l9HAE3uANU=;
        b=B/n6c3oRq45l82uOzSrHRl3q+6TY/H2uEISHDBcnPWSb8oHB28e4AvEkHFKAyHy2wA
         XLDJeEhOZmNnSeR4g2FxEANImJbsmEAdX21a+EoCIzOkrpR2RgsPg1G8Al03Kt5A2P2V
         3vciwg0oauVsIo7Hq4pi/uz5hqG9ZuDe/LU3YNAJHTA+6djer+67hIU5MdBQVfnlj+e7
         blWkRA2qR9fIIXlgbKvCADCJ+8w5P9iemnUBGKafYCqx8l5hxY6TiIUbc/1vslhQ3ttz
         6fvfM5MzBy95oAmZrENITfsCMaSqhhst+RelFr4gBVXfw+d0P0xLHsqNoDHVzAOVCnpP
         MCwg==
X-Forwarded-Encrypted: i=1; AHgh+RqByeauLe198mBTTzg0n5cBIT8KijGAgdGk1L35osIGdWpYGgoHiT+dhAG8EZMVxHX6RjUW7Zn+WU8=@vger.kernel.org
X-Gm-Message-State: AOJu0Yxu+ak+0cVMXzeUuvrn2IgwdQx8CELpWZffav4gYUmiRMojfctX
	BCDXFgvsg7pDB7YbSdb6UW3QsCewO7SKCElrA8ZMRR8lMjOh0DtVKh3b
X-Gm-Gg: AR+sD116dHiLHA2U8GGaHj4iij7+Q6mmX/t3C/SGx79Mf1s9jc+0OMUGcEOzKeZN/ju
	QKOzWv/pqQR+ipc92kikIoH4FLh8RiWzpoJdOTe9LzldHX19CiJuZ4SD9djJckAQ6+VKgPmwgGF
	e7lY37mKS8pkbWQ/0s4mEax6hXI6R1BGsNDHm/bD0ufj7a+MwGLxkfxZ5LTl3ATP300lyxySKU+
	fTpyVFkMo7wP0v9ukbEjXhi40mjgW1586isP/LkFnkO7OAeG0y23V5JZ+T+18r3neStzXONp5/2
	KYRgYllnTF5LBWcmMYWFazJZ4lj97+SBDKlbctjLPoskwqREsuMcXsfPkLZcw0mpYpmUgAPV9oG
	uxkRhKt+imkcsdi+LxgDrixu26LTbHjCyE1Xcq8mN4DzJHbw4PoPG7GBeRXk0iIwHeJz9csXkkh
	IezBrT9JAqXkQbsMgWloOjXYIE7c4Q+ryuGM/BlXNUIQIH5q/iPF/pWAGKCHYm2tUz
X-Received: by 2002:a05:600c:198d:b0:493:c773:c3f4 with SMTP id 5b1f17b1804b1-49573cffcdcmr98305755e9.22.1784918595771;
        Fri, 24 Jul 2026 11:43:15 -0700 (PDT)
Received: from Ansuel-XPS24.localdomain (host-87-3-249-180.retail.telecomitalia.it. [87.3.249.180])
        by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-47f85bd850asm25701300f8f.15.2026.07.24.11.43.14
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Fri, 24 Jul 2026 11:43:15 -0700 (PDT)
From: Christian Marangi <ansuelsmth@gmail.com>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Christian Marangi <ansuelsmth@gmail.com>,
	Felix Fietkau <nbd@nbd.name>,
	linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] dt-bindings: clock: airoha: Add PHY binding for Serdes port
Date: Fri, 24 Jul 2026 20:43:01 +0200
Message-ID: <20260724184304.192962-2-ansuelsmth@gmail.com>
X-Mailer: git-send-email 2.53.0
In-Reply-To: <20260724184304.192962-1-ansuelsmth@gmail.com>
References: <20260724184304.192962-1-ansuelsmth@gmail.com>
Precedence: bulk
X-Mailing-List: linux-clk@vger.kernel.org
List-Id: <linux-clk.vger.kernel.org>
List-Subscribe: <mailto:linux-clk+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-clk+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add PHY cell property for Serdes port selection. Currently supported only
for Airoha AN7581 SoC, that support up to 4 Serdes port.

The Serdes port can support both PCIe, USB3 or Ethernet mode.

- PCIe1 Serdes can support PCIe or Ethernet mode.
- PCIe2 Serdes can support PCIe or Ethernet mode.
- USB1 Serdes can support USB3 or HSGMII mode.
- USB2 Serdes can support USB3 or PCIe mode.

Add bindings to permit correct reference of the Serdes ports in DT.
Values are just symbolic and enumerates the Serdes port with a specific
number for precise reference.

The available Serdes port can be selected following the dt-binding header
in [2].

[2] <include/dt-bindings/soc/airoha,scu-ssr.h>

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 .../bindings/clock/airoha,en7523-scu.yaml     | 24 ++++++++++++++++---
 include/dt-bindings/soc/airoha,scu-ssr.h      | 11 +++++++++
 2 files changed, 32 insertions(+), 3 deletions(-)
 create mode 100644 include/dt-bindings/soc/airoha,scu-ssr.h

diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
index eb24a5687639..fc37786ac7ed 100644
--- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
+++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
@@ -23,6 +23,7 @@ description: |
 
   All these identifiers can be found in:
   [1]: <include/dt-bindings/clock/en7523-clk.h>.
+  [2]: <include/dt-bindings/soc/airoha,scu-ssr.h>.
 
   The clocks are provided inside a system controller node.
 
@@ -50,6 +51,12 @@ properties:
     description: ID of the controller reset line
     const: 1
 
+  '#phy-cells':
+    description:
+      The first cell indicates the serdes phy number, see [2] for the
+      available serdes port.
+    const: 1
+
 required:
   - compatible
   - reg
@@ -65,12 +72,23 @@ allOf:
         reg:
           minItems: 2
 
+        '#phy-cells': false
+
+  - if:
+      properties:
+        compatible:
+          const: econet,en751221-scu
+    then:
+      properties:
+        reg:
+          maxItems: 1
+
+        '#phy-cells': false
+
   - if:
       properties:
         compatible:
-          enum:
-            - airoha,en7581-scu
-            - econet,en751221-scu
+          const: airoha,en7581-scu
     then:
       properties:
         reg:
diff --git a/include/dt-bindings/soc/airoha,scu-ssr.h b/include/dt-bindings/soc/airoha,scu-ssr.h
new file mode 100644
index 000000000000..33c64844ada3
--- /dev/null
+++ b/include/dt-bindings/soc/airoha,scu-ssr.h
@@ -0,0 +1,11 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+
+#ifndef __DT_BINDINGS_AIROHA_SCU_SSR_H
+#define __DT_BINDINGS_AIROHA_SCU_SSR_H
+
+#define AIROHA_SCU_SERDES_PCIE1		0
+#define AIROHA_SCU_SERDES_PCIE2		1
+#define AIROHA_SCU_SERDES_USB1		2
+#define AIROHA_SCU_SERDES_USB2		3
+
+#endif /* __DT_BINDINGS_AIROHA_SCU_SSR_H */
-- 
2.53.0


From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB453456DEC
	for <linux-clk@vger.kernel.org>; Fri, 24 Jul 2026 18:43:20 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1784918608; cv=none; b=DOtG2T6CIUyiBH6iSEfEx3BA+e5g7yX+QJLaSg+RYCCBbvQO2rn8irASM+gZxVA5OdiPyOSHqXQah32+epSF8k/bVWyrOLXjOJwMIVqnmqSlrvCKn60cPOHxE93QcHsIDuWVxJmnnV/45T/9mzC0FG23r2iakT4ZRbCd+EhWAiM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1784918608; c=relaxed/simple;
	bh=Hho4WoSWjB2rIrpB51n+bmgU2MgNFQPIScLmcE/W97w=;
	h=From:To:Subject:Date:Message-ID:In-Reply-To:References:
	 MIME-Version; b=CSEGdfNAtBOqJm1TixEz1XsKW9agRSNwMWhMgTwe6rnLBLbZwGrho03yGgWEpuPWJo2F62kyigglq6WPMIZ+klhYp97Gv3jTPB53eBofHm5JUyXvhUMnB5gdrilIhpcNk7HtZ/QC25ko43bj8xxqm3JxDaPLZzhVsrNq9EjCPCQ=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AEw1r4kL; arc=none smtp.client-ip=209.85.221.41
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AEw1r4kL"
Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-47640541585so506312f8f.1
        for <linux-clk@vger.kernel.org>; Fri, 24 Jul 2026 11:43:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20251104; t=1784918597; x=1785523397; darn=vger.kernel.org;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:to:from:from:to:cc:subject:date:message-id
         :reply-to:content-type;
        bh=jv4z1LhL7ndXVWFW9IHlXeU6IP582amPe/jHp+pPs7U=;
        b=AEw1r4kLwr3+RPXuVLmLbBZktYNlLN3x9qLQKnxE28wAHRIRbmILiHnIyHMvjVVKyz
         8/HfXu7qw+7tDR7jBzvPNepVY3NeMn9/VIKeblpPCDVM5EcLro0RIlPnru839+NhSOxf
         gD0Sx32pZZzPCbMVX9PlV4gGz3Y89BMtFp//LDUn/nvuqbAL7Dl69oiStHHBrq1+lQPG
         ubjl1W0wCgh5fEHgMmHg4gU0Hant1I7FnqsYEr88vpRczQSlyRXrlK+Qk/n47RpvuLXy
         gDs+Ox0vi7rHM35wXFNwtPrEiP3KzEdYbmSvskzYK7iiL1JTjM9Nr86oPIS98doBWbAG
         GyNQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20251104; t=1784918597; x=1785523397;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to
         :cc:subject:date:message-id:reply-to:content-type;
        bh=jv4z1LhL7ndXVWFW9IHlXeU6IP582amPe/jHp+pPs7U=;
        b=Vq1JdkQrL6XMvD0LgScoANyAJVhnG8EJAFp4vbBn21AZqWhChjABqcuTfPD7wyNyne
         +SOivfXVK1L3EcuXdr6UYrIRv89ZfGY2hCzXKNX/+No402BwCCElv8BG8BMdbBj/aQny
         EHcfBUf7mvppHYTxnZkxZSQCu/onupVuAYUr1wt9Huamp6x04mlfK1PT85CoNAmXRWFo
         RkG+fRAFexx+YLGHgM6XfG+Zs/+QRbqU02NFsoEDRQ612AYTpMnXL0Jdz9pZ2NEHjhcc
         RpvzricQazhTDZ6G4BwCBpwK7lkvfbMIKEhRZXNjP92fXcBtLRYXmfzX+vBoM3tnq7Vz
         19Dw==
X-Forwarded-Encrypted: i=1; AHgh+RqkbPz6lrRzMxPpKQSuuiOBVkn33OvVzngVakFtk4rnr1VkVO9HSZUyehnqDoVkVVHWUcDBrbSTbsw=@vger.kernel.org
X-Gm-Message-State: AOJu0Yzo+b4qbrvpaYntwHE51RqQ6Sg4N0X/HgI7g/M91FcQzPNs3KiO
	SlKYwdBA50RD3GC4QaYlKWexTe2gHSh0u69gYzI6EpK/U6UK7KpFNnxZ
X-Gm-Gg: AR+sD10hy6gOnz/dUhFhj9HClj8cKGsnkx98IzffH+pNWX0J7vEPhAPX+TV9pW6v8Ra
	YMb6u5dH/XUByKBpYk+dqcXAKE4cXNT/xsTGifLENmnjHcdFMPyIots2WfMK32mgEBIaMqpR1d3
	xNMLcy6DRp77gW6SJz2pDnbtLhkf7SOFbJZJWhIJwIxrq5rhRaHPjCDGZojJdbJY1/J8+458x31
	aMmbmjs5w21r2iotiTOFNqKQeROZQ2eCq/mYYw5JnP5whMtSFPjkSBBJh4C+qkoczLVsoA5spct
	C3K8iFKPC6Sv8rfe8Bg1jkv4QxE9OhLDqAOqtUZBeBr1928WcJPS+Q5CNdbpaR/0DvbtqkRQxYi
	5OtyWzOkCAb21N6PfbvhsaagD2GoGYdNRWCXseTZORs0ukYHTlgaE8wi2L7DCn+oJl36WNnJfD6
	KVOanXoCXr2m3A/Vi6KRA4xLtQrKYjQt/US+xm1PDsCRN28bClC34wfyBVwgBGbbtWbY0hZqA7g
	M0=
X-Received: by 2002:a05:6000:4381:b0:47f:9201:6409 with SMTP id ffacd0b85a97d-47f9201644bmr9614445f8f.40.1784918597081;
        Fri, 24 Jul 2026 11:43:17 -0700 (PDT)
Received: from Ansuel-XPS24.localdomain (host-87-3-249-180.retail.telecomitalia.it. [87.3.249.180])
        by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-47f85bd850asm25701300f8f.15.2026.07.24.11.43.15
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Fri, 24 Jul 2026 11:43:16 -0700 (PDT)
From: Christian Marangi <ansuelsmth@gmail.com>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Christian Marangi <ansuelsmth@gmail.com>,
	Felix Fietkau <nbd@nbd.name>,
	linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] clk: en7523: Add support for selecting the Serdes port in SCU
Date: Fri, 24 Jul 2026 20:43:02 +0200
Message-ID: <20260724184304.192962-3-ansuelsmth@gmail.com>
X-Mailer: git-send-email 2.53.0
In-Reply-To: <20260724184304.192962-1-ansuelsmth@gmail.com>
References: <20260724184304.192962-1-ansuelsmth@gmail.com>
Precedence: bulk
X-Mailing-List: linux-clk@vger.kernel.org
List-Id: <linux-clk.vger.kernel.org>
List-Subscribe: <mailto:linux-clk+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-clk+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

In the SCU register for clock and reset, there are also some register to
select the Serdes port mode. The Airoha AN7581 SoC have 4 different Serdes
that can switch between PCIe, USB or Ethernet mode.

Add a simple PHY provider that expose the .set_mode OP to toggle the
requested mode for the Serdes port.

Reviewed-by: Brian Masney <bmasney@redhat.com>
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 drivers/clk/Kconfig      |   1 +
 drivers/clk/clk-en7523.c | 218 ++++++++++++++++++++++++++++++++++++++-
 2 files changed, 216 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 1717ce75a907..4d58c35d88bc 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -221,6 +221,7 @@ config COMMON_CLK_EN7523
 	bool "Clock driver for Airoha/EcoNet SoC system clocks"
 	depends on OF
 	depends on ARCH_AIROHA || ECONET || COMPILE_TEST
+	select GENERIC_PHY
 	default ARCH_AIROHA
 	help
 	  This driver provides the fixed clocks and gates present on Airoha
diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c
index 1ab0e2eca5d3..183cf7fe4bda 100644
--- a/drivers/clk/clk-en7523.c
+++ b/drivers/clk/clk-en7523.c
@@ -6,14 +6,18 @@
 #include <linux/io.h>
 #include <linux/mfd/syscon.h>
 #include <linux/platform_device.h>
+#include <linux/phy.h>
+#include <linux/phy/phy.h>
 #include <linux/property.h>
 #include <linux/regmap.h>
 #include <linux/reset-controller.h>
+#include <linux/spinlock.h>
 #include <dt-bindings/clock/en7523-clk.h>
 #include <dt-bindings/reset/airoha,en7523-reset.h>
 #include <dt-bindings/reset/airoha,en7581-reset.h>
 #include <dt-bindings/clock/econet,en751221-scu.h>
 #include <dt-bindings/reset/econet,en751221-scu.h>
+#include <dt-bindings/soc/airoha,scu-ssr.h>
 
 #define RST_NR_PER_BANK			32
 
@@ -40,9 +44,22 @@
 #define   REG_HIR_MASK			GENMASK(31, 16)
 /* EN7581 */
 #define REG_NP_SCU_PCIC			0x88
+#define REG_NP_SCU_SSR3			0x94
+#define REG_SSUSB_HSGMII_SEL_MASK	BIT(29)
+#define REG_SSUSB_HSGMII_SEL_HSGMII	FIELD_PREP_CONST(REG_SSUSB_HSGMII_SEL_MASK, 0x0)
+#define REG_SSUSB_HSGMII_SEL_USB	FIELD_PREP_CONST(REG_SSUSB_HSGMII_SEL_MASK, 0x1)
 #define REG_NP_SCU_SSTR			0x9c
 #define REG_PCIE_XSI0_SEL_MASK		GENMASK(14, 13)
+#define REG_PCIE_XSI0_SEL_PCIE		FIELD_PREP_CONST(REG_PCIE_XSI0_SEL_MASK, 0x0)
+#define REG_PCIE_XSI0_SEL_XFI		FIELD_PREP_CONST(REG_PCIE_XSI0_SEL_MASK, 0x1)
+#define REG_PCIE_XSI0_SEL_HSGMII	FIELD_PREP_CONST(REG_PCIE_XSI0_SEL_MASK, 0x2)
 #define REG_PCIE_XSI1_SEL_MASK		GENMASK(12, 11)
+#define REG_PCIE_XSI1_SEL_PCIE		FIELD_PREP_CONST(REG_PCIE_XSI1_SEL_MASK, 0x0)
+#define REG_PCIE_XSI1_SEL_XFI		FIELD_PREP_CONST(REG_PCIE_XSI1_SEL_MASK, 0x1)
+#define REG_PCIE_XSI1_SEL_HSGMII	FIELD_PREP_CONST(REG_PCIE_XSI1_SEL_MASK, 0x2)
+#define REG_USB_PCIE_SEL_MASK		BIT(3)
+#define REG_USB_PCIE_SEL_PCIE		FIELD_PREP_CONST(REG_USB_PCIE_SEL_MASK, 0x0)
+#define REG_USB_PCIE_SEL_USB		FIELD_PREP_CONST(REG_USB_PCIE_SEL_MASK, 0x1)
 #define REG_CRYPTO_CLKSRC2		0x20c
 /* EN751221 */
 #define EN751221_REG_SPI_DIV		0x0cc
@@ -81,6 +98,8 @@ enum en_hir {
 	HIR_MAX		= 14,
 };
 
+#define EN_SERDES_PHY_NUM		4
+
 struct en_clk_desc {
 	int id;
 	const char *name;
@@ -113,6 +132,18 @@ struct en_rst_data {
 	struct reset_controller_dev rcdev;
 };
 
+struct en_serdes_phy_instance {
+	struct phy *phy;
+	unsigned int serdes_port;
+};
+
+struct en_clk_priv {
+	void __iomem *base;
+	/* protect SCU register */
+	spinlock_t lock;
+	struct en_serdes_phy_instance *serdes_phys[EN_SERDES_PHY_NUM];
+};
+
 struct en_clk_soc_data {
 	u32 num_clocks;
 	const struct clk_ops pcie_ops;
@@ -830,12 +861,179 @@ static int en7581_reset_register(struct device *dev, void __iomem *base,
 	return devm_reset_controller_register(dev, &rst_data->rcdev);
 }
 
+static int en7581_serdes_phy_set_mode(struct phy *phy, enum phy_mode mode,
+				      int submode)
+{
+	struct en_serdes_phy_instance *instance = phy_get_drvdata(phy);
+	struct en_clk_priv *priv = dev_get_drvdata(phy->dev.parent);
+	u32 reg, mask, sel, val;
+	unsigned long flags;
+
+	switch (instance->serdes_port) {
+	case AIROHA_SCU_SERDES_PCIE1:
+		reg = REG_NP_SCU_SSTR;
+		mask = REG_PCIE_XSI0_SEL_MASK;
+
+		if (mode != PHY_MODE_ETHERNET && mode != PHY_MODE_PCIE)
+			return -EINVAL;
+
+		if (mode == PHY_MODE_ETHERNET) {
+			switch (submode) {
+			case PHY_INTERFACE_MODE_USXGMII:
+			case PHY_INTERFACE_MODE_10GBASER:
+				sel = REG_PCIE_XSI0_SEL_XFI;
+				break;
+			case PHY_INTERFACE_MODE_SGMII:
+			case PHY_INTERFACE_MODE_1000BASEX:
+			case PHY_INTERFACE_MODE_2500BASEX:
+				sel = REG_PCIE_XSI0_SEL_HSGMII;
+				break;
+			default:
+				return -EINVAL;
+			}
+		} else {
+			sel = REG_PCIE_XSI0_SEL_PCIE;
+		}
+
+		break;
+	case AIROHA_SCU_SERDES_PCIE2:
+		reg = REG_NP_SCU_SSTR;
+		mask = REG_PCIE_XSI1_SEL_MASK;
+
+		if (mode != PHY_MODE_ETHERNET && mode != PHY_MODE_PCIE)
+			return -EINVAL;
+
+		if (mode == PHY_MODE_ETHERNET) {
+			switch (submode) {
+			case PHY_INTERFACE_MODE_USXGMII:
+			case PHY_INTERFACE_MODE_10GBASER:
+				sel = REG_PCIE_XSI1_SEL_XFI;
+				break;
+			case PHY_INTERFACE_MODE_SGMII:
+			case PHY_INTERFACE_MODE_1000BASEX:
+			case PHY_INTERFACE_MODE_2500BASEX:
+				sel = REG_PCIE_XSI1_SEL_HSGMII;
+				break;
+			default:
+				return -EINVAL;
+			}
+		} else {
+			sel = REG_PCIE_XSI1_SEL_PCIE;
+		}
+
+		break;
+	case AIROHA_SCU_SERDES_USB1:
+		reg = REG_NP_SCU_SSR3;
+		mask = REG_SSUSB_HSGMII_SEL_MASK;
+
+		if (mode != PHY_MODE_ETHERNET && mode != PHY_MODE_USB_DEVICE &&
+		    mode != PHY_MODE_USB_DEVICE_SS)
+			return -EINVAL;
+
+		if (mode == PHY_MODE_ETHERNET)
+			sel = REG_SSUSB_HSGMII_SEL_HSGMII;
+		else
+			sel = REG_SSUSB_HSGMII_SEL_USB;
+
+		break;
+	case AIROHA_SCU_SERDES_USB2:
+		reg = REG_NP_SCU_SSTR;
+		mask = REG_USB_PCIE_SEL_MASK;
+
+		if (mode != PHY_MODE_PCIE && mode != PHY_MODE_USB_DEVICE &&
+		    mode != PHY_MODE_USB_DEVICE_SS)
+			return -EINVAL;
+
+		if (mode == PHY_MODE_PCIE)
+			sel = REG_USB_PCIE_SEL_PCIE;
+		else
+			sel = REG_USB_PCIE_SEL_USB;
+
+		break;
+	default:
+		return -EINVAL;
+	}
+
+	spin_lock_irqsave(&priv->lock, flags);
+	val = readl(priv->base + reg);
+	val &= ~mask;
+	val |= sel;
+	writel(val, priv->base + reg);
+	spin_unlock_irqrestore(&priv->lock, flags);
+
+	return 0;
+}
+
+static const struct phy_ops en7581_serdes_phy_ops = {
+	.set_mode	= en7581_serdes_phy_set_mode,
+	.owner		= THIS_MODULE,
+};
+
+static struct phy *en7581_serdes_phy_xlate(struct device *dev,
+					   const struct of_phandle_args *args)
+{
+	struct en_clk_priv *priv = dev_get_drvdata(dev);
+	struct en_serdes_phy_instance *instance;
+	unsigned int serdes_port;
+
+	if (args->args_count != 1) {
+		dev_err(dev, "invalid number of cells in 'phy' property\n");
+		return ERR_PTR(-EINVAL);
+	}
+
+	serdes_port = args->args[0];
+	if (serdes_port >= EN_SERDES_PHY_NUM) {
+		dev_err(dev, "invalid serdes port: %d\n", serdes_port);
+		return ERR_PTR(-EINVAL);
+	}
+
+	instance = priv->serdes_phys[serdes_port];
+	if (!instance) {
+		dev_err(dev, "failed to find appropriate serdes phy\n");
+		return ERR_PTR(-EINVAL);
+	}
+
+	return instance->phy;
+}
+
+static int en7581_serdes_phy_register(struct device *dev)
+{
+	struct en_clk_priv *priv = dev_get_drvdata(dev);
+	struct phy_provider *phy_provider;
+	int i;
+
+	for (i = 0; i < EN_SERDES_PHY_NUM; i++) {
+		struct en_serdes_phy_instance *instance;
+
+		instance = devm_kzalloc(dev, sizeof(*instance),
+					GFP_KERNEL);
+		if (!instance)
+			return -ENOMEM;
+
+		instance->phy = devm_phy_create(dev, NULL,
+						&en7581_serdes_phy_ops);
+		if (IS_ERR(instance->phy))
+			return dev_err_probe(dev, PTR_ERR(instance->phy), "failed to create phy\n");
+
+		instance->serdes_port = i;
+		priv->serdes_phys[i] = instance;
+
+		phy_set_drvdata(instance->phy, instance);
+	}
+
+	phy_provider = devm_of_phy_provider_register(dev, en7581_serdes_phy_xlate);
+
+	return PTR_ERR_OR_ZERO(phy_provider);
+}
+
 static int en7581_clk_hw_init(struct platform_device *pdev,
 			      struct clk_hw_onecell_data *clk_data)
 {
+	struct en_clk_priv *priv = platform_get_drvdata(pdev);
 	struct regmap *map;
 	void __iomem *base;
 	u32 val;
+	int ret;
 
 	map = syscon_regmap_lookup_by_compatible("airoha,en7581-chip-scu");
 	if (IS_ERR(map))
@@ -845,6 +1043,8 @@ static int en7581_clk_hw_init(struct platform_device *pdev,
 	if (IS_ERR(base))
 		return PTR_ERR(base);
 
+	priv->base = base;
+
 	en7581_register_clocks(&pdev->dev, clk_data, map, base);
 
 	val = readl(base + REG_NP_SCU_SSTR);
@@ -853,9 +1053,12 @@ static int en7581_clk_hw_init(struct platform_device *pdev,
 	val = readl(base + REG_NP_SCU_PCIC);
 	writel(val | 3, base + REG_NP_SCU_PCIC);
 
-	return en7581_reset_register(&pdev->dev, base, en7581_rst_map,
-				     ARRAY_SIZE(en7581_rst_map),
-				     en7581_rst_ofs);
+	ret = en7581_reset_register(&pdev->dev, base, en7581_rst_map,
+				    ARRAY_SIZE(en7581_rst_map), en7581_rst_ofs);
+	if (ret)
+		return ret;
+
+	return en7581_serdes_phy_register(&pdev->dev);
 }
 
 static enum en_hir get_hw_id(void __iomem *np_base)
@@ -962,16 +1165,25 @@ static int en7523_clk_probe(struct platform_device *pdev)
 	struct device_node *node = pdev->dev.of_node;
 	const struct en_clk_soc_data *soc_data;
 	struct clk_hw_onecell_data *clk_data;
+	struct en_clk_priv *priv;
 	int r;
 
 	soc_data = device_get_match_data(&pdev->dev);
 
+	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
+	if (!priv)
+		return -ENOMEM;
+
+	spin_lock_init(&priv->lock);
+
 	clk_data = devm_kzalloc(&pdev->dev,
 				struct_size(clk_data, hws, soc_data->num_clocks),
 				GFP_KERNEL);
 	if (!clk_data)
 		return -ENOMEM;
 
+	platform_set_drvdata(pdev, priv);
+
 	clk_data->num = soc_data->num_clocks;
 	r = soc_data->hw_init(pdev, clk_data);
 	if (r)
-- 
2.53.0


From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92293370ACA
	for <linux-clk@vger.kernel.org>; Mon, 27 Jul 2026 20:05:50 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1785182752; cv=none; b=Sx5hLrPBhQk0aAyqellOyDhlrMB1YUWsByqsJVOlhjDqw2nZOjkd6lstGaPqkYm6J7nqQpSNwkhc8wU08VatYw2YafGfXriUtcqITXGzJnNa0UHsC+wsoPW2T/oOAp7rHHOqozwEHRbK99pQq1nZB4iYUyyIIIlmn8FvSS+n73E=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1785182752; c=relaxed/simple;
	bh=l0fyMC2SBur5U3Qh/dOAnUiQvkL2joWBa6r3CqBxMLw=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=R7J4O5go71IXCHhHHJQEDLblsTSenqXan4IgMb/NU50Tx3qp82iPECM/m9+m7yezFitvAJddxMAhFAM54qQvVENOTWKx3QmmsvnqePWE8VYD6MTL8xomQ119R8RA5jtEbszAM+TAD2DMy3Sx8oDi3FBmTQw69HQqwZAkTFKRDFI=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CFL0YpFX; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nyZBR8pI; arc=none smtp.client-ip=170.10.129.124
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CFL0YpFX";
	dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nyZBR8pI"
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1785182749;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=lHAl5GzXFBvOzawjrxy+mgEHuifdBY8i61HHJ7qviQ8=;
	b=CFL0YpFXYkQujNiEyBLhVO4Xa9a9XruM5z5QJNUQ3ZYK4Yxlfd+5kEinqi8FJwcI78OkDA
	ZqzwYNcgE5arfAFgnbyOPAb/boOQTCoAp81ucmXjv4tdlA/wjV4DCIGwGzYvuk1EtIoIMd
	SAdfXvTgLT5/hVug6d5ke60n99D2cfo=
Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com
 [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
 us-mta-591-ycUJtyjbMmuvET20eS41EA-1; Mon, 27 Jul 2026 16:05:48 -0400
X-MC-Unique: ycUJtyjbMmuvET20eS41EA-1
X-Mimecast-MFC-AGG-ID: ycUJtyjbMmuvET20eS41EA_1785182748
Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e9a2b95b5so562149685a.2
        for <linux-clk@vger.kernel.org>; Mon, 27 Jul 2026 13:05:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=redhat.com; s=google; t=1785182748; x=1785787548; darn=vger.kernel.org;
        h=user-agent:in-reply-to:content-disposition:content-type
         :mime-version:references:message-id:subject:cc:to:from:date:from:to
         :cc:subject:date:message-id:reply-to:content-type;
        bh=lHAl5GzXFBvOzawjrxy+mgEHuifdBY8i61HHJ7qviQ8=;
        b=nyZBR8pI180POy4A1Ck+mVzmdDzqEArNCUGYhpiuaUqJJxu//JLaOYIBrlpPaAEf3t
         ZZbKNtcEJp/R/RVxReX0xVTnxxcafODsKzhJ7AiUHpdEiR5UhTi41Xs1wkUfaB/jUT+m
         FX725Wz7EYGkuMR1+euAqNvQbgNtNT0eDqr4uYrjMv29vXL4iXwN0TOj8pXy5DLcN3Gq
         Gdvd8nYlUBCwrYXW6CISs4EKvPrzXadKoVC9kD4gY0bbsHNm/YEQsllcJnQgfSQW8/22
         nBm9/DsVEX4P1u5g8BYEVddvHckb6uxKt5uJgL4oK6dpRs/smmuO7xK8mC/iw6G8YWUa
         dI6g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20251104; t=1785182748; x=1785787548;
        h=user-agent:in-reply-to:content-disposition:content-type
         :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to
         :content-type;
        bh=lHAl5GzXFBvOzawjrxy+mgEHuifdBY8i61HHJ7qviQ8=;
        b=YUyXFIeplo1q9K2fLRvurz9GkFScVlxRPwFPaiHVQyvM8rdLjLV1cdIrSoSjWWTTjh
         yueBMpDk/+NvNtGqPsvG4n+AACLFtW0h5ZM5X9s0Hp5t7rK3ZJ/Y/SaL3/SLXbqD2FJE
         iCUfj2Vt+gD0UTHH8Lr2W539sein1dHalWGCBINncCYicfJXWSrhIm3/pdhM2PmVh8mv
         gvgslavRD1KcGjDrVEx7V0O/AAhrISXaOobgDqL6pZbcA5kyPoJDepbg/mtgEfLrX0ZT
         QuZn42ILZOAjdfbQSU2zXz+5CiAzRYciRh38mVpA9w5kqMhaSOSUsgdNHy4cu8Gn2FEt
         Iu9Q==
X-Forwarded-Encrypted: i=1; AHgh+RqoXebXXmwpdadqfpWOfcuaDGSv5bFwd4mRBO0siwB8M1Oe7EzoRqG0+3WtDz5P2oWH0H3dsITp6/o=@vger.kernel.org
X-Gm-Message-State: AOJu0Yxm00av1py1o62fkIwR3LR/5tWcVV1abBCPUYwtbmi1E04S6NBo
	5GUrIjipcGrRpQ+BhiWy4eeiBg7MzHDeXMENuKdowKlzhgi5WT8JyKoFqGoh5a+sv7XSRXyOHVB
	DEzUd0EWmbVnq/l1MeOq/MKEiL+VboAPSEMg6r/jEbtWAUyASNQ0tx+TIxB+v0A==
X-Gm-Gg: AR+sD12vOibobh0w+gzlLTby92PhSIDGZa7KgAzhn2gaUDintlFCIWkKv7l+eTClIdr
	R/KqUmIzYjVgDBek7LkF29NcKOqlzBORqltuq201YDrOV8ltrTbOPsCycHQNSu3eEY5uxunRT7h
	aadoVmHIVpxWk//Pme0hpoyfNy1T5btFThDyAHAR6iGi6Yyj5l0+7GBlJEkoKmpblGMx+BPuhKe
	v3/mfHBKeECpzKp9fwnRenmoAb1opEUTAaPfOsaDYfZL9FnqVBgA0DkTTWfduRQIAKaMlbGrY0t
	FnXAwv4+JEL8KRPc8MwYr1DVVW0eOtQ3Pb1mtCp1DrHjOyue0Y6u/ZU2UC0wRlMVkgvH2N9n+w=
	=
X-Received: by 2002:a05:620a:48d:b0:930:a74c:f1c5 with SMTP id af79cd13be357-932df72ff1fmr818068585a.59.1785182747586;
        Mon, 27 Jul 2026 13:05:47 -0700 (PDT)
X-Received: by 2002:a05:620a:48d:b0:930:a74c:f1c5 with SMTP id af79cd13be357-932df72ff1fmr818064685a.59.1785182747059;
        Mon, 27 Jul 2026 13:05:47 -0700 (PDT)
Received: from redhat.com ([2600:382:771a:ae2:b914:58a6:76d2:bfbb])
        by smtp.gmail.com with ESMTPSA id 6a1803df08f44-907e86a1b62sm72216126d6.26.2026.07.27.13.05.44
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 27 Jul 2026 13:05:46 -0700 (PDT)
Date: Mon, 27 Jul 2026 16:05:43 -0400
From: Brian Masney <bmasney@redhat.com>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Felix Fietkau <nbd@nbd.name>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: clock: airoha: Add PHY binding for
 Serdes port
Message-ID: <ame6F0auneo1dGtq@redhat.com>
References: <20260724184304.192962-1-ansuelsmth@gmail.com>
 <20260724184304.192962-2-ansuelsmth@gmail.com>
Precedence: bulk
X-Mailing-List: linux-clk@vger.kernel.org
List-Id: <linux-clk.vger.kernel.org>
List-Subscribe: <mailto:linux-clk+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-clk+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260724184304.192962-2-ansuelsmth@gmail.com>
User-Agent: Mutt/2.4.0 (2026-06-19)

Hi Christian,

On Fri, Jul 24, 2026 at 08:43:01PM +0200, Christian Marangi wrote:
> Add PHY cell property for Serdes port selection. Currently supported only
> for Airoha AN7581 SoC, that support up to 4 Serdes port.
> 
> The Serdes port can support both PCIe, USB3 or Ethernet mode.
> 
> - PCIe1 Serdes can support PCIe or Ethernet mode.
> - PCIe2 Serdes can support PCIe or Ethernet mode.
> - USB1 Serdes can support USB3 or HSGMII mode.
> - USB2 Serdes can support USB3 or PCIe mode.
> 
> Add bindings to permit correct reference of the Serdes ports in DT.
> Values are just symbolic and enumerates the Serdes port with a specific
> number for precise reference.
> 
> The available Serdes port can be selected following the dt-binding header
> in [2].
> 
> [2] <include/dt-bindings/soc/airoha,scu-ssr.h>
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
>  .../bindings/clock/airoha,en7523-scu.yaml     | 24 ++++++++++++++++---
>  include/dt-bindings/soc/airoha,scu-ssr.h      | 11 +++++++++
>  2 files changed, 32 insertions(+), 3 deletions(-)
>  create mode 100644 include/dt-bindings/soc/airoha,scu-ssr.h
> 
> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> index eb24a5687639..fc37786ac7ed 100644
> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> @@ -23,6 +23,7 @@ description: |
>  
>    All these identifiers can be found in:
>    [1]: <include/dt-bindings/clock/en7523-clk.h>.
> +  [2]: <include/dt-bindings/soc/airoha,scu-ssr.h>.
>  
>    The clocks are provided inside a system controller node.
>  
> @@ -50,6 +51,12 @@ properties:
>      description: ID of the controller reset line
>      const: 1
>  
> +  '#phy-cells':
> +    description:
> +      The first cell indicates the serdes phy number, see [2] for the
> +      available serdes port.
> +    const: 1
> +
>  required:
>    - compatible
>    - reg
> @@ -65,12 +72,23 @@ allOf:
>          reg:
>            minItems: 2
>  
> +        '#phy-cells': false
> +
> +  - if:
> +      properties:
> +        compatible:
> +          const: econet,en751221-scu
> +    then:
> +      properties:
> +        reg:
> +          maxItems: 1
> +
> +        '#phy-cells': false
> +
>    - if:
>        properties:
>          compatible:
> -          enum:
> -            - airoha,en7581-scu
> -            - econet,en751221-scu
> +          const: airoha,en7581-scu
>      then:
>        properties:
>          reg:

This chunk is new since the split out v10 series[1]. I see that you dropped
krzk's Reviewed-by presumably because of the new chunk. However I don't
see a changelog.

I'm collecting patches up for a clk pull to Stephen. (I'm not sure if
he's going to pull but I'm going to try.) I'm not going to include this
series until I see a Reviewed-by by one of the dt maintainers on the new
patch.

https://lore.kernel.org/all/20260702093812.15918-2-ansuelsmth@gmail.com/

Brian


From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E578731F983
	for <linux-clk@vger.kernel.org>; Mon, 27 Jul 2026 20:09:23 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1785182965; cv=none; b=C1G7V3nUk8m0gnjx8Z94FnhvjOs78cMbIUs4MUBrFmNVoqWx5vM8YcTUE/8M3htdwGb9RgbOyHp3A1BVmvor+gERuRMO9bwMBhyEZfjjIs+aPEdXwj62OVKJwvLaJkIi4CwhSTAzYZdhYoJWYDuBkNtESVu+CiUbffjAuh9Yhho=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1785182965; c=relaxed/simple;
	bh=UX0fY/srS7ZdKLjNF4jSsVtmLoiLZ3JytKNGESCF8zM=;
	h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=kJw8pp96craZOtKjZQQ2QoD+leGu3DES9yTuM1islOr3VJHHfCAi+70i0XmUExMSTpcThsfGg7jxDqsf9GiuDrnHptfdqTTZtzHyPnIfQrKcQjXnduxJxz2qRlUvVy1Oz5X6NU29oASRD+cfjDkce2IEsiv74w3qEy2pOij28e8=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MihgiS3W; arc=none smtp.client-ip=209.85.221.44
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MihgiS3W"
Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-47f84023916so3111480f8f.3
        for <linux-clk@vger.kernel.org>; Mon, 27 Jul 2026 13:09:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20251104; t=1785182962; x=1785787762; darn=vger.kernel.org;
        h=in-reply-to:content-disposition:content-type:mime-version
         :references:subject:cc:to:from:date:message-id:from:to:cc:subject
         :date:message-id:reply-to:content-type;
        bh=ktyHTP3B+cMJl8bG0aNDWYGz8VV/iyh11qcgZ6wVcQU=;
        b=MihgiS3WV79yX53tbugK52iYNWobqakyCnulMYkHHaWwq4RstWdm5FbqumieHefrBl
         Vc+cpRGUHfMh6TloEL5isRtbXw6LTwMQJAPCoV+ZTJ3o0D1v0U9r+11M9QAfmqo8eKhx
         yFVCZW+EWVmLBUOV5/LEKsozUsysVm/4eYVlg+fKTpFVa3HCt+qV23BMO9btjCYXIqsH
         h54NSVMiT3WqVuP/Ctv8qgxaH6PhZRLcBIALg+erfiMKWOIOZff5KAn5jv3Yj51MSQBc
         7rawBjVpSioDKucz389RynchYahhsj8wEjo4jZgnKCmlPa+EE8uCrqGASx/WpDPn6SEc
         8KsA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20251104; t=1785182962; x=1785787762;
        h=in-reply-to:content-disposition:content-type:mime-version
         :references:subject:cc:to:from:date:message-id:x-gm-gg
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to
         :content-type;
        bh=ktyHTP3B+cMJl8bG0aNDWYGz8VV/iyh11qcgZ6wVcQU=;
        b=h6hwKbbUtDRTV8jqFPJYVLz6DiutEAyZUeZVlidxgsZkz3bYgXYRNrK0FXlke1atWR
         SCA3X6B0n+fTfNW8XszIj+o45ATkPi+i96MqwiLiTJN19mrb4bgbW6H5YrsHkg1/H3OM
         wWwkDjjcA4uZ4cZAEvn4R8nZit4RQDJ6d8Tp7AkwiHKmu6FN0pds3scPJ6f/vt4W1Qur
         TjtbvXJb2t/GzAls4bZMBcJmPtipZtvJgPoKdoUYZp8APiHmbvDbGarY0uHPvCHg8z4s
         RjsvREDsRwmbZleejiifEdTOcEtoavxc85SKPjteAicYc2W18aRhc7IHRQ2VaE3ZzljW
         chiQ==
X-Forwarded-Encrypted: i=1; AHgh+RpRXBd1KAloesLCUVJ1PT9xdRbplsaqM6RCpbliC1PM9A7gc7JHMnTTVpD2Xx6GenAjkOveWpIStSw=@vger.kernel.org
X-Gm-Message-State: AOJu0Yy+izd8fgz1bwrHk+fIhymI2ZGNlDvGKWHHEp4EpbUMDvsnLlaN
	7RuVRpDRphZwqnsFr8AZevLaw18vVtJakPf+0/nk3JX5qd9mQImisTZf
X-Gm-Gg: AR+sD10hbLIdoFAlyNK5KwYu9gRoqR7HIRJFSFGr73PgLirRo1mZXvszZJS6xMFSCa8
	4LeXH9S5JmyeP3LHsqv65Led6Nhf8h9xNk+eOfqu/v/N2wqX7WvSTYYOoZrR2VnQI7DHHlYKqgv
	RkFFig5qJIrA2bMMUkfg5UqQPieUPQtrNrx6ls1G0NTq6QtiC9D1AP/p4snW+oRUj1zZBBTPNQp
	U1gcKJl9KJ5UVYGbcVjuVUigQaLgLsN1dTDw8sWKPcVhz3M0fUqY/aTN2KkK8T9CRZLvCPF/DPe
	IbRm0Aj0UZNk6tKAclPx7P9WF5fPd9d7EeXFrjsCtqps7yITjrj6uEOhvXVWcSgkDPOVYbVYNPL
	c0dANysYSMtJAVKgJZ/holD2TO3DIdvYSvE/t7KL7M/BvBRmFcsKDIID4H7tMYQdvEjr1Zttc7l
	9n9r1B21dlA4zPZ95YmXq8diwcnKbxOQEUYzF+g8XNMsxE2FS96jqB2D4=
X-Received: by 2002:a05:6000:61e:b0:47e:4379:a4fd with SMTP id ffacd0b85a97d-47fafa50cb5mr632815f8f.19.1785182962035;
        Mon, 27 Jul 2026 13:09:22 -0700 (PDT)
Received: from Ansuel-XPS. (host-87-0-193-91.retail.telecomitalia.it. [87.0.193.91])
        by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85bc62basm54589595f8f.13.2026.07.27.13.09.20
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 27 Jul 2026 13:09:21 -0700 (PDT)
Message-ID: <6a67baf1.d9578069.494be.a993@mx.google.com>
X-Google-Original-Message-ID: <ame67YYQqp7WVe8c@Ansuel-XPS.>
Date: Mon, 27 Jul 2026 22:09:17 +0200
From: Christian Marangi <ansuelsmth@gmail.com>
To: Brian Masney <bmasney@redhat.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Felix Fietkau <nbd@nbd.name>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: clock: airoha: Add PHY binding for
 Serdes port
References: <20260724184304.192962-1-ansuelsmth@gmail.com>
 <20260724184304.192962-2-ansuelsmth@gmail.com>
 <ame6F0auneo1dGtq@redhat.com>
Precedence: bulk
X-Mailing-List: linux-clk@vger.kernel.org
List-Id: <linux-clk.vger.kernel.org>
List-Subscribe: <mailto:linux-clk+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-clk+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ame6F0auneo1dGtq@redhat.com>

On Mon, Jul 27, 2026 at 04:05:43PM -0400, Brian Masney wrote:
> Hi Christian,
> 
> On Fri, Jul 24, 2026 at 08:43:01PM +0200, Christian Marangi wrote:
> > Add PHY cell property for Serdes port selection. Currently supported only
> > for Airoha AN7581 SoC, that support up to 4 Serdes port.
> > 
> > The Serdes port can support both PCIe, USB3 or Ethernet mode.
> > 
> > - PCIe1 Serdes can support PCIe or Ethernet mode.
> > - PCIe2 Serdes can support PCIe or Ethernet mode.
> > - USB1 Serdes can support USB3 or HSGMII mode.
> > - USB2 Serdes can support USB3 or PCIe mode.
> > 
> > Add bindings to permit correct reference of the Serdes ports in DT.
> > Values are just symbolic and enumerates the Serdes port with a specific
> > number for precise reference.
> > 
> > The available Serdes port can be selected following the dt-binding header
> > in [2].
> > 
> > [2] <include/dt-bindings/soc/airoha,scu-ssr.h>
> > 
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > ---
> >  .../bindings/clock/airoha,en7523-scu.yaml     | 24 ++++++++++++++++---
> >  include/dt-bindings/soc/airoha,scu-ssr.h      | 11 +++++++++
> >  2 files changed, 32 insertions(+), 3 deletions(-)
> >  create mode 100644 include/dt-bindings/soc/airoha,scu-ssr.h
> > 
> > diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> > index eb24a5687639..fc37786ac7ed 100644
> > --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> > +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> > @@ -23,6 +23,7 @@ description: |
> >  
> >    All these identifiers can be found in:
> >    [1]: <include/dt-bindings/clock/en7523-clk.h>.
> > +  [2]: <include/dt-bindings/soc/airoha,scu-ssr.h>.
> >  
> >    The clocks are provided inside a system controller node.
> >  
> > @@ -50,6 +51,12 @@ properties:
> >      description: ID of the controller reset line
> >      const: 1
> >  
> > +  '#phy-cells':
> > +    description:
> > +      The first cell indicates the serdes phy number, see [2] for the
> > +      available serdes port.
> > +    const: 1
> > +
> >  required:
> >    - compatible
> >    - reg
> > @@ -65,12 +72,23 @@ allOf:
> >          reg:
> >            minItems: 2
> >  
> > +        '#phy-cells': false
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          const: econet,en751221-scu
> > +    then:
> > +      properties:
> > +        reg:
> > +          maxItems: 1
> > +
> > +        '#phy-cells': false
> > +
> >    - if:
> >        properties:
> >          compatible:
> > -          enum:
> > -            - airoha,en7581-scu
> > -            - econet,en751221-scu
> > +          const: airoha,en7581-scu
> >      then:
> >        properties:
> >          reg:
> 
> This chunk is new since the split out v10 series[1]. I see that you dropped
> krzk's Reviewed-by presumably because of the new chunk. However I don't
> see a changelog.
> 
> I'm collecting patches up for a clk pull to Stephen. (I'm not sure if
> he's going to pull but I'm going to try.) I'm not going to include this
> series until I see a Reviewed-by by one of the dt maintainers on the new
> patch.
> 
> https://lore.kernel.org/all/20260702093812.15918-2-ansuelsmth@gmail.com/
>

Hi Brian,

yes all correct. I dropped as the patch changed (change is trivial but not
correct)

It's ok as long as stuff gets eventually picked ahahah 

-- 
	Ansuel

From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32EED3C4547
	for <linux-clk@vger.kernel.org>; Mon, 27 Jul 2026 20:18:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1785183528; cv=none; b=RTeJSe3I1YMB0U5Q9/3J22Q0bTYtJ7RCj2d6k1H8iBf3pM4R+EGtq0H14IiYwNTJyaCRFRO/7e2L0dsZElxlu2X+tnx5MSewMX+GAkgNk9qs9hxSBFjounEdZ6aFpLFAw7zT1sE+jwrw+GclY0ZbJT6ieKfQN7bBhqm2oE9QiOA=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1785183528; c=relaxed/simple;
	bh=gNcf5FAeGwMO2eAYgTDqPg5NAC8YsKQ5n+TNGMBvLTg=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=sCmv+Y2ISxYG359HbAed2ba1AdFKiQLWQnon2ctcwd0wYsP/9sD8RiP9IqLRjuGHnpkjudo3O010gMAPkqGygxULoaGS15hkVuRNy0FnUNouzHdWtp4a4rWKeO1NrjwKL/2dxZAlQiktY0+iBHyRQGojaHKIEysg0T/91iYQcIg=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=f0eLhb5M; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZJX6av+R; arc=none smtp.client-ip=170.10.129.124
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f0eLhb5M";
	dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZJX6av+R"
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1785183522;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=hs1FNANFvQNAtChNv+AEc1xU2AR9c2DWie+0JbesJzM=;
	b=f0eLhb5Ml/4wTvgaoyjQ3zq7jDj/Wjd9MtrpjfUau4BOEBOqxcEtUhvdsjGaXvXvKYjNJ0
	UljntOZldLHXW4AhQdAC4ETHOLG8Hpzk60E5f4lZkzZi5UxV3ecVIArlFjUv3wUv9aLEl/
	p2gSmkY1rCM+dbZ40cLmwE11VdU3Pjc=
Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com
 [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
 us-mta-625-9kNqBhCAOxKnzfakBURBzQ-1; Mon, 27 Jul 2026 16:18:41 -0400
X-MC-Unique: 9kNqBhCAOxKnzfakBURBzQ-1
X-Mimecast-MFC-AGG-ID: 9kNqBhCAOxKnzfakBURBzQ_1785183521
Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92ef31cd429so319972985a.3
        for <linux-clk@vger.kernel.org>; Mon, 27 Jul 2026 13:18:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=redhat.com; s=google; t=1785183521; x=1785788321; darn=vger.kernel.org;
        h=user-agent:in-reply-to:content-disposition:content-type
         :mime-version:references:message-id:subject:cc:to:from:date:from:to
         :cc:subject:date:message-id:reply-to:content-type;
        bh=hs1FNANFvQNAtChNv+AEc1xU2AR9c2DWie+0JbesJzM=;
        b=ZJX6av+Rnn9JNK628KK/KUJHk/KrKuENkmShin4uvC4F2jTpv1XhLuhNy7sRyLXo/D
         68bXG4OOMloU7tO4gmevmD1A5/O8j0LHpho5u/kOxRfGXz+ET4xizChlm+4O8zXOk0Tm
         KfqBeVaG7wGyvHo6xmtwrIVllPyaX1A3xREBpiIBDhVvlqJyBc+la6I2V0jea52kmpbY
         SJ1x3PHt5skK02RbGGxNHV/sWLeMnpW9IUYKFIFpQEweFr7+KKTRml37of5zoKyGWaW5
         oblpc998vLXpCi9zRC4rjaAR4aAvDPsvfkSlrxeiZ+v0oJsqbc/rlhi3Wsmi9QEyDYM3
         9gyw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20251104; t=1785183521; x=1785788321;
        h=user-agent:in-reply-to:content-disposition:content-type
         :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to
         :content-type;
        bh=hs1FNANFvQNAtChNv+AEc1xU2AR9c2DWie+0JbesJzM=;
        b=XPd5T/sGefgWsV/wiUl2PmnYiwfnG4I1X9IlylBkOf+6xuiS4ovMpVG2SdgSigSnzm
         1RNfQfacRe8WLnZpM+VaKxnimXYhKvDlbXUb5zvRuTnMIKdpqRFuWfJAWUr24qPedZqB
         I8j2HZgPqIKOEj3nNhR6Usxfma2HGHbP3BAflL/BCv0INHiESEn7Psrk4v4IX6UR0PUG
         dvCECbtuzL7+T39Np0XnBLozd3MgC7C40ijSoLLCGTvPtoPu2ZigKqvLwNDBkMVY2rAp
         DPjHQh69+1il7HFBdcCmfq/fdCxue0kxUdS9oCaqXQxYTcOYCsjj6XwgTUCpM6azgnKJ
         PdDw==
X-Forwarded-Encrypted: i=1; AHgh+RoJOyAp4B0XKfJji7eTYe+ydeVhEEE442sUy66FjZfUGqigYMUyDl+ShMcvE6a/w8bDIqN+uXmjKsM=@vger.kernel.org
X-Gm-Message-State: AOJu0YwgThdeiYglFoMny+47RGNEqduPx8S4aisfAQ4AL1wntgp1+Qj2
	W2oqHsrrhjnjkXjc9nzET5OMWDpQDpFUHHJP/Sdb2q78sGHJktVuk8plyKrrB4k+OowrZqHhkEP
	ksObNHGps2ecxZjMf2h5dI5kpOh6KxXZgKCizKFHEPYEPNb9TdFetTW62hgbiT1NIEfQXVA==
X-Gm-Gg: AR+sD13eguK3SwS/QZ9OnWZz8HynOecIGjLVxaZdHD69aAun/+cVkwHijSUzut/fwxx
	xPINe75tJOgCejcuAh2ME+e32nZZN57xTGNTjzbxbbkXoECTIpgKQRlEhYmDnqWaR6oOGXl7c/R
	oDUXP+gp+aGC0XSDUocxuug7ICZvgH8T781TRH/V2TONUxAWrw6LXU/xpOLBKBBiD1gFDXPXM4N
	ujCdhkYBbrmGfi609PfgRZ+c06XGqGBvThZIVsOUmsuBlz+BFlWyR1DBymAZvhc1T8Vq0WHwaZs
	cJIOdyGAHcXC1Q+1x5zNc9Dv344UH5sS6+djWUHZKEZ4jvNcQEPsER+1MQdlg2BogGVHWl/Mfw=
	=
X-Received: by 2002:a05:620a:2a02:b0:931:2:65b6 with SMTP id af79cd13be357-932df696a6fmr953273285a.38.1785183520920;
        Mon, 27 Jul 2026 13:18:40 -0700 (PDT)
X-Received: by 2002:a05:620a:2a02:b0:931:2:65b6 with SMTP id af79cd13be357-932df696a6fmr953269085a.38.1785183520387;
        Mon, 27 Jul 2026 13:18:40 -0700 (PDT)
Received: from redhat.com ([2600:382:771a:ae2:b914:58a6:76d2:bfbb])
        by smtp.gmail.com with ESMTPSA id 6a1803df08f44-907e8708de3sm72230796d6.43.2026.07.27.13.18.38
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 27 Jul 2026 13:18:39 -0700 (PDT)
Date: Mon, 27 Jul 2026 16:18:37 -0400
From: Brian Masney <bmasney@redhat.com>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Felix Fietkau <nbd@nbd.name>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: clock: airoha: Add PHY binding for
 Serdes port
Message-ID: <ame9HVDl-TkzYWCe@redhat.com>
References: <20260724184304.192962-1-ansuelsmth@gmail.com>
 <20260724184304.192962-2-ansuelsmth@gmail.com>
 <ame6F0auneo1dGtq@redhat.com>
 <6a67baf1.d9578069.494be.a993@mx.google.com>
Precedence: bulk
X-Mailing-List: linux-clk@vger.kernel.org
List-Id: <linux-clk.vger.kernel.org>
List-Subscribe: <mailto:linux-clk+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-clk+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6a67baf1.d9578069.494be.a993@mx.google.com>
User-Agent: Mutt/2.4.0 (2026-06-19)

On Mon, Jul 27, 2026 at 10:09:17PM +0200, Christian Marangi wrote:
> On Mon, Jul 27, 2026 at 04:05:43PM -0400, Brian Masney wrote:
> > On Fri, Jul 24, 2026 at 08:43:01PM +0200, Christian Marangi wrote:
> > > diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> > > index eb24a5687639..fc37786ac7ed 100644
> > > --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> > > +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> > > @@ -23,6 +23,7 @@ description: |
> > >  
> > >    All these identifiers can be found in:
> > >    [1]: <include/dt-bindings/clock/en7523-clk.h>.
> > > +  [2]: <include/dt-bindings/soc/airoha,scu-ssr.h>.
> > >  
> > >    The clocks are provided inside a system controller node.
> > >  
> > > @@ -50,6 +51,12 @@ properties:
> > >      description: ID of the controller reset line
> > >      const: 1
> > >  
> > > +  '#phy-cells':
> > > +    description:
> > > +      The first cell indicates the serdes phy number, see [2] for the
> > > +      available serdes port.
> > > +    const: 1
> > > +
> > >  required:
> > >    - compatible
> > >    - reg
> > > @@ -65,12 +72,23 @@ allOf:
> > >          reg:
> > >            minItems: 2
> > >  
> > > +        '#phy-cells': false
> > > +
> > > +  - if:
> > > +      properties:
> > > +        compatible:
> > > +          const: econet,en751221-scu
> > > +    then:
> > > +      properties:
> > > +        reg:
> > > +          maxItems: 1
> > > +
> > > +        '#phy-cells': false
> > > +
> > >    - if:
> > >        properties:
> > >          compatible:
> > > -          enum:
> > > -            - airoha,en7581-scu
> > > -            - econet,en751221-scu
> > > +          const: airoha,en7581-scu
> > >      then:
> > >        properties:
> > >          reg:
> > 
> > This chunk is new since the split out v10 series[1]. I see that you dropped
> > krzk's Reviewed-by presumably because of the new chunk. However I don't
> > see a changelog.
> > 
> > I'm collecting patches up for a clk pull to Stephen. (I'm not sure if
> > he's going to pull but I'm going to try.) I'm not going to include this
> > series until I see a Reviewed-by by one of the dt maintainers on the new
> > patch.
> > 
> > https://lore.kernel.org/all/20260702093812.15918-2-ansuelsmth@gmail.com/
> >
> 
> Hi Brian,
> 
> yes all correct. I dropped as the patch changed (change is trivial but not
> correct)

But not correct? Do you need to post a new version of this series?

If this version is correct, then I suggest including a changelog here
for krzk.

Brian


From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D66D3D47C0
	for <linux-clk@vger.kernel.org>; Mon, 27 Jul 2026 20:22:03 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1785183725; cv=none; b=jV+QIgs7p6Cw2rB0dgWrx/GKWUnXbEdtLGc7VCa1xoyfnx8HpDVmVBVc91nLSJxbcKH3dAdA+17pCRPrnIFOXb0j0nmgF03qptFeYm8qCDQmAGv8B1aC8AiklrwIbVIoZfWwNtisX0C2UR+6RnhlAu0SOwKQjhq7oOzaE5irido=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1785183725; c=relaxed/simple;
	bh=m6Fo2EgIL7XM92/wfw+NDLABcCGPzpi1Tg1Fvr75kwE=;
	h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=i3M2wVlbkb8PKAjSM5bH6NQZIbM9x/LLpFbX8mTY0tx5EJQSOhmzJRQ14kNwdOVKlQfdY+Re9/DCOOTlZ0EMtQBHcjyeov3mbKJUXsxMQJx5hh/E0+nZsiGB9F9CTHcDPgaM6PMIWsCZgSOiQJyEzk9tFMdbougD6RbRkHvCaAs=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m8QdOv0G; arc=none smtp.client-ip=209.85.128.42
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m8QdOv0G"
Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-496b7622a83so14649795e9.2
        for <linux-clk@vger.kernel.org>; Mon, 27 Jul 2026 13:22:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20251104; t=1785183722; x=1785788522; darn=vger.kernel.org;
        h=in-reply-to:content-disposition:content-type:mime-version
         :references:subject:cc:to:from:date:message-id:from:to:cc:subject
         :date:message-id:reply-to:content-type;
        bh=YBuCYxkWRbFtl8jK6C5+fJEPvb/XB+dTpWvS0UE7x2o=;
        b=m8QdOv0GSN1/BYJv2LOmcHUkHKQ0rboTo//6fFUKBlrI3fEZ/bfyN9rxMfP+qilBOU
         D8FiSWNtTy5cjUjfPLMqeOsSIJeJnwT87DWTZ+TWCh7cjvdwJGZ56fmZP0KyK6YHPU5M
         ESmCATbDpW0bgoqXo44kTeNmckbdRJr0Yf1tFgyHrDco5l+RcDVZ9eBCGm4zJxVjGvhg
         Spiga4NRZFuTQwXZEM3GDsNbGwT4aI/M6X96UolJC/I8xpdkxBYBOz3DSNusQU+tKj9G
         mUKYxHbQvXq0dmt7Uwp1TukUCvvv0QDr2yi/EqwwRYKxljQGTLdSNjbNe1uQa6YZGCk7
         Idfg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20251104; t=1785183722; x=1785788522;
        h=in-reply-to:content-disposition:content-type:mime-version
         :references:subject:cc:to:from:date:message-id:x-gm-gg
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to
         :content-type;
        bh=YBuCYxkWRbFtl8jK6C5+fJEPvb/XB+dTpWvS0UE7x2o=;
        b=S1u5jLj3HRpKsYrydaBQsoNVWH4awqkkMoUIX4MlZNn6XFan8c2bUzoUidKrrhC0vv
         3Y8zKzTM7arL+swR3qCj7z9K3tn/WM2qYOMjSPRp/TEit8ja32mctNvZPY1DGX0dpWjD
         1C5PDuaUfbKozBTEUr1DX3nyUGAEDP8LvaEsRg447HwL2xp77sKw+FGHh8tfbuTta785
         u7RJP5TTLsGrDU/aJuRjZzXf1O+i347fP7IAhj32RBIRmFho2gIoor/o4OtDrYJhMutB
         f2A4BgXnIn6bN7cVeZDSCCeOQjwilOOdHVmnJ5XUZM9i5ry6KlihaIcore/G2kO7RN46
         oJlw==
X-Forwarded-Encrypted: i=1; AHgh+Ro6xZ2N4114w3PN3JwG41a4XMDf9E7ld1dj3v49YLObomozMRDNI5X6F7DeYCFwoTSgZ+V0LsQWKjA=@vger.kernel.org
X-Gm-Message-State: AOJu0Yyh9qsr42G0VrX6544HA8VButDL496yy3cUsCFO1ZMdewWMOSNh
	BBXf2O5ILsjdm65tw9OZFE1WY0h9ALSRQcB6P04XB2dqRCBQW4xC7lNUXTaGmQ==
X-Gm-Gg: AR+sD12rqmG9Thwf0st0tRBco5hza1PLhNki0wsBCyB4oTs/zuzyEBnSii6DAl+3c3f
	zCTdPSa7Jan/r4szEDfL+f+bMY2R0KpPOG1QMgQ4A0Ik3rUuNYiKv6R/15AwuR48E3mLERLyp4P
	70bFk88EvRQxkXo8rQKqUw9UIZX5xoujUzpYJAa5N4YBCr1sn9nhHTOntA2bVUOJ2y60jhBC1KJ
	afnIPLlZcbpFL50a8jZJYP8q3rUgMd0LMbMMT9On6YI4pPwSR0/LtfUyf/LOGMqUjVPHED6T2AY
	9RWo0iUp/gQuHrAkKli+vVxO2Mggd3CqxezXmkYQMVFy2ycSdVmSy2lcdxgQ/aS6eaMJfwK2SLg
	LWjbDKKAkpr5CPZQZZhyf8kcBdktYE2q+/4wSck6rZyOaisyRpMmP/J5zkEAy9zGHsxoMrxUjXy
	lLaU0Yczb/rcT8vP/unMJZ8qfo69dZrPJ7jsxIGlGQSnt97g+2y5OP7ck=
X-Received: by 2002:a05:600c:c87:b0:495:4b00:1bab with SMTP id 5b1f17b1804b1-496b5747e1cmr127217345e9.21.1785183722248;
        Mon, 27 Jul 2026 13:22:02 -0700 (PDT)
Received: from Ansuel-XPS. (host-87-0-193-91.retail.telecomitalia.it. [87.0.193.91])
        by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85c6287csm52500346f8f.25.2026.07.27.13.22.00
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 27 Jul 2026 13:22:01 -0700 (PDT)
Message-ID: <6a67bde9.8509f64d.df519.9322@mx.google.com>
X-Google-Original-Message-ID: <ame95QZtOXIBzJxs@Ansuel-XPS.>
Date: Mon, 27 Jul 2026 22:21:57 +0200
From: Christian Marangi <ansuelsmth@gmail.com>
To: Brian Masney <bmasney@redhat.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Felix Fietkau <nbd@nbd.name>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: clock: airoha: Add PHY binding for
 Serdes port
References: <20260724184304.192962-1-ansuelsmth@gmail.com>
 <20260724184304.192962-2-ansuelsmth@gmail.com>
 <ame6F0auneo1dGtq@redhat.com>
 <6a67baf1.d9578069.494be.a993@mx.google.com>
 <ame9HVDl-TkzYWCe@redhat.com>
Precedence: bulk
X-Mailing-List: linux-clk@vger.kernel.org
List-Id: <linux-clk.vger.kernel.org>
List-Subscribe: <mailto:linux-clk+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-clk+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ame9HVDl-TkzYWCe@redhat.com>

On Mon, Jul 27, 2026 at 04:18:37PM -0400, Brian Masney wrote:
> On Mon, Jul 27, 2026 at 10:09:17PM +0200, Christian Marangi wrote:
> > On Mon, Jul 27, 2026 at 04:05:43PM -0400, Brian Masney wrote:
> > > On Fri, Jul 24, 2026 at 08:43:01PM +0200, Christian Marangi wrote:
> > > > diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> > > > index eb24a5687639..fc37786ac7ed 100644
> > > > --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> > > > +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> > > > @@ -23,6 +23,7 @@ description: |
> > > >  
> > > >    All these identifiers can be found in:
> > > >    [1]: <include/dt-bindings/clock/en7523-clk.h>.
> > > > +  [2]: <include/dt-bindings/soc/airoha,scu-ssr.h>.
> > > >  
> > > >    The clocks are provided inside a system controller node.
> > > >  
> > > > @@ -50,6 +51,12 @@ properties:
> > > >      description: ID of the controller reset line
> > > >      const: 1
> > > >  
> > > > +  '#phy-cells':
> > > > +    description:
> > > > +      The first cell indicates the serdes phy number, see [2] for the
> > > > +      available serdes port.
> > > > +    const: 1
> > > > +
> > > >  required:
> > > >    - compatible
> > > >    - reg
> > > > @@ -65,12 +72,23 @@ allOf:
> > > >          reg:
> > > >            minItems: 2
> > > >  
> > > > +        '#phy-cells': false
> > > > +
> > > > +  - if:
> > > > +      properties:
> > > > +        compatible:
> > > > +          const: econet,en751221-scu
> > > > +    then:
> > > > +      properties:
> > > > +        reg:
> > > > +          maxItems: 1
> > > > +
> > > > +        '#phy-cells': false
> > > > +
> > > >    - if:
> > > >        properties:
> > > >          compatible:
> > > > -          enum:
> > > > -            - airoha,en7581-scu
> > > > -            - econet,en751221-scu
> > > > +          const: airoha,en7581-scu
> > > >      then:
> > > >        properties:
> > > >          reg:
> > > 
> > > This chunk is new since the split out v10 series[1]. I see that you dropped
> > > krzk's Reviewed-by presumably because of the new chunk. However I don't
> > > see a changelog.
> > > 
> > > I'm collecting patches up for a clk pull to Stephen. (I'm not sure if
> > > he's going to pull but I'm going to try.) I'm not going to include this
> > > series until I see a Reviewed-by by one of the dt maintainers on the new
> > > patch.
> > > 
> > > https://lore.kernel.org/all/20260702093812.15918-2-ansuelsmth@gmail.com/
> > >
> > 
> > Hi Brian,
> > 
> > yes all correct. I dropped as the patch changed (change is trivial but not
> > correct)
> 
> But not correct? Do you need to post a new version of this series?
>

Also the previous one was O.K.. This is just better.
 
> If this version is correct, then I suggest including a changelog here
> for krzk.
> 

Let me add the changelog here so he can quickly check the change:

Changelog from v10 series:

- Rework if condition and reject #phy-cells for
  econet,en751221-scu compatible.

-- 
	Ansuel

