From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C08E8418343 for ; Mon, 24 Aug 2026 13:16:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787577408; cv=none; b=HeavGdMA/hKXBo2aO4NgGGpyJOlB76+gL378clyKyF+VM34UX+8F0cuQCzLtydq067bFytQG9x9KfOcm14zB2/bamrtGzAld7NL3cXtMh92lwyk2Xi92E1ayHjhuGK1SDT+5fjAXlN8QgE7G1271SGSXqVWPTvcCdP4qJJmv1Fs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787577408; c=relaxed/simple; bh=u69iDQDh65gTSQHaopk712AakCgClJSI2Zoo/JrTLeU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h6BT7ELoCHAqNlaX1ZcRmnw//HuVqE6shCiE1sMDOMu43/ODLz60Sy+KXELjxDt+oxdZM0mtpOkN46XQKgo8oGMmX+kSlEBCfAeEXxKa/MDOt11iQIC1ohkUBmwc7vjYtRxB4oBMNVPUFY92gYFSdsSeCZ0qptyw9MEYwRSKGzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Yt2qQfWI; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nDRNjzCs; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Yt2qQfWI"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nDRNjzCs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787577405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a5uoZNVB2XRKnrTBdvCmJrG8M4XSoSEJo8KaXU4b4e8=; b=Yt2qQfWIpvra9OdM7gDDW3etGkeqEgtGb6YiRhLqOsf27nRSbUrfF6mJUa9/Jm+7hF0CA/ Mx8vJ2x8NHR5UEZyHU7Vb93UVBj1V7Vc044wIY3ZzE4iU3tOMCgUkrmIkMJmcq9QXh6KEn 2GLT1s9ZGLJB0PuCtZAiwbj0g++2RoA= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344-KDZfe0ujObqKdgC1P8UnQw-1; Mon, 24 Aug 2026 09:16:44 -0400 X-MC-Unique: KDZfe0ujObqKdgC1P8UnQw-1 X-Mimecast-MFC-AGG-ID: KDZfe0ujObqKdgC1P8UnQw_1787577403 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-836cfd56077so51611197b3.1 for ; Mon, 24 Aug 2026 06:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787577403; x=1788182203; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=a5uoZNVB2XRKnrTBdvCmJrG8M4XSoSEJo8KaXU4b4e8=; b=nDRNjzCsNeafHgg4aSqZ9DFAxbEbEAmNgVuoOKhKxlM0EV4gIIhIBciaWWiUM5a58i hWBhLd8Fr/DCaXnbI3GgkY67wxWVfHyI8wz8rUB9WYMcMqHfZT2PLK3Az4YxWunC1p+K jzVurhIatDSxYDhRp8ExsURushVWlP2RfJb+TPP/w3DpH8BYw+4bGJ5ulIbQi+1cuMjP /HYXPo/QkSou00keMR1jOhHTQYisB142KFZ1yKhjuGZYcjHBzMRLyHaGlBz8hpK9nWL6 qGj/dLHYL6+xPF55vde8lOj53kBgKgAbWzbSKjIazgpWLlQPjmQy4zL6OmThnCj7xnKo na6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787577403; x=1788182203; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=a5uoZNVB2XRKnrTBdvCmJrG8M4XSoSEJo8KaXU4b4e8=; b=ns9IxfS94uvjFFC9qoE+wmpWArkSKV3AOgRYj7gzRsPLUtGfeEgKLhtqXVrM46aek1 xic5gCtT2BNIX8ga3o5PpPCa65og3UV18fIF2imPNPBGxZYINi6djrFF6edTxhXNvggc VfxeUXlY1HFqUXVs1peqF6dpWME6YhA9ZMDZ1tmIcW+RZlDEk2HPEhLTsHbxVPiG85Yi eXfknzf1h/hR8gblZC5gJVLRrGebKQegs60ajDhmb5QKYTWzU8YrP0d1UnHK78fdW2MK sF95M5bzQu9uyesFcE1gIh1zH5JQvzLbqUDYq2BbnUzYC6FgE6DMZRjfreCtX13UWagi B8xg== X-Forwarded-Encrypted: i=1; AHgh+RqvLoHa3rnr5kU9xvRcyl+2MYlBKjfxRe7Mh9nE7iLGHpbWhr5KJQzDO0Aq2AwnQFh6ACaKhJBT//g=@vger.kernel.org X-Gm-Message-State: AFuF++lupjysQXo2EM4ijVjiXiidE3xuUHnvSGcWEf63DsEPQFM6oc0v HHNG2owvyz4PKfReZU3MvMtuGaMsZ8/7ozTlhMCSNyiCXbjlmauM+34DmSoTPr7mkaowygeh4qm 6du8dKDiyUhaLUaPjAzjpZSXTaIrWzbREcyTsTprpe72kJ9ejfcB8IfgDAELshw== X-Gm-Gg: AR+sD12GKmmnE71lks5DpmAyrchuAU2q1LPVkfKYo1IW2OhWl2Igm7Blnr59pfLCUOA kRcBLZxqmk5YtaKy18KE3ICmfaf2nhdDoO/lzcP0NphnYKI6ckTnxBuGC+LEsFUdP5KTR3dM9o0 s7bnIlR4lZ8JopJ6i7ODtOZ+Yz4Cw/RFg9SarXtKBsMxoThI3d83TQVTKBdsMjH5CW76Nc3kVxg 1FHzdlBEvu4Azs1w0pTRHSWe5vET7ZXWfg8MhGpUPx/OQdUHnHb42k7YDF0OjXl0WswMLzCDfo9 qZNDAficsK4BaxkKmvZgVt+JlvobAOB2xB7T8FtHqcVQmQPLZwgELivBQBm43oJkozz9Lrse+iO 0ei3C3pZS7oFAfpDk0cTDlcm/bLEHSNFqvOc= X-Received: by 2002:a05:690c:e0c1:10b0:81e:a4cf:131b with SMTP id 00721157ae682-849f4a7cc91mr76172847b3.22.1787577403093; Mon, 24 Aug 2026 06:16:43 -0700 (PDT) X-Received: by 2002:a05:690c:e0c1:10b0:81e:a4cf:131b with SMTP id 00721157ae682-849f4a7cc91mr76172227b3.22.1787577402495; Mon, 24 Aug 2026 06:16:42 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 00721157ae682-84ca5d254adsm33243617b3.16.2026.08.24.06.16.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 06:16:41 -0700 (PDT) Date: Mon, 24 Aug 2026 09:16:34 -0400 From: Brian Masney To: Krzysztof Kozlowski Cc: Geert Uytterhoeven , Ryan Chen , Joel Stanley , Stephen Boyd , Brian Masney , Jerome Brunet , Andrew Jeffery , Billy Tsai , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Taichi Sugaya , Takao Orito , Linus Walleij , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Sudeep Holla , Cristian Marussi , David Lechner , Abel Vesa , Peng Fan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Santosh Shilimkar , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Zapolskiy , Heiko Stuebner , Sylwester Nawrocki , Chanwoo Choi , Peter Griffin , Alim Akhtar , Dinh Nguyen , Viresh Kumar , Maxime Coquelin , Alexandre Torgue , Emilio =?iso-8859-1?Q?L=F3pez?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Ulf Hansson , Liviu Dudau , Lorenzo Pieralisi , Michal Simek , Matthias Brugger , linux-clk@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, arm-scmi@vger.kernel.org, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 29/45] clk: samsung: Make sure clk_init_data is fully initialized Message-ID: References: <87b3e83137e1a987f3c69d214706e93ef3898cab.1787239813.git.geert+renesas@glider.be> <60a8d05a-76fa-43c3-a0f7-fb26a3b659b8@kernel.org> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60a8d05a-76fa-43c3-a0f7-fb26a3b659b8@kernel.org> User-Agent: Mutt/2.4.0 (2026-06-19) Hi Krzysztof, On Fri, Aug 21, 2026 at 01:04:01PM +0200, Krzysztof Kozlowski wrote: > On 21/08/2026 10:53, Geert Uytterhoeven wrote: > > The clk_init_data structure contains several mutually-exclusive members > > for different methods to specify the possible parents of a clock, > > prompting drivers to initialize only the members they need. However, > > not initializing all members may cause subtle issues, which are only > > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > > enabled. > > > > Make sure all members are fully initialized, to avoid such bugs, and to > > prevent future breakage when converting drivers to a different method > > for specifying the parents. > > > > Signed-off-by: Geert Uytterhoeven > > --- > > Compile-tested only. > > --- > > drivers/clk/samsung/clk-cpu.c | 2 +- > > drivers/clk/samsung/clk-pll.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > Reviewed-by: Krzysztof Kozlowski > > Let me know if I should take it via Samsung SoC clock tree. I assume by > default this will go directly via clock tree. Please take it through your Samsung tree to avoid merge conflicts if there are other changes to these files during this development cycle. Brian