From: Brian Masney <bmasney@redhat.com>
To: Pengpeng Hou <hppiscas@163.com>
Cc: "André Draszik" <andre.draszik@linaro.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Brian Masney" <bmasney+clk@redhat.com>,
"Jerome Brunet" <jbrunet+clk@baylibre.com>,
"Andi Shyti" <andi@etezian.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: s2mps11: Propagate OF provider registration failures
Date: Fri, 11 Sep 2026 20:25:16 -0400 [thread overview]
Message-ID: <aqSb7O2gfU0hTuUV@redhat.com> (raw)
In-Reply-To: <20260906033651.84082-1-hppiscas@163.com>
On Sun, Sep 06, 2026 at 11:36:04AM +0800, Pengpeng Hou wrote:
> s2mps11_clk_probe() ignores of_clk_add_hw_provider() failures, stores
> driver data and returns success even though DT consumers cannot acquire the
> registered clocks.
>
> Return the provider error through the existing lookup cleanup path. Skip
> empty lookup slots while unwinding because S2MPS14 omits its CP clock.
>
> The issue was found by our static-analysis tool and manually reviewed.
>
> Fixes: b228fad50c00 ("clk: s2mps11: Migrate to clk_hw based OF and registration APIs")
> Assisted-by: gpt 5
Assisted-by: LLM
I'll fix this up on merge.
Brian
next prev parent reply other threads:[~2026-09-12 0:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 3:36 [PATCH] clk: s2mps11: Propagate OF provider registration failures Pengpeng Hou
2026-09-06 3:45 ` sashiko-bot
2026-09-12 0:25 ` Brian Masney [this message]
2026-09-12 0:29 ` Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqSb7O2gfU0hTuUV@redhat.com \
--to=bmasney@redhat.com \
--cc=andi@etezian.org \
--cc=andre.draszik@linaro.org \
--cc=bmasney+clk@redhat.com \
--cc=hppiscas@163.com \
--cc=jbrunet+clk@baylibre.com \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox