Linux clock framework development
 help / color / mirror / Atom feed
From: Brian Masney <masneyb@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney+clk@redhat.com>,
	Jerome Brunet <jbrunet+clk@baylibre.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Felix Fietkau <nbd@nbd.name>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 4/5] clk: en7523: generalize register clocks function
Date: Thu, 19 Nov 2026 19:04:14 -0500	[thread overview]
Message-ID: <av-OfsUwqj-iM7ft@x1g10> (raw)
In-Reply-To: <20261117182444.103123-5-ansuelsmth@gmail.com>

Hi Christian,

On Tue, Nov 17, 2026 at 07:24:42PM +0100, Christian Marangi wrote:
> Airoha AN7583 SoC will use the same logic used by Airoha EN7581 SoC to
> register clocks. Generalize it to register clocks defined in soc_data.
> 
> Add the clocks definition in EN7581 SoC to support this new implementation.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
>  drivers/clk/clk-en7523.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c
> index 6aa6dfaf414e..f12b69f8d453 100644
> --- a/drivers/clk/clk-en7523.c
> +++ b/drivers/clk/clk-en7523.c
> @@ -147,6 +147,7 @@ struct en_clk_priv {
>  
>  struct en_clk_soc_data {
>  	u32 num_clocks;
> +	const struct en_clk_desc *base_clks;
>  	const struct clk_ops pcie_ops;
>  	int (*hw_init)(struct platform_device *pdev,
>  		       struct clk_hw_onecell_data *clk_data);
> @@ -802,12 +803,15 @@ static int en7523_clk_hw_init(struct platform_device *pdev,
>  static void en7581_register_clocks(struct device *dev, struct clk_hw_onecell_data *clk_data,
>  				   struct regmap *map, void __iomem *base)
>  {
> +	const struct en_clk_soc_data *soc_data;
>  	struct clk_hw *hw;
>  	u32 rate;
>  	int i;
>  
> -	for (i = 0; i < ARRAY_SIZE(en7581_base_clks); i++) {
> -		const struct en_clk_desc *desc = &en7581_base_clks[i];
> +	soc_data = device_get_match_data(dev);
> +
> +	for (i = 0; i < soc_data->num_clocks - 1; i++) {

Can there be a proper count stored so that you don't have to do the - 1
here. If I recall, that's done in some other places in this driver.

Brian

  reply	other threads:[~2026-11-20  0:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 18:24 [PATCH v13 0/5] clk: add support for Airoha AN7583 clock Christian Marangi
2026-11-17 18:24 ` [PATCH v13 1/5] dt-bindings: clock: airoha: Document support for " Christian Marangi
2026-11-17 18:32   ` sashiko-bot
2026-11-20  0:02   ` Brian Masney
2026-11-17 18:24 ` [PATCH v13 2/5] clk: en7523: use devm variant for clk_hw_register and fixed clock Christian Marangi
2026-11-17 18:24 ` [PATCH v13 3/5] clk: en7523: protect concurrent access to reset and PCI register Christian Marangi
2026-11-20  0:02   ` Brian Masney
2026-11-17 18:24 ` [PATCH v13 4/5] clk: en7523: generalize register clocks function Christian Marangi
2026-11-20  0:04   ` Brian Masney [this message]
2026-11-17 18:24 ` [PATCH v13 5/5] clk: en7523: add support for Airoha AN7583 clock Christian Marangi
2026-11-17 18:38   ` sashiko-bot
2026-11-20  0:02   ` Brian Masney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av-OfsUwqj-iM7ft@x1g10 \
    --to=masneyb@kernel.org \
    --cc=ansuelsmth@gmail.com \
    --cc=bmasney+clk@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet+clk@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox