From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9C7B2848A4 for ; Fri, 26 Sep 2025 07:24:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758871481; cv=none; b=UGI6RGLG9uWymJ9hCDHbFudpcXNEQQZLzr9itsiEOeC3yfQmlAudljkpoPsc+QFMVquLyXIkG0irT/06aNxWNJD8PhY4R3/NMPgmc6BtlAcpEID3kSJKVOHvJ/2mk4/Y7KdzmY1toCH/GCTM1YytrdPPeVLrvERSyolEEkBDkf4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758871481; c=relaxed/simple; bh=c2eu+UL9TCmEp29DV0rCPhXtO/xi9h8QVygQHibyZVE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H8uAUP6DQkP80jHoKJgGZ6U4WptdTu6WDHJjo3UVuAq9EAIdSIpvAgpjQZu2YB6/lpmdafr93iDNRb8Xemi1L6VOMveWJRD1zbBCgPonLqIW2TvT8h5WnFNM++OIuaMhFU3Hc7EM+du3COhH1Uzn8WfzcmG0G7Qn4a81vGX+Hc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DzaNUATV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DzaNUATV" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58Q6sieN005410 for ; Fri, 26 Sep 2025 07:24:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xahJWVIETX5BgulbVmZ+wNN4Sel4PSrkSaX8qRSlVNo=; b=DzaNUATVlO1Gg7R7 FrvPqSJJIGWbwHp+bb3iIjTSqI28zM5DONHQJWFuNRPeWeAGKgq+Ejof3czeF3Wz AShaUdVw4iggr2N7363Ps1yU11M1y+B2UuEkC3YEYn+4xJwkEM6CsIXIjinRGCNC qRnkb5zKtMegdDELXBEasVDZWRw5rK0X0SEAsSy9cwejgdkOEota6ULJ80NbK60d 5oL40vw6MakX0YR5+FBGormVagK3lCUZWGsx6RmgbWuqFgOKfw1gWnlkHeOuZ4ZW +GMoUjkkTWaWmIU6OurCgXr8hZ8Js4MzlUP635Ef959hpNHahQTdRYizbwMt+TQf oS1KMQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49db0u1vha-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 26 Sep 2025 07:24:38 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2711a55da20so15828975ad.1 for ; Fri, 26 Sep 2025 00:24:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758871477; x=1759476277; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xahJWVIETX5BgulbVmZ+wNN4Sel4PSrkSaX8qRSlVNo=; b=qDI3PFi0RK9vsyJucCiiZvzWbwBuJmVYniq+yn/detnNq4Rh+UACfebiwlbhIPWCo5 gGDXJGGh8/cNVoz/7VjAIA9n4IGJCQ0sH5bMp7lqNUXSI53f40W7EAAz4vyCOyIv/Spo wAlKHMQEBuAgFGtsOynxcjwVrGg6hXMyYDiRirJFQ9JEsxrmnWe1WdlH6tY3EmX1VYWR +4K04sHGNXg2OS4tcTDBF03dr3MHOY1QZZ7rnX+Vfk7u0QH+Ooxxjl853CvKK9jfGTpL WAVdAr4XQRlKSE/4Yuf0PQPNXhQn01LRodsLCtDEvlvdOMWDGxw9sknMuF86pf/i0MDK hNzA== X-Forwarded-Encrypted: i=1; AJvYcCVEN9ULKH/y9fWNfcXfoQ/tBqQcEMXdcQmtpnpZT8lh1SjrnVC0A77oj5DRbSGCZVyrx5aBGqaJ6Do=@vger.kernel.org X-Gm-Message-State: AOJu0Yzd+4Nz2OQ94rvTjRzzCP+BD0nMl4f+lJMU8phnsGSpQVYQ83Dh IWyJYO87CNh/swVszMnr52JMXDTgOlaJX25kBgZbIoMLPCaPNzSQWleK269TUMQSfSNbyuIwR77 MazHjV4sDIT8LRViRLoHArmg9/ansy69PnE//tlS8PYmp3au/5FVsL+DAHRvcFlY= X-Gm-Gg: ASbGncvqnofPXzP2O+YdqSDSWDxCc1A5t526ms88w1Q0uLILpEWquJ3fNSzo46sCtm4 Ms9XOXjQ6zHNhsmfdlihNqBJLY6vq5sDqfeMGk0wZgB8qY5GLQlPP/MGaPQtI5u3L+Fr5GHXJq5 GnzsTDUJWvu8peTADY4ffk9zDmZ0yZKJCky29kPOaPX2CflBWa02mP3i1C0fadGCZv8VInaUmJm hWzr2ZsRifk6fO5vEg0p7MqEkEfUaeB4RrxUFEeRLn6q8buXgoPZvbSJEb7ykiquPyGg+cifPX9 fKi2H+j+I4/hARZcIHT2sKyyLOm7F94Au/cf/Jrgcao+FspsG3qh6Ov4u4XZ7rkolOab X-Received: by 2002:a17:903:2445:b0:27e:ef09:4ab6 with SMTP id d9443c01a7336-27eef094bc5mr16653855ad.0.1758871477461; Fri, 26 Sep 2025 00:24:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9mU7hMFwtT2lvjIBnrzMBSX54y4ICW695ZcgZtsa6DZblU9rRmj4e5eTtaAR5LsZo4bmixg== X-Received: by 2002:a17:903:2445:b0:27e:ef09:4ab6 with SMTP id d9443c01a7336-27eef094bc5mr16653455ad.0.1758871476971; Fri, 26 Sep 2025 00:24:36 -0700 (PDT) Received: from [10.217.216.188] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-27ed66d43b8sm45147795ad.9.2025.09.26.00.24.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Sep 2025 00:24:36 -0700 (PDT) Message-ID: Date: Fri, 26 Sep 2025 12:54:28 +0530 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 9/9] drivers: clk: qcom: Add support for GPUCC and GFXCLK for Kaanapali To: Bjorn Andersson , Jingyi Wang Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Vladimir Zapolskiy , Jagadeesh Kona , Bryan O'Donoghue , Dmitry Baryshkov , Maxime Coquelin , Alexandre Torgue , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com References: <20250924-knp-mmclk-v1-0-d7ea96b4784a@oss.qualcomm.com> <20250924-knp-mmclk-v1-9-d7ea96b4784a@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: dxSIUgUcsWW6uCfqag4TYgyE-uLzJcG4 X-Authority-Analysis: v=2.4 cv=PYXyRyhd c=1 sm=1 tr=0 ts=68d63fb6 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=U7xz_n88CXcP0GAGSGYA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI1MDE3MSBTYWx0ZWRfX9yxlYLu+QfIM g9BtxaPbLBafSGjKEII8NbP+zI7fAFU7bDTr04lRf5PWEcGF6KtyO2L0KcTXftmgcEc5p5Pq6YY 7Ll6qJEilDMNB552r3tQx8GVjQz3+1Ak8AQGs4UZenzUFKkXEc8KgM0+lXLegGBMGJBgPj8IGi/ DyxpyZ7Tbdiz3q12B/UPaWBnq3SUg2EQh8KgW2TipE7DAYw+aBbOrXjV6SU1obv0qNzjM+m/wkR OMpLQ+sUMaAA/bCyIUHZwo0kc0btJa/tweqdFs4lkw8KnmBmVJfqSDc0hOd9pRPYukdh27IJDTM saoZNSljiUQ915MjLx9VZkf3eJIGzIE7doPbpzZCsGBUwWfT/aN9AAPibkShz3BGMcvKeDLfMUx qjZqtd28tI4Zt9NQ/srsHJSF2rJ08w== X-Proofpoint-ORIG-GUID: dxSIUgUcsWW6uCfqag4TYgyE-uLzJcG4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-26_02,2025-09-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 phishscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509250171 On 9/25/2025 6:47 PM, Bjorn Andersson wrote: > On Wed, Sep 24, 2025 at 04:56:50PM -0700, Jingyi Wang wrote: >> From: Taniya Das >> >> Support the graphics clock controller for Kaanapali for Graphics SW >> driver to use the clocks. > > GFXCLKCTL is a new thing, please describe what it is. > Sure Bjorn, will update more details of the GFXCLKCTL. >> > [..] >> diff --git a/drivers/clk/qcom/gxclkctl-kaanapali.c b/drivers/clk/qcom/gxclkctl-kaanapali.c > [..] >> +static struct platform_driver gx_clkctl_kaanapali_driver = { >> + .probe = gx_clkctl_kaanapali_probe, >> + .driver = { >> + .name = "gxclkctl-kaanapali", >> + .of_match_table = gx_clkctl_kaanapali_match_table, >> + }, >> +}; >> + >> +static int __init gx_clkctl_kaanapali_init(void) >> +{ >> + return platform_driver_register(&gx_clkctl_kaanapali_driver); >> +} >> +subsys_initcall(gx_clkctl_kaanapali_init); > > We're not starting up the GPU at subsys initlevel. Can't this just be > module_platform_driver()? If not please document why. > You are right, we could move it to module_platform_driver(). > Regards, > Bjorn > >> + >> +static void __exit gx_clkctl_kaanapali_exit(void) >> +{ >> + platform_driver_unregister(&gx_clkctl_kaanapali_driver); >> +} >> +module_exit(gx_clkctl_kaanapali_exit); >> + >> +MODULE_DESCRIPTION("QTI GFXCLKCTL KAANAPALI Driver"); >> +MODULE_LICENSE("GPL"); >> >> -- >> 2.25.1 >> -- Thanks, Taniya Das