From: Jonathan Cameron <jic23@kernel.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Rick Altherr <raltherr@google.com>,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
William Breathitt Gray <vilhelm.gray@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Andreas Klinger <ak@it-klinger.de>, Rob Herring <robh@kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Quentin Schulz <quentin.schulz@free-electrons.com>,
linux-iio@vger.kernel.org, Zhiyong Tao <zhiyong.tao@mediatek.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>,
Scott Branden <scott.branden@broadcom.com>,
Crestez Dan Leonard <leonard.crestez@intel.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
Fabrice Gasnier <fabrice.gasnier@st.com>,
Hartmut Knaack <knaack.h@gmx.de>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v5 2/2] iio: Aspeed ADC
Date: Sat, 8 Apr 2017 17:15:29 +0100 [thread overview]
Message-ID: <b1919652-4db7-0373-278b-483357968e7e@kernel.org> (raw)
In-Reply-To: <20170405215046.GE7065@codeaurora.org>
On 05/04/17 22:50, Stephen Boyd wrote:
> On 04/01, Jonathan Cameron wrote:
>> On 28/03/17 22:52, Rick Altherr wrote:
>>> Aspeed BMC SoCs include a 16 channel, 10-bit ADC. Low and high threshold
>>> interrupts are supported by the hardware but are not currently implemented.
>>>
>>> Signed-off-by: Rick Altherr <raltherr@google.com>
>> Two really trivial things inline. I'll fix them whilst applying rather than
>> having you do a v6 - please do sanity check I haven't messed it up though!
>>
>> Applied to the togreg branch of iio.git and pushed out as testing for
>> the autobuilders to play with it.
>>
>
> Oh I was too late. Blame work. Anyway, I made some comments on
> v4. If they're fixed in a later patch or discussed on list that's
> fine. No worries on my end.
>
Oops. I went a bit quick on this one I guess.
Anyhow, from a quick read of your comments I'm not sure if any of
them are such that we should revert. Perhaps we Rick can prepare
a follow up patch covering them? I got a little lost so am not
sure but if there is anything effecting bindings Rick, please
get this through asap or let me know if we need to revert for now.
Even if it is a case of adding a bit of binding and following up
with the code using it a bit later.
I'd asked for input on the clock stuff then forgot all about it on
the later version. Sorry about that!
Jonathan
next prev parent reply other threads:[~2017-04-08 16:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170328215259.31622-1-raltherr@google.com>
2017-03-28 21:52 ` [PATCH v5 2/2] iio: Aspeed ADC Rick Altherr
2017-03-29 2:33 ` Joel Stanley
2017-03-31 20:57 ` Xo Wang
2017-04-01 10:56 ` Jonathan Cameron
2017-04-01 10:54 ` Jonathan Cameron
2017-04-05 21:50 ` Stephen Boyd
2017-04-08 16:15 ` Jonathan Cameron [this message]
2017-04-10 16:34 ` Rick Altherr
2017-04-10 18:10 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1919652-4db7-0373-278b-483357968e7e@kernel.org \
--to=jic23@kernel.org \
--cc=ak@it-klinger.de \
--cc=akinobu.mita@gmail.com \
--cc=fabrice.gasnier@st.com \
--cc=geert@linux-m68k.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=leonard.crestez@intel.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=openbmc@lists.ozlabs.org \
--cc=pmeerw@pmeerw.net \
--cc=quentin.schulz@free-electrons.com \
--cc=raltherr@google.com \
--cc=raveendra.padasalagi@broadcom.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=scott.branden@broadcom.com \
--cc=vilhelm.gray@gmail.com \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox