From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A408C19149F; Wed, 9 Oct 2024 12:23:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728476603; cv=none; b=IgXAFQJP6E7o6d+ekaR8ZA4R1c9j9iqOQUsU0ZhQ38Lp0M9ALEAi+HKy9aAb0uK1EHMMjAduoUqP2clS0FD2h7wNCsBCpREe5pGsFttqiBTXEP20EOrYvZBEaW8TCGxbjMjPoSb58V+qCs+1diolrqY3EPfy7k3RYI2aho+r1iI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728476603; c=relaxed/simple; bh=xnWivR6fcBquYslR7NRqmfuc9xvRUA4PTFWiLdEpnfU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jr7+qylFotOEDJ+8YkaKCzU1ZFFixMYVU0KuKj4YS1g3HMEIy0+91M+NchkpMQPPZhKbq6WMkROPqpPbn+qamlLs0QyrEgYVCJ/sJUjrVayUiJ/rK/XYYQhoBslXN3ePPFkIiU7AhNARcV/AMJQXE1TQw+j+6wktOOWjKpX6fTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=UNrue08+; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="UNrue08+" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=gVi8LwdnV8xpyyxW1DNsL6wEgg2JRlgKhN4PKMnARNA=; b=UNrue08+6PTroR13z8mTw8CNCM /gfkprZTO6N7C2LCcDn7K83dfMcakY+kPth8ujKBzp7oWP3um/UUPcInLcU2vrOzAndkXLZ2LSCJk 8JlLk4jRe/LO0GsnPk1tbNzqC2PjDUgDbKH6RAI4TTnyhsqt46jv8v36qaZBnfdNkaqU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1syVii-009Uh3-Q1; Wed, 09 Oct 2024 14:23:12 +0200 Date: Wed, 9 Oct 2024 14:23:12 +0200 From: Andrew Lunn To: Fedor Pchelkin Cc: Stephen Boyd , lvc-project@linuxtesting.org, Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Gregory Clement , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Subject: Re: [lvc-project] [PATCH v3] clk: mvebu: Prevent division by zero in clk_double_div_recalc_rate() Message-ID: References: <20240917132201.17513-1-adiupina@astralinux.ru> <20241009-29749473966747300f3d1d3b-pchelkin@ispras.ru> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241009-29749473966747300f3d1d3b-pchelkin@ispras.ru> > > I would say, let is divide by 0, so there is an obvious kernel stack > > trace and hopefully a report of the issue. It can then be investigated > > in a way we can then find out what the hardware actually is doing. > > Is it worth adding some kind of WARN assertions? Or actually just leave it > for now as is? What actually happens on a / 0 on ARM? I assume it triggers an exception, which will give a stack trace? If so a WARN adds no value. Andrew