* [PATCH][next] clk: ep93xx: make const read-only arrays static
@ 2025-01-12 21:39 Colin Ian King
2025-01-13 21:28 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2025-01-12 21:39 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, linux-clk; +Cc: kernel-janitors, linux-kernel
Don't populate the const read-only arrays on the stack at run time,
instead make them static.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/clk/clk-ep93xx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/clk-ep93xx.c b/drivers/clk/clk-ep93xx.c
index f888aed79b11..4bd8d6ecf6a2 100644
--- a/drivers/clk/clk-ep93xx.c
+++ b/drivers/clk/clk-ep93xx.c
@@ -586,9 +586,9 @@ static unsigned long calc_pll_rate(u64 rate, u32 config_word)
static int ep93xx_plls_init(struct ep93xx_clk_priv *priv)
{
- const char fclk_divisors[] = { 1, 2, 4, 8, 16, 1, 1, 1 };
- const char hclk_divisors[] = { 1, 2, 4, 5, 6, 8, 16, 32 };
- const char pclk_divisors[] = { 1, 2, 4, 8 };
+ static const char fclk_divisors[] = { 1, 2, 4, 8, 16, 1, 1, 1 };
+ static const char hclk_divisors[] = { 1, 2, 4, 5, 6, 8, 16, 32 };
+ static const char pclk_divisors[] = { 1, 2, 4, 8 };
struct clk_parent_data xtali = { .index = 0 };
unsigned int clk_f_div, clk_h_div, clk_p_div;
unsigned long clk_pll1_rate, clk_pll2_rate;
--
2.47.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] clk: ep93xx: make const read-only arrays static
2025-01-12 21:39 [PATCH][next] clk: ep93xx: make const read-only arrays static Colin Ian King
@ 2025-01-13 21:28 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2025-01-13 21:28 UTC (permalink / raw)
To: Colin Ian King, Michael Turquette, linux-clk
Cc: kernel-janitors, linux-kernel
Quoting Colin Ian King (2025-01-12 13:39:47)
> Don't populate the const read-only arrays on the stack at run time,
> instead make them static.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-13 21:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-12 21:39 [PATCH][next] clk: ep93xx: make const read-only arrays static Colin Ian King
2025-01-13 21:28 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).