From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2959241686 for ; Thu, 12 Jun 2025 13:27:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734835; cv=none; b=YKEsDA5+qlU4KNLRNv3/qWyakVvUkCyaDD+PTMTq/91PIbP6Wdnd6c1R4rcqDY6REJ+FjrnM2H407dslmkS4nxaeL0X6OQXhPuCB6e02z8buG+I+kjJQALXn6em0k1BbV/R+50X03V/p64NJdpXERZ21i6W6CAkfZ70YGxO7x+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734835; c=relaxed/simple; bh=4LHEwxEc3hBPrlnpoz7wEtk78FB0iBFJ2kl/SiFP2GU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=jZyc1v3J4YOGoqrHRAApsLVrHbiHhDDLtC+A7HF0lD+du2FYOWGuumCzqkOUBeGzGWaZSWur3FgHsH1ccIJEXIa+dFhlGQFj+mnnkiRjkbIcW93K8U6slnSCvULACoqUxDLKy0u+5YggFPCj8REDgB0e3DvB9gTgMc0klMkIYLA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=e+p98fe2; arc=none smtp.client-ip=210.118.77.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="e+p98fe2" Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20250612132711euoutp02d19906cd1a6feb888a25b960d528211b~ITo8m2cdu1533415334euoutp028 for ; Thu, 12 Jun 2025 13:27:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20250612132711euoutp02d19906cd1a6feb888a25b960d528211b~ITo8m2cdu1533415334euoutp028 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1749734832; bh=PULRw5otkpn6GT9WVK7m+LoEccaSTbNn1hjyoEzOiIs=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=e+p98fe2EtXbMFxwWvQgJluh1QObjr8g6tF2nHs1kG+Hcjb3bO5O924WF1GVlTPyk YhWHkegBS5oA4jFG8qH0C5OBvo/7m/hgotMW9dT1Iay0p0xMz4OUgLKQmM2GGgWlW0 s/gQAlg+rNLhrihoWDunNEKjcRep3lrnbq6wGfAg= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20250612132711eucas1p1db84d1c02a89f07e7346dec9dc6c48e8~ITo75vBrM2197421974eucas1p1Q; Thu, 12 Jun 2025 13:27:11 +0000 (GMT) Received: from [192.168.1.44] (unknown [106.210.136.40]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250612132709eusmtip2f714daf4dd428c2679068f9872962dc7~ITo6trRkm1234712347eusmtip23; Thu, 12 Jun 2025 13:27:09 +0000 (GMT) Message-ID: Date: Thu, 12 Jun 2025 15:27:09 +0200 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/7] Rust Abstractions for PWM subsystem with TH1520 PWM driver To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Drew Fustini Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Guo Ren , Fu Wei , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Marek Szyprowski , Benno Lossin , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Content-Language: en-US From: Michal Wilczynski In-Reply-To: Content-Transfer-Encoding: 8bit X-CMS-MailID: 20250612132711eucas1p1db84d1c02a89f07e7346dec9dc6c48e8 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20250610125330eucas1p2a573627ca8f124fe11e725c2d75bdcc9 X-EPHeader: CA X-CMS-RootMailID: 20250610125330eucas1p2a573627ca8f124fe11e725c2d75bdcc9 References: <20250610-rust-next-pwm-working-fan-for-sending-v2-0-753e2955f110@samsung.com> <6ca6016e-3b17-48a0-ad8d-bb05317aa100@samsung.com> On 6/12/25 07:01, Uwe Kleine-König wrote: > Hello Drew, > > On Wed, Jun 11, 2025 at 04:52:22PM -0700, Drew Fustini wrote: >> I also enabled the pwm fan driver. However, there is a probe failure: >> >> [ 1.250921] pwm-fan pwm-fan: Failed to configure PWM: -524 >> [ 1.256546] pwm-fan pwm-fan: probe with driver pwm-fan failed with error -524 > > 524 = ENOTSUPP, so it seems the request had duty_offset > 0. Does your > fan use PWM_POLARITY_INVERTED? If so, try without that flag. If your fan > really needs an inverted PWM this of course makes fan control buggy. > With the next revision it should work fine (as a duty_offset > 0 should > get rounded down to 0). Since we're running the same DT, the polarity shouldn't be inverted. I see you have CONFIG_PWM_DEBUG=y enabled, which is most likely the reason the probe fails. With that option, the following check is performed in __pwm_apply: if (IS_ENABLED(CONFIG_PWM_DEBUG)) { struct pwm_waveform wf_rounded; err = __pwm_round_waveform_fromhw(chip, pwm, &wfhw, &wf_rounded); if (err) return err; In this revision of the driver, I have not implemented the read-waveform callbacks, so the Rust PWM abstractions correctly return -ENOTSUPP. Uwe, this poses a problem, as reading from the duty and period registers on the TH1520 SoC's PWM controller appears to be broken. > > Best regards > Uwe Best regards, -- Michal Wilczynski