From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 283FEC43381 for ; Mon, 18 Mar 2019 15:19:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04ECA20872 for ; Mon, 18 Mar 2019 15:19:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727197AbfCRPTY (ORCPT ); Mon, 18 Mar 2019 11:19:24 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:38995 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726730AbfCRPTY (ORCPT ); Mon, 18 Mar 2019 11:19:24 -0400 X-Originating-IP: 90.88.22.102 Received: from aptenodytes (aaubervilliers-681-1-80-102.w90-88.abo.wanadoo.fr [90.88.22.102]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id A0AFA240004; Mon, 18 Mar 2019 15:19:16 +0000 (UTC) Message-ID: Subject: Re: [linux-sunxi] [PATCH 11/14] ARM: sunxi: dts: s3/s3l/v3: add DTSI files for S3/S3L/V3 SoCs From: Paul Kocialkowski To: Icenowy Zheng , linux-arm-kernel@lists.infradead.org, Rob Herring , Maxime Ripard , Chen-Yu Tsai , Linus Walleij , Jagan Teki Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-sunxi@googlegroups.com, linux-clk@vger.kernel.org Date: Mon, 18 Mar 2019 16:19:16 +0100 In-Reply-To: <86A3A1C2-323E-439D-9615-530E2AD9E199@aosc.io> References: <20190312152256.35574-1-icenowy@aosc.io> <20190312152256.35574-12-icenowy@aosc.io> <86A3A1C2-323E-439D-9615-530E2AD9E199@aosc.io> Organization: Bootlin Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi, Le lundi 18 mars 2019 à 23:15 +0800, Icenowy Zheng a écrit : > > 于 2019年3月18日 GMT+08:00 下午8:41:32, Paul Kocialkowski 写到: > > Hi, > > > > Le mardi 12 mars 2019 à 23:22 +0800, Icenowy Zheng a écrit : > > > The Allwinner S3/S3L/V3 SoCs all share the same die with the V3s SoC, > > > but with more GPIO wired out of the package. > > > > > > Add DTSI files for these SoCs. The DTSI file for V3 just replaces the > > > pinctrl compatible string, and the S3/S3L DTSI files just include the > > V3 > > > DTSI file. > > > > Note that the V3 has a NMI controller at 1c000d0, that is required for > > handling the AXP209 interrupts IIRQ. I have no idea whether it's also > > the case on the V3s/S3/S3L though but it would be good to know. > > It's not mentioned on the datasheet. > > If it's present, please send a patch. Indeed, it is not documented but the block is definitely there (and it shows up in Allwinner's kernel source too). I'll send a patch once these series is merged then! > BTW all V3 series chip share the same die (sun8iw8). Right, so I think it's safe to assume that the controller is there on all of them then. Cheers, Paul > Thanks > > > Note that I can totally add support for it when adding support for my > > V3 device that uses the AXP209 this way. > > > > Also, could we get proper compatibles and config options for these new > > SoCs, since they are distinct from the V3S? > > > > Cheers, > > > > Paul > > > > > Signed-off-by: Icenowy Zheng > > > --- > > > arch/arm/boot/dts/sun8i-s3.dtsi | 6 ++++++ > > > arch/arm/boot/dts/sun8i-s3l.dtsi | 6 ++++++ > > > arch/arm/boot/dts/sun8i-v3.dtsi | 14 ++++++++++++++ > > > 3 files changed, 26 insertions(+) > > > create mode 100644 arch/arm/boot/dts/sun8i-s3.dtsi > > > create mode 100644 arch/arm/boot/dts/sun8i-s3l.dtsi > > > create mode 100644 arch/arm/boot/dts/sun8i-v3.dtsi > > > > > > diff --git a/arch/arm/boot/dts/sun8i-s3.dtsi > > b/arch/arm/boot/dts/sun8i-s3.dtsi > > > new file mode 100644 > > > index 000000000000..0f41a25ecb30 > > > --- /dev/null > > > +++ b/arch/arm/boot/dts/sun8i-s3.dtsi > > > @@ -0,0 +1,6 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright (C) 2019 Icenowy Zheng > > > + */ > > > + > > > +#include "sun8i-v3.dtsi" > > > diff --git a/arch/arm/boot/dts/sun8i-s3l.dtsi > > b/arch/arm/boot/dts/sun8i-s3l.dtsi > > > new file mode 100644 > > > index 000000000000..0f41a25ecb30 > > > --- /dev/null > > > +++ b/arch/arm/boot/dts/sun8i-s3l.dtsi > > > @@ -0,0 +1,6 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright (C) 2019 Icenowy Zheng > > > + */ > > > + > > > +#include "sun8i-v3.dtsi" > > > diff --git a/arch/arm/boot/dts/sun8i-v3.dtsi > > b/arch/arm/boot/dts/sun8i-v3.dtsi > > > new file mode 100644 > > > index 000000000000..6ae8645ade50 > > > --- /dev/null > > > +++ b/arch/arm/boot/dts/sun8i-v3.dtsi > > > @@ -0,0 +1,14 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright (C) 2019 Icenowy Zheng > > > + */ > > > + > > > +#include "sun8i-v3s.dtsi" > > > + > > > +&ccu { > > > + compatible = "allwinner,sun8i-v3-ccu"; > > > +}; > > > + > > > +&pio { > > > + compatible = "allwinner,sun8i-v3-pinctrl"; > > > +}; > > > -- > > > 2.18.1 > > > > > -- > > Paul Kocialkowski, Bootlin > > Embedded Linux and kernel engineering > > https://bootlin.com > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com