From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate15.nvidia.com ([216.228.121.64]:18318 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730053AbeGSPu3 (ORCPT ); Thu, 19 Jul 2018 11:50:29 -0400 Subject: Re: [PATCH v2 2/2] clk: tegra: Correct clk_out_mux parents To: Peter De Schrijver , , , References: <1532010175-28364-1-git-send-email-pdeschrijver@nvidia.com> <1532010175-28364-3-git-send-email-pdeschrijver@nvidia.com> From: Jon Hunter Message-ID: Date: Thu, 19 Jul 2018 16:06:50 +0100 MIME-Version: 1.0 In-Reply-To: <1532010175-28364-3-git-send-email-pdeschrijver@nvidia.com> Content-Type: text/plain; charset="utf-8" Sender: linux-clk-owner@vger.kernel.org List-ID: On 19/07/18 15:22, Peter De Schrijver wrote: > The first 3 possible parents of clk_out_[1-3] are defined as clk_m, clk_m/2 > and clk_m/4. However They are actually osc, osc/2 and osc/4. In chips prior > to Tegra210 clk_m and osc had the same frequency, so this difference didn't > matter. Since Tegra210 however, clk_m is a divided version of osc. This > results in CCF reporting the rate as only half the actual rate on Tegra210. > To fix this, we add new clocks which have osc, osc/2, osc/4 and the > respective extern clock as their possible parents and use them for > Tegra210. Also 2 new DT clock defines are added to reflect the new > names of clk_m/2 and clk_m/4. The old defines are still kept for backwards > compatibility. > > Signed-off-by: Peter De Schrijver I gave this a whirl on the Tegra210 Smaug which uses the PMC CLK_OUT1 to clock the audio codec, but unfortunately this did not work. The good news is that I know why. Basically, for Tegra210 there is a slight change in the behaviour of the CLKx_ACCEPT_REQ bit. Essentially, this bit must always be set if you want to use any of the osc clocks to drive the CLK_OUTx. Setting this bit does not effect the CLK_OUTx if you are using the CAR to drive the pin. The simplest thing to do for Tegra210 is to always set the CLKx_ACCEPT_REQ. Cheers Jon -- nvpublic