Re: [PATCH 1/3] mailbox: Make BCM2835_MBOX default to ARCH_BCM2835

[Florian Fainelli <florian.fainelli@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

On 5/14/24 05:29, Conor Dooley wrote:
> On Mon, May 13, 2024 at 04:52:32PM -0700, Florian Fainelli wrote:
>> This driver is depended on by CONFIG_FIRMWARE_RASPBERRYPI which provides
>> a number of essential services, including but not limited to a Linux
>> common clock framework provider. Make sure that enable
>> CONFIG_ARCH_BCM2835 does enable the corresponding mailbox driver.
>>
>> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
>> ---
>>   drivers/mailbox/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
>> index 42940108a187..2b4cde562a90 100644
>> --- a/drivers/mailbox/Kconfig
>> +++ b/drivers/mailbox/Kconfig
>> @@ -109,6 +109,7 @@ config ALTERA_MBOX
>>   config BCM2835_MBOX
>>   	tristate "BCM2835 Mailbox"
>>   	depends on ARCH_BCM2835
>> +	default ARCH_BCM2835
> 
> This is just "default y", since I doubt ARCH_BCM2835 can be a module?

Right, although I intend to also add COMPILE_TEST, by then, it might be 
preferable to have it "default ARCH_BCM2835".

> 
> If so, patch 2 could also just be "default y" and I think patch 3 can
> have the same logic applied to it, given you're defaulting it to a
> dependency also?

Right.
-- 
Florian


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]