From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-clk <linux-clk@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 1/1] clk: renesas: cpg-mssr: r8a7796: add IMR clocks
Date: Mon, 20 Feb 2017 23:11:56 +0300 [thread overview]
Message-ID: <b66b04dc-44d4-216f-54aa-1db01a84bcb9@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdV1x2voYKnMKv8x3XvmGwBA8SgwkhJZcnkycypdPhVjzA@mail.gmail.com>
On 02/20/2017 11:38 AM, Geert Uytterhoeven wrote:
>> Add the IMR[0-1] clocks to the R8A7796 CPG/MSSR driver.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
>> --- linux.orig/drivers/clk/renesas/r8a7796-cpg-mssr.c
>> +++ linux/drivers/clk/renesas/r8a7796-cpg-mssr.c
>> @@ -179,6 +179,8 @@ static const struct mssr_mod_clk r8a7796
>> DEF_MOD("vin1", 810, R8A7796_CLK_S0D2),
>> DEF_MOD("vin0", 811, R8A7796_CLK_S0D2),
>> DEF_MOD("etheravb", 812, R8A7796_CLK_S0D6),
>> + DEF_MOD("imr1", 822, R8A7796_CLK_S2D1),
>> + DEF_MOD("imr0", 823, R8A7796_CLK_S2D1),
>
> According to R-Car Gen3 Hardware Users Manual Rev.0.53E, the parent
> clock is S0D2, like on H3 ES2.0.
I only have 0.51E here, doesn't seem to contain much of the clock info...
> Will queue in clk-renesas-for-v4.12 with corrected parent clock.
Thank you!
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
next prev parent reply other threads:[~2017-02-20 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 21:39 [PATCH 1/1] clk: renesas: cpg-mssr: r8a7796: add IMR clocks Sergei Shtylyov
2017-02-20 8:38 ` Geert Uytterhoeven
2017-02-20 20:11 ` Sergei Shtylyov [this message]
2017-02-21 18:54 ` Sergei Shtylyov
2017-02-21 19:39 ` Geert Uytterhoeven
2017-02-21 19:49 ` Sergei Shtylyov
2017-02-28 20:09 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b66b04dc-44d4-216f-54aa-1db01a84bcb9@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox