From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A193638F931 for ; Wed, 4 Feb 2026 17:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770227155; cv=none; b=VxPAYWXuDnBH4sfJdzrOi54IQGigDUsur1DkwvvCGDEpo8NilCkm+iy2Hu3ObBAEXzs50EuDLQKJqBTkiyYHtaK/FPWT0vImlTTQWmM6veR6gPDgW46lApNHG8LUokF2vi4EsgFja65QIMDH0Zm2SwymTrezOQWMMww8GVFILds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770227155; c=relaxed/simple; bh=1U+T/TGx1lu7uG20Yk5Dj/g7zoJzzEaRG2Pyl5Lwbqk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eLQq7kcY/4KaKbRwcuuuFtggBXf57RNZHPC7da/McY05cy5hGIDqfCmL4jJKP8UhVKNjYSi4O8UFe2a1mQiklIqDa7xQAebr9IaXT9G/biX9NBAR04jOWP6TR86RcuqmVn0sO9BhI3un0RROA9JDzFfhFvlf5pUn6D1M5ISwZt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IfY5h04k; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d6Sbp2su; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IfY5h04k"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d6Sbp2su" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614H6sqJ1662410 for ; Wed, 4 Feb 2026 17:45:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Op0scuHNJd3fkuYUXQu5Bv+7LfQ4C8HhgX5SWl4YC5s=; b=IfY5h04krrIowMJS hIgvkrf2HGdMu9w8Ggl+JmO1gqcpBOgM+OM/cZt9MAKP2NhIRAdJQ3NRry0SdyAq DjiCNK8llaNwn+bHIHGYp5lT0g5LknVbXpu8esdj8LxlySKuCnbPr77VY/okti+b jNQse7eHwWIz3pWqC8AVQsD6KRbsjEUNXpogKzxqvvmBz4e8zWx2dplEwxDoVx8l D73UZf1+GmQyd0Edtp9e5S+uCVonc+AYEPxkvEIB0dx5RuPwwJ+HyjWRRwMrYnLw eIuQM5XMXeUK9zvisL30eMoysMJTDncG4Z/S9d6GliqSwj+gateoAlEcx8dpngyv ObCeHg== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c4a7tg4t0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Feb 2026 17:45:54 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b62da7602a0so4605085a12.2 for ; Wed, 04 Feb 2026 09:45:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770227154; x=1770831954; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Op0scuHNJd3fkuYUXQu5Bv+7LfQ4C8HhgX5SWl4YC5s=; b=d6Sbp2suCAT4VgQr7xnlrs+MGFzb625jHoZqGlb0VwK2ypl7L6sRX0uTFjSi4qLzoP HsInu+Q4ICjEzpbmQVSUhYIUtGn4ZCcjoHppX9YvrMZjab0Nf2VspWeGINuriF2a0HQE bx0DZovCju4QEBBDQsDqK7KaAV1ZQ/9Hc7WyAXzpbM0GMb9tWnCFdix4rxvnGlF3fF4B 3t7xvahzmJ6cLKUS+O0h5FFcbFyWTLGOoDm9VMqNl8r7uTdvd4+8AQhGqoNqcUZfKw9r ++05jlNOdyVmaIQFJfR1jvIuk1q+5lck79vOCqZL3bwlahYgB/Ne9KU6Ay5N5qEQk38/ HqVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770227154; x=1770831954; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Op0scuHNJd3fkuYUXQu5Bv+7LfQ4C8HhgX5SWl4YC5s=; b=QUyAi+rAhYA2HcN0QSdXDaE8BlPI1AgZj22LCTLaj2xzXaPStipBLA+OYSWp5Gw392 hwR780ercTFtS0ELvZG2OC1igJJXyNSnqOHSzAFrQ0pmvT9o5Biem0VDvBLQHx0Cuy7b ctx1aS68axg1TzpwJGpHqA7BBsifB0vMLQdEmA73ZO4pWPWkB+Ylwqs7n8vXbBHD8um4 L9u5peTAkwduCh5VjiUph7L6V9qGkc/0GKf1CXyQNUeZ6hksMvL7sMQn9JKBEJB4OKwh 3eewD4l0rTkZBkIj18mf5PtuYoTLq3uOren3ZPbhUkJNREKb3rzz3OjEqymqiJ5Stw1T aswA== X-Forwarded-Encrypted: i=1; AJvYcCXQL2u3+GlBC+WwLUBgJfgYZWvggrAvdDONxXHOGQEDUYSGk7oZm1ILswKoD8uwx8E+pc73VfgHdRc=@vger.kernel.org X-Gm-Message-State: AOJu0YxCyCRQKtiFzRlwFnlGF3xDrj9uSZh5R4EIuem8ZQB6+PmECt2B mdaGSRvUkcL/kz+F5wCwtAVihgt3ma46J8g4qGNrJsjL64mig8TIPKeIao919GMI7xUGJRCz74a FMUa+1uZtzim+s1jC2dNbsExG+hksvYmkQjh4Wkyo4tD1pL+vQ+ljzYILyu1mJgA= X-Gm-Gg: AZuq6aId32e4O+aSKy1CemvVQarE1901iu724AhWCYu5l23uvee2ZAhIRcpOxCNRCOr XpDzEc1Fx3f04gz9WjtKDRUk5AqoGu4LmbE/+StSIRB52jb5v2hS0Um9aErPCOGd9XTwF+yb6rz JsTbVzLRg0+BMDAGbYJB1bHPg3vwBu/7q1fRRzK7b5ao/cJJIeybsqN/uGvsGu8tlLiIIMGbsCN /hY+Zf1c6970fCSevCXV5GJpQSb8w0mX0rQC5tY3FDh5ZdTYU0XlJUYLw68K8gSLTHLgKNPx4Ul OeF/To/8nfLgl67nkf8f39gMFX5A7hH2IGWKI/Pkx/XVjytW1pkjS3zK9I+VrF1UtVj+abjEAQW rDclbphD3CEtZKnNhyInzsn3MPaocR+1i37PR08TADZuS X-Received: by 2002:a05:6a21:150d:b0:393:39a0:f1df with SMTP id adf61e73a8af0-393725d732emr3402864637.78.1770227154006; Wed, 04 Feb 2026 09:45:54 -0800 (PST) X-Received: by 2002:a05:6a21:150d:b0:393:39a0:f1df with SMTP id adf61e73a8af0-393725d732emr3402838637.78.1770227153461; Wed, 04 Feb 2026 09:45:53 -0800 (PST) Received: from [192.168.0.103] ([124.123.178.21]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6d9713cb83sm219304a12.5.2026.02.04.09.45.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Feb 2026 09:45:53 -0800 (PST) Message-ID: Date: Wed, 4 Feb 2026 23:14:56 +0530 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] dt-bindings: clock: qcom: Add X1P42100 video clock controller To: Dmitry Baryshkov Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jagadeesh Kona , Bryan O'Donoghue , Konrad Dybcio , Ajit Pandey , Imran Shaik , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260128-purwa-videocc-camcc-v1-0-b23de57df5ba@oss.qualcomm.com> <20260128-purwa-videocc-camcc-v1-1-b23de57df5ba@oss.qualcomm.com> Content-Language: en-US From: Jagadeesh Kona In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: oZkoBWb2Emkp1KOcQiFOD-Zqp8dz7nnz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDEzNSBTYWx0ZWRfXwrhYW7TyCrF8 g5oPCvS9e2hnoZEflBGXSCQXASIWWHSB2hrSPSE0KxWDgaxujllyABB/cfmHe4mhT450Kqe370N eEqgObZs6st0bcP5ckLrP76vXF5Nm2iGP9iBzIe0ziYHLSHsv2M04DgJUCtj5Rjl4DYeIrfZswi WESeHxtmm80pkA2UZvHjdLXhK0kfKtZlXmQmaTF7XYgOAbpYIIivMiPQPjQZoHP6deLDeVKByZD Du74oMfAPx6415vMmAx9S/i0p/AF1+tfvTZAAJKjX6ex/hew2Ph1Ik0mt1yP5K6Ltq0cAtVX2Yk xuq4ccmy8mRYM8BqMeRmbEw0TkVuFubepW/H0+iXT5EwudvAExjYcDPr9OqOuqSlbg2Yf1FLtMa F26KJp5EOCvITowly+Tn3CK71l2Sf8GNTx6Q2xLGAidaQYCLmXHala53LQUVHVgGj9E+Jth0wyw TNoUeWuSFdvCJsyHRpg== X-Proofpoint-GUID: oZkoBWb2Emkp1KOcQiFOD-Zqp8dz7nnz X-Authority-Analysis: v=2.4 cv=QaVrf8bv c=1 sm=1 tr=0 ts=698385d2 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=2H5/5ZkxJs/wMzWGxXwROQ==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=6d1n1Ba-E67CpG4V2ygA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-04_06,2026-02-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602040135 On 1/28/2026 2:04 AM, Dmitry Baryshkov wrote: > On Wed, Jan 28, 2026 at 12:56:32AM +0530, Jagadeesh Kona wrote: >> X1P42100 video clock controller has most clocks same as SM8650, >> but it also has few additional clocks and resets. Add device >> tree bindings for the video clock controller on Qualcomm >> X1P42100 platform by defining these additional clocks and resets >> on top of SM8650. >> >> Signed-off-by: Jagadeesh Kona >> --- >> .../bindings/clock/qcom,sm8450-videocc.yaml | 2 ++ >> include/dt-bindings/clock/qcom,x1p42100-videocc.h | 21 +++++++++++++++++++++ >> 2 files changed, 23 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml >> index e6beebd6a36ee1ce213a816f60df8a76fa5c44d6..e8bf3fcad3fabc4f3b7e8e692c6c634d1aed9605 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml >> @@ -30,6 +30,7 @@ properties: >> - qcom,sm8650-videocc >> - qcom,sm8750-videocc >> - qcom,x1e80100-videocc >> + - qcom,x1p42100-videocc >> >> clocks: >> items: >> @@ -67,6 +68,7 @@ allOf: >> - qcom,sm8450-videocc >> - qcom,sm8550-videocc >> - qcom,sm8750-videocc >> + - qcom,x1p42100-videocc >> then: >> required: >> - required-opps >> diff --git a/include/dt-bindings/clock/qcom,x1p42100-videocc.h b/include/dt-bindings/clock/qcom,x1p42100-videocc.h >> new file mode 100644 >> index 0000000000000000000000000000000000000000..eb6c9b7264f8cbced7cfa0001903238ffa168431 >> --- /dev/null >> +++ b/include/dt-bindings/clock/qcom,x1p42100-videocc.h >> @@ -0,0 +1,21 @@ >> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> + >> +#ifndef _DT_BINDINGS_CLK_QCOM_VIDEO_CC_X1P42100_H >> +#define _DT_BINDINGS_CLK_QCOM_VIDEO_CC_X1P42100_H >> + >> +#include "qcom,sm8650-videocc.h" >> + >> +/* X1P42100 introduces below new clocks and resets compared to SM8650 */ > > And then someone introduces new clocks or resets into SM8650 bindings > and this gets busted. Please extend the existing header. > Yes, I will drop this and extend the SM8650 bindings to include the new clocks and BCR. Thanks, Jagadeesh >> + >> +/* VIDEO_CC clocks */ >> +#define VIDEO_CC_MVS0_BSE_CLK 17 >> +#define VIDEO_CC_MVS0_BSE_CLK_SRC 18 >> +#define VIDEO_CC_MVS0_BSE_DIV4_DIV_CLK_SRC 19 >> + >> +/* VIDEO_CC resets */ >> +#define VIDEO_CC_MVS0_BSE_BCR 8 >> + >> +#endif >> >> -- >> 2.34.1 >> >