From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BA523246F4 for ; Fri, 8 May 2026 04:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778213421; cv=none; b=MYStfN5AALp4jfswlBBFPpnnRj5n1VAzoQqr7azM1MsViJuf19CpKZXiA54rMwlvNpvU5jIQoFjrRzXBIugnKk+IQBnPTRdplXEtjAWuH5yavwkiDKzpaNqynqayRGzQqJLAY21PswJVmfk8UVSdMDOEXSAZi/04TT1TofffAJc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778213421; c=relaxed/simple; bh=s2gPKB9yTyxjgZVwVa4NP1tmUFvQfbZkzJrVgsnItA4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WRNLp0IpKtSn1xe7S579otpaterpJbWT098nMI1F3ib4VqLQa1TRgUKOiPsxLbNk+14H2kEB94ojWhcg56Z1WKEVIiFM4xcW0YgkcW7caSvLJlsC/GQkkmdNB1xCXydU9dMXaq0oXodqWgkDJtNP7YcabzETzzOCaCYQf06JE/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hSLxwXpR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BTdR85VJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hSLxwXpR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BTdR85VJ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647Kw6712777831 for ; Fri, 8 May 2026 04:10:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C32iP+nSRqdkV0oxopP4PVPbzzEIbj6B7slutkvDY5U=; b=hSLxwXpRqLfskK7a iB4m4f87+XUSb5RQuxKBHq15BZDr/yEEr+0tUnJOrARJ9G1Y8qlvvKmJK81wwhXg /X8BWMPiOT07fyow35nzDCBiWMQx0G2Hs5ASAYZL4BnXuX9fPCjCO18z/BQI9QmP MMu/Aqidofa/pihDENuMcJytgTUULDkkb1FMBaRS6mAN8HShm3qR0IA4IG+BjeQS JEdNKz1YLd6RCFZECVi0IDIG431mdw5RyROjD9WFsOz0PBGue54yYKHSwLs4YUTm bNR6SRO0uQAxL6vEJBN3VR7GL8wLjZ0G+GCN+lsZacut4sS028TT8pa4aNhFACjJ 9SwHOQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e1285h6q9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 08 May 2026 04:10:19 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82fd55bf6cdso1119868b3a.3 for ; Thu, 07 May 2026 21:10:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778213419; x=1778818219; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=C32iP+nSRqdkV0oxopP4PVPbzzEIbj6B7slutkvDY5U=; b=BTdR85VJRGrKn0rXGhXyCO6wf73VO7C/+UQafDw59MWhuHUa/ZQOOSQlUBeAThEUP2 FxSPtjLiw56u+hxdRz9bpd35PgRECzPPi/WQ5klbLYSZTx8Nc7lq9wIrvM4LdQ6v1Dib R1Hy9IN7mpkIkSMtSKp3YamkuiWVlsgsulNuRJml0U0GN4i+d0woOv+u+oOlnT8QA8SF Slwn9unSdXyYxbkHXewn5C8ptb9Jyvj6/IeUC1Ffx20iUGEjqLqNy9QLsAIroOEdJGSW Kw3ISZKuPtBlqDUZ4O2z2NY4bAcCN5EkydkDWAcCqEKAFYqNoWqcGL4Mz5jUswasIjn3 k9OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778213419; x=1778818219; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C32iP+nSRqdkV0oxopP4PVPbzzEIbj6B7slutkvDY5U=; b=GzG8qKNvc9lWmNEAwMLHURbGQDQy21iAprzbRpzEe3eb6ooT3gwRG5jAspQOGFzCH+ Geh4PnzKqu1rqOHvYRTtVT3x+0oo407DyZ1sEqVv8236jHO6U1Q1IBBnxSWjYgembeJH cEd9yclfo/KUvvQwGkEh2L7XfjafoGbyw6jtaFAo7CUWozpFgrQ1q0joE55tG6Gof/W2 1sdYIUn4EKVptNRlMF5SYYr02hy1Fl3/v9QXAxaYg31pC1MCSZkx39GPoCRJGNQwEMFQ JMoj4X2z3+BWwbiRFKK1fcgtI8HIKh8wZjAJiguyZ54HKFOubNk4vyjH1liBtyorSrMC aHag== X-Forwarded-Encrypted: i=1; AFNElJ/bkHZgX/hKuN18o1GCP97zQSxtcLVpjdOpbdcVI3zgb/h4dMqI6yYzfi5aMDu2cQTK5Bdg1npIEjo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1b0HTnqdXENGjnL2i7IrMU2OSJgxSD/vTyjVxgSC+I0WExTBL DB9WY48rRKjDcquzNVkNny7KI/XZiFCf1TPo9Kn/yr6+RZVNCD7ISRqNWtPUteg/v8dPfDCnPxm cFIL0D0NCik+FgyI8zcsxYbhpLW7wtL17WUwLnvEzNv4gE15Hq3AoRmzuQqyNX0o= X-Gm-Gg: AeBDieuyDs9VMga0UZo+Z/nmd8h/yiJOCRt+TCDze/T0vsEYtzsLTsOZdOTehqBqRgj oij0+P5manFIzaV/AhiUI4VFC7on5VfH1V3lHyg78xPA7tJg66QXwLZg7+WUit/zzINvld+V0K4 TsBv9Xtz4pQ/S+bFmkH7yvJwGpkMhe+XyYsLbW5wPhsfM55aBbTLDp08zfTfV0cr7qlqPXuFXkb oXS8yOvU3XZ3BNSb9vVCmEdjOtuoCGmPgdVI8dzmI0iCvxPInWfA7Pef2MD6/9BF1clgPvwFRSt zxHZvFwu6/9gcuo5DaaoY/oCWoBoRkUT5yoeZdh/N+IAmesbaZ3hLyOrqO0tNcHzFDHhU3J5BkY 8ELKVPnUlngWQQ45oVbWNEDEyFy9KJdPklW+/N6IGRSUSIPGXbBhA X-Received: by 2002:a05:6a00:2d9a:b0:835:405a:7e68 with SMTP id d2e1a72fcca58-83a5d190581mr10677375b3a.32.1778213418946; Thu, 07 May 2026 21:10:18 -0700 (PDT) X-Received: by 2002:a05:6a00:2d9a:b0:835:405a:7e68 with SMTP id d2e1a72fcca58-83a5d190581mr10677323b3a.32.1778213418448; Thu, 07 May 2026 21:10:18 -0700 (PDT) Received: from [10.218.5.182] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83965d38ab5sm12869458b3a.26.2026.05.07.21.10.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 21:10:17 -0700 (PDT) Message-ID: Date: Fri, 8 May 2026 09:40:10 +0530 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 5/6] clk: qcom: camcc-x1p42100: Add support for camera clock controller To: Bryan O'Donoghue , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Jagadeesh Kona , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20260507-purwa-videocc-camcc-v5-0-fc3af4130282@oss.qualcomm.com> <20260507-purwa-videocc-camcc-v5-5-fc3af4130282@oss.qualcomm.com> <26191034-ad27-4559-a845-14841c075a4c@kernel.org> Content-Language: en-US From: Jagadeesh Kona In-Reply-To: <26191034-ad27-4559-a845-14841c075a4c@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA4MDAzNyBTYWx0ZWRfX97YdT6J19o/r 6TjJl7PeAyjERD4C9bLtLx+5T6amF7pRDsWMDZsPQaXotft8tUGDfAUs9Jw2S8/GeKYqaE/RJJN wpUXFHsXD1FM6s1vQIcx1Uj/EFqBKinlRaFq68bsuJWK6ZEDHwj2H6JNaKND6JpxgXd27DI6HSQ sFPBhdy1gayyrc9FaHIfnHq1qowtIOZuxF0uuk71WPSlVLp1T1GR4BvqNdetYJ2tUT6/5ow88UC KcG15U2TRgSVdElw8mZU/xlV6BM/Hth/oWT4CiLBPvBMwDZxNd6svlJzzNlX0c/ccvQ0B+lQNAV 2F4b0z5ZEDUzS/13v2CEEAAfzv1/OZbIpi2Hv+5TYsASN9FCrVVcU3vLwc+btaJcK+pV78tnJIk OZYkkXN+va4GTjaumG6DrD0BtUHvV0ypWkvU30hjTLeHS54GV6t6mU1za39Dl2ejGW+4W3MV5UT r3zaSD+datcTOzVNOvA== X-Proofpoint-GUID: b5i8vzYs_Vjc2e77pbk3bb0EHdcLaRmD X-Proofpoint-ORIG-GUID: b5i8vzYs_Vjc2e77pbk3bb0EHdcLaRmD X-Authority-Analysis: v=2.4 cv=NKblPU6g c=1 sm=1 tr=0 ts=69fd622b cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=5lBSLrXIlTbZt68WmtgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 spamscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605080037 On 5/7/2026 1:45 PM, Bryan O'Donoghue wrote: > On 07/05/2026 06:38, Jagadeesh Kona wrote: >> +static const struct alpha_pll_config cam_cc_pll1_config = { >> +    .l = 0x25, >> +    .alpha = 0xeaaa, >> +    .config_ctl_val = 0x20485699, >> +    .config_ctl_hi_val = 0x00182261, >> +    .config_ctl_hi1_val = 0x82aa299c, >> +    .test_ctl_val = 0x00000000, >> +    .test_ctl_hi_val = 0x00000003, >> +    .test_ctl_hi1_val = 0x00009000, >> +    .test_ctl_hi2_val = 0x00000034, >> +    .user_ctl_val = 0x00000400, >> +    .user_ctl_hi_val = 0x00000005, >> +}; > > Since its a script that generates most of this code, can't you teach it to enumerate these magic numbers with defines and bit-fields ? > > I'm not sure if I got an answer to that question on the last iteration of this patch but, asking again now. > As Konrad mentioned in the earlier thread [1], most of the values above are static configuration parameters recommended by the PLL hardware team to ensure correct PLL operation. These values are programmed as is during initialization and are not modified or referenced by software later. Since these settings/fields are unused later in SW, they are defined as static values. For the limited set of PLL registers that software interacts with, the relevant bit definitions are already defined in clk-alpha-pll.c. [1]: https://lore.kernel.org/all/009ecdbb-2297-44eb-862d-233e3290691c@oss.qualcomm.com/#t Thanks, Jagadeesh