Re: [PATCH 03/10] mfd: qcom_rpm: add msm8960 QDSS clock resource

Dmitry Baryshkov
2026-04-18T16:14:56Z

On Tue, Apr 14, 2026 at 01:55:30AM +0700, Antony Kurniawan Soemardi via B4 Relay wrote:
> From: Antony Kurniawan Soemardi <linux@smankusors.com>
>
> msm8960 uses the same clock descriptor as apq8064 but lacked the
> corresponding QDSS resource definition in its resource table. Add
> resource ID 209 to msm8960_rpm_resource_table to match apq8064's
> implementation.

I'd rather drop APQ8064 mentions from the commit message and just state
that you are adding the QDSS clock to match msm-3.0 code.

>
> Without this entry, RPM clock initialization fails on msm8960,
> preventing Bluetooth/Wi-Fi/USB from being enabled.
>
> Tested-by: Rudraksha Gupta <guptarud@gmail.com>
> Signed-off-by: Antony Kurniawan Soemardi <linux@smankusors.com>
> ---
> drivers/mfd/qcom_rpm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 27446f43e3f3..0defb3279af1 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -324,6 +324,7 @@ static const struct qcom_rpm_resource msm8960_rpm_resource_table[] = {
> [QCOM_RPM_USB_OTG_SWITCH] = { 205, 119, 82, 1 },
> [QCOM_RPM_HDMI_SWITCH] = { 206, 120, 83, 1 },
> [QCOM_RPM_DDR_DMM] = { 207, 121, 84, 2 },
> + [QCOM_RPM_QDSS_CLK] = { 209, ~0, 7, 1 },
> };
>
> static const struct qcom_rpm_data msm8960_template = {
>
> --
> 2.34.1
>
>

--
With best wishes
Dmitry