Re: [PATCH 09/10] ARM: dts: qcom: msm8960: add Riva

Dmitry Baryshkov
2026-04-18T17:46:08Z

On Tue, Apr 14, 2026 at 01:55:36AM +0700, Antony Kurniawan Soemardi via B4 Relay wrote:
> From: Antony Kurniawan Soemardi <linux@smankusors.com>
>
> Add the Riva Peripheral Image Loader node to support the Wireless
> Connectivity and Networking Subsystem on MSM8960. This includes:
>
> - Reserved memory region for WCNSS firmware
> - WCN3660 iris radio controller
> - Bluetooth and Wi-Fi sub-devices exposed via the SMD edge
> - Pinctrl states for Bluetooth and Wi-Fi power management
>
> Tested-by: Rudraksha Gupta <guptarud@gmail.com>
> Signed-off-by: Antony Kurniawan Soemardi <linux@smankusors.com>
> ---
> arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 78 ++++++++++++++++++++++++++++++++
> 1 file changed, 78 insertions(+)
>
> @@ -456,6 +489,51 @@ saw1_vreg: regulator {
> };
> };
>
> + riva: riva-pil@3200800 {
> + compatible = "qcom,riva-pil";
> + reg = <0x03200800 0x1000>, <0x03202000 0x2000>, <0x03204000 0x100>;
> + reg-names = "ccu", "dxe", "pmu";

If this is going to be resent, one item per line, please (for both reg
and reg-names). Align to '<' or '"'.

> + interrupts-extended = <&intc GIC_SPI 199 IRQ_TYPE_EDGE_RISING>,
> + <&wcnss_smsm 6 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "wdog", "fatal";
> + memory-region = <&wcnss_mem>;
> +
> + status = "disabled";
> +
> + iris {
> + compatible = "qcom,wcn3660";
> + clocks = <&cxo_board>;
> + clock-names = "xo";
> + };
> +
> + smd-edge {
> + interrupts = <GIC_SPI 198 IRQ_TYPE_EDGE_RISING>;
> + label = "riva";
> + qcom,ipc = <&l2cc 8 25>;
> + qcom,smd-edge = <6>;
> +
> + wcnss {
> + compatible = "qcom,wcnss";
> + qcom,smd-channels = "WCNSS_CTRL";
> + qcom,mmio = <&riva>;
> +
> + bluetooth {
> + compatible = "qcom,wcnss-bt";
> + };
> +
> + wifi {
> + compatible = "qcom,wcnss-wlan";
> + interrupts = <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "tx", "rx";
> + qcom,smem-states = <&apps_smsm 10>, <&apps_smsm 9>;

The same for interrupt-names and smem-states.

Other than that:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

> + qcom,smem-state-names = "tx-enable",
> + "tx-rings-empty";
> + };
> + };
> + };
> + };
> +
> clock-controller@4000000 {
> compatible = "qcom,mmcc-msm8960";
> reg = <0x4000000 0x1000>;
>
> --
> 2.34.1
>
>

--
With best wishes
Dmitry