From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 861C2C433F5 for ; Tue, 3 May 2022 09:42:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233789AbiECJp4 (ORCPT ); Tue, 3 May 2022 05:45:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233883AbiECJpq (ORCPT ); Tue, 3 May 2022 05:45:46 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 245AE39806 for ; Tue, 3 May 2022 02:41:52 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id n10so14946245ejk.5 for ; Tue, 03 May 2022 02:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=b566PPGsjaHWkMbL7FSptu6pFhyMnCOUSbKGby8X3Q0=; b=Gkh9UXQVwF65yXWd0IuvhOJPE2joZBCrE654qMIDm7yDmntq/HBsiKJM6B1Dvk6yM/ UxAlak39n8KEi8x+y9EDaAdz0pt6ygUE2PhIafxZikJGH0eJ4KmP+fGuFABxg81EG2uu VOu2fVuqy9LRgTJXSuA+3WD/EZxl1UTOOGU0nH8yhVB4jam+XQdnSncg+RIPoYoxS5MV YgzUvtGrKGzx7HuvL0Uuc26n+os8X/Tp7BWryHg5mYN7WHqDOyEWtH7GWlV9cfZOobHe 4UZe5xOaVwe8Zngx24UUcyCBZrlSN55iVriTLbqs8Z8kooGqOOACp96tkFfGiZWJXMfS /RAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=b566PPGsjaHWkMbL7FSptu6pFhyMnCOUSbKGby8X3Q0=; b=xabQymsonJbyrc91bLFmArdpOlZo6tmH6Rk8enfQyQLxNClI7Lf06nUI1cfp3/b3w3 QehZ4ESy8jg3LZd0HR28nVUZg6Y7EqvJNMPkGNWoRQ3LDzCcus5q8J1OYUJYjQUhS9WD /CSc7z2C89XVNbCZNJBi9IIcqz/l5/Sm0lzGL3KCwOcDczFitulnJ0ZVip4we3DIy/Hv r7WrNlh5WkTza/yD5mynFxOp2EcYx080KlYK2/LVvRnNWaBzWsGTd8s/aSt8peRgwbXe EEfOrnYh7gOhZXGb9g9kmJTeM00Gcbc9ILp+Q4Q1kx+0+G/AQ+uh8/KEzYXAY5jwBUcy z9hA== X-Gm-Message-State: AOAM530qtr4qQTWwptvWE9afYkAaFC+AdPVvgqPROm6TL8bZflGXjj4O QtVNLi6vp+Q6myYilu4Utac9Lg== X-Google-Smtp-Source: ABdhPJyzst4s7hrEZNpwk9DA5qdrjy5euejkI2joEvaH1c2+lrpv/9TjwCRAJBGmhr2xJVxo0oIkRA== X-Received: by 2002:a17:907:3c81:b0:6e6:cf3e:6e14 with SMTP id gl1-20020a1709073c8100b006e6cf3e6e14mr15088988ejc.181.1651570910698; Tue, 03 May 2022 02:41:50 -0700 (PDT) Received: from [192.168.0.201] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id g7-20020aa7d1c7000000b0042617ba63b1sm7680835edp.59.2022.05.03.02.41.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 May 2022 02:41:50 -0700 (PDT) Message-ID: Date: Tue, 3 May 2022 11:41:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/2] clk: hisilicon: add CRG driver Hi3521a SoC Content-Language: en-US To: "Marty E. Plummer" Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org References: <20220501051020.2432338-1-hanetzer@startmail.com> <20220501051020.2432338-2-hanetzer@startmail.com> <0b66148a-c65f-2acf-9751-ae931778ad45@linaro.org> <20220501113215.rh6he5344hssziy7@proprietary-killer> From: Krzysztof Kozlowski In-Reply-To: <20220501113215.rh6he5344hssziy7@proprietary-killer> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 01/05/2022 13:36, Marty E. Plummer wrote: > On Sun, May 01, 2022 at 10:35:37AM +0200, Krzysztof Kozlowski wrote: >> On 01/05/2022 07:10, Marty E. Plummer wrote: >>> Add CRG driver for Hi3521A SoC. CRG (Clock and Reset Generator) module >>> generates clock and reset signals used by other module blocks on SoC. >>> >>> >> (...) >> >>> + return; >>> + >>> + hisi_clk_register_mux(hi3521a_sysctrl_mux_clks, >>> + ARRAY_SIZE(hi3521a_sysctrl_mux_clks), >>> + clk_data); >>> +} >>> +CLK_OF_DECLARE(hi3521a_sysctrl, "hisilicon,hi3521a-sysctrl", hi3521a_sysctrl_init); >> Missing bindings. >> > Assume you mean the Documentation/dt/binding/... file? Will do. I > probably should have prefixed it with RFC, as I'm mostly hoping to get > the attention of the hisi people to see what's the deal with the mtd > reads being borked. Then just don't Cc devicetree folks and put in cover letter disclaimer that this was intentionally omitted and will be later fixed. It is a waste of time of reviewers to look/filter/organize such email, if it is intentionally not for us. Best regards, Krzysztof