From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, andersson@kernel.org
Cc: agross@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] clk: qcom: Remove the unused variables
Date: Fri, 17 Mar 2023 13:13:55 +0100 [thread overview]
Message-ID: <baf9336d-fd53-b01e-6e1c-1efdbb1a35dd@linaro.org> (raw)
In-Reply-To: <20230317062045.130638-1-jiapeng.chong@linux.alibaba.com>
On 17.03.2023 07:20, Jiapeng Chong wrote:
> Variable gpucc_parent_map_2 and gpucc_parent_data_2 is not effectively
> used, so delete it.
>
> drivers/clk/qcom/gpucc-sm6375.c:145:37: warning: unused variable 'gpucc_parent_data_2'.
> drivers/clk/qcom/gpucc-sm6375.c:139:32: warning: unused variable 'gpucc_parent_map_2'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4555
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
This is fixed already
https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=54ed70b57623e18f6c18f510cbe1e741bca89f34
Konrad
> drivers/clk/qcom/gpucc-sm6375.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/clk/qcom/gpucc-sm6375.c b/drivers/clk/qcom/gpucc-sm6375.c
> index eb9ffa956950..d8f4c4b59f1b 100644
> --- a/drivers/clk/qcom/gpucc-sm6375.c
> +++ b/drivers/clk/qcom/gpucc-sm6375.c
> @@ -136,18 +136,6 @@ static const struct clk_parent_data gpucc_parent_data_1[] = {
> { .index = DT_GCC_GPU_GPLL0_CLK_SRC },
> };
>
> -static const struct parent_map gpucc_parent_map_2[] = {
> - { P_BI_TCXO, 0 },
> - { P_GCC_GPU_GPLL0_CLK_SRC, 5 },
> - { P_GCC_GPU_GPLL0_DIV_CLK_SRC, 6 },
> -};
> -
> -static const struct clk_parent_data gpucc_parent_data_2[] = {
> - { .index = P_BI_TCXO },
> - { .index = DT_GCC_GPU_GPLL0_CLK_SRC },
> - { .index = DT_GCC_GPU_GPLL0_DIV_CLK_SRC },
> -};
> -
> static const struct freq_tbl ftbl_gpucc_gmu_clk_src[] = {
> F(200000000, P_GCC_GPU_GPLL0_DIV_CLK_SRC, 1.5, 0, 0),
> { }
prev parent reply other threads:[~2023-03-17 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 6:20 [PATCH] clk: qcom: Remove the unused variables Jiapeng Chong
2023-03-17 12:13 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baf9336d-fd53-b01e-6e1c-1efdbb1a35dd@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=abaci@linux.alibaba.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox