From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AFE245A2A5 for ; Mon, 21 Sep 2026 08:53:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789980827; cv=none; b=QMEAbjOGagv0kROX7GBcgkVOo593Qi4ISibj6+GQau3FrbifRItY0BFhGu0FR7RB3/dJbsYoK98P9VMcO+okwy4M6CXsgenufV3JZ4G9UCqtcdxBMJR8IpGAYIInIJ9cgNBnEIN/8DCq65g4SerZlTGN9sx9lQPxx9hZDjmWpjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789980827; c=relaxed/simple; bh=kQaNTO6q9D0rnp6b6zlcR8Zeqr4VYQb7j1q3YRsx9Rk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ugTOPd30SPW9yV90r3FDfbLmgk9BDHJtsYVZaclhGftqU6eQx63PUaxbM9GZrNpGJZ1NwpPssZNrbmP7NfWCeHa0GA6jPG8bU7X/ZLgIMmTVlho6iJddwaTOXETAi50TJwm39CgxDGZkoJyKvr9nNhwW51Ik97chK39NUC+1W3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GhX9bn+X; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=F3kKMXbs; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GhX9bn+X"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="F3kKMXbs" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68L8aRTQ4146621 for ; Mon, 21 Sep 2026 08:53:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MrXsJNxfj8OvVzXFKHuOrWtZ0APERwm/HJ3f2UHdxPk=; b=GhX9bn+XQgLCh3c3 skoycZyef7kZTejkMUep28fyxxH0myHpkCJuHTdNP+aAFEe9heTJZEkqQ8zpTx35 oeQ0d2rEUeylefDYds7s9ftPefFUwzZZGzi35w+yOm9gcffykoi1ExhGX48N0ON1 4wplN13LoLGKsSN7SSMc18mTDlDeSc3b9qDQzsIxijokJ/vZkY0na2UjiZxzjW24 rP0h/J9mTuqdJPZ98x11z3bHKUazciIIfV/z4tcARIoGRu28euFJ6pYw42DtExkJ PuPH0nmvehR90rHPWmiLXsZUWN2OC9LAWJM5qYeRbD5a9cpf23kpPPfYMZpqmkmU GmZUJw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gu17gr28q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 21 Sep 2026 08:53:45 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93bfab40895so22389185a.3 for ; Mon, 21 Sep 2026 01:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789980825; x=1790585625; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MrXsJNxfj8OvVzXFKHuOrWtZ0APERwm/HJ3f2UHdxPk=; b=F3kKMXbsyE6XDz/yCRiqdDVwZzePZ+XNiv/PIxm/XEY7dpQtFAXKK/prYL0uMBKb3W UT4Rr/uKWnl0Ex+ziQsFQE5egZp1I+TiuFGwy/Qs4BIFK2a4XGSazYtQ1aZiGJFvC+xs 5aPJoqiAZZWOZzpECga8chesqAjl+VQ3inLpOhoZ+LllYswcUt15aerOZ9z7y1rF6by9 fFBO8f857Fk8Z57i5q9SjkvTBc4iiH01wnvHzRpd51HDJrDJQxK5PcyLmCLZEx4xf5ni Pkw51/2/29IFVzvHIP7M3dxB9BfGN5b/63QGkrICNY7OqEAaTS/+DaRR/cnAFQaWYTla Q39g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789980825; x=1790585625; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MrXsJNxfj8OvVzXFKHuOrWtZ0APERwm/HJ3f2UHdxPk=; b=s1PR2+cXCNCt9ExtjUe23NTBaUuIPAexlLudCNe6BuuOXy2trC2UrT5rAYV2hWyp4C pSoWIm7QnNujcjyB81AX+QrhLlx/U/qVC/C3K0Gs6Q6vupBuFMlYPah6XmoNHK5JAQbS 40P8DVeUuFm0XjwsGbhXHyIpvH4X8prhxUhBDQYGz+C1pCQZ3WN1kHYIwaVHe3lNdn2c z3otg8EBw/XMliD/v2JMGp253E7ge3mJ3VHVIXtnt1N27bRA3kRtx9QtMUT/j2Swue+V DQKJf0opUb3p+aDlolQ5C5e8+0YKCSsgi/as8V7Ez8dYWKm3l33BDcpTuN77CDggr3R3 xsWw== X-Forwarded-Encrypted: i=1; AKwUvBzXZVB8fRsJLqU5ybCAtVBwa7hlARAE+zvCKGbaw+SfPCvo7pZyAvjbSVgqRfNpMYwLKbgiVucjUQ4=@vger.kernel.org X-Gm-Message-State: AFuF++m8vqZUiWtqs9sdFIy77pvq9na8GoP4E63CFWKZtqLHSvW6TZN1 mRFZbYfJN/xQS224iHoFvzLSbCewPSMAxvi7qZEepcw7TFr9wc08IRuzTl4F8f/nZg7Dl3cbEc7 7pTHm9fSWsfpkhPR4hX9BPPZyuVeGgG3uORpUrnW6LetfL1/okARhal/CnxpW2nw= X-Gm-Gg: AYBFou3giknQkWlfznbN3fgiMBzktpeCdqodJtTtqef3MmRuHtqksZnFQrnad/IooNa Jb8luJHIBEcN89MaNYi4FN0rflbi6WEVJhh4xQClnahK8lorvU4K2i7DFXTZByEcKs0mmudUrma aBJovWfsOwJjOleZqOokHxz+Ftej9w1h2Sibvy7jsk9NRDdTDDq+9w+f+AqREYhYnJnUS265ODO et9KsVA33BZDRQ4kMtVBk9OcCvCZ54U1TYy6gNVIryo2yJ6fjhDvPO0lOrn1EpjTZXg1SRcfNvq 4C9YpyXMFkJgaoFlwK/h+rP7SUTwHddLyJQb8US4LT9N6glTayj/HzcUTfvMDcyBBLl+HShX3e0 t0qzYRul3XIKSZByi9AsSnw== X-Received: by 2002:a05:620a:4803:b0:939:b8da:1242 with SMTP id af79cd13be357-93bf518f649mr925793785a.0.1789980824774; Mon, 21 Sep 2026 01:53:44 -0700 (PDT) X-Received: by 2002:a05:620a:4803:b0:939:b8da:1242 with SMTP id af79cd13be357-93bf518f649mr925792185a.0.1789980824404; Mon, 21 Sep 2026 01:53:44 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2a640f9ef5sm174089266b.25.2026.09.21.01.53.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Sep 2026 01:53:43 -0700 (PDT) Message-ID: Date: Mon, 21 Sep 2026 10:53:40 +0200 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: smd-rpm: Skip proxy votes on clocks for QCM2290 To: Imran Shaik , Bjorn Andersson , Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Georgi Djakov Cc: Ajit Pandey , Taniya Das , Jagadeesh Kona , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260910-clk-smd-rpm-skip-proxy-v1-1-1cb5694a99d9@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 85zqVBZr2MSB0Tfu6ugOV4BBqqv28_nr X-Authority-Analysis: v=2.4 cv=IewSymqa c=1 sm=1 tr=0 ts=6ab0f099 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=YoD9nDvxzIzkCcflfdEA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIxMDEyNiBTYWx0ZWRfX/mQ4y21NsISq GnRn2XcTFU+vRkKyzExoikA3doqIsbRQnZqsw/JfsVU7r22Uc/OHfBBj5g6l4JuuPwqUD3791Dk +WCO5Z5KowAuQK/qQjbW7d8ifiujO4ED6mb3PvNfozdbMA1XHhSUoclrUMXe0B/Azr+tUM3ebIh bizWcy/bw+H/3pZNH3Z7gj6EhO/TCY3oUqQvLXo1u4HYzJKNd/pw7yaOGZWoqNkJ4+hXSLgK22z HHFnmLuxi/BD33NWcwdstaFVY0ED0h77wHg1rf8kCmRMaJXjlfKfcEiXio4jhZfzJDP3uf2ElqO fW2flypbWGEOVtoayeLwdN0Sf+1c2h5NDWOVcpmD4xiUJN+geEbOfpIhMAluw1USGvOWsfzQX/o pujOgzzYzIUGVwreNIkjXgeyZf8rDLZ4an9467ncCIlICRcweyj2Sl3sVY9jA2PMWcqCGo13qqU J5JaFjtC4CznE9alNvw== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIxMDEyNiBTYWx0ZWRfX04aarId2PU7C OLDuWiv5RGb4WtzsHIKRwgPY50SMctN1kOkTcAka3qPugJciSz8WKs8gZAzDOBhb7vZ8Zs7UytT 9a7W55QZPv7K+FtG/G+z/Z6CG+7VyZw= X-Proofpoint-ORIG-GUID: 85zqVBZr2MSB0Tfu6ugOV4BBqqv28_nr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-21_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 malwarescore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609210126 On 9/16/26 1:05 PM, Imran Shaik wrote: > > > On 11-09-2026 02:36 pm, Konrad Dybcio wrote: >> On 9/10/26 3:44 PM, Imran Shaik wrote: >>> clk_smd_rpm_handoff() votes both active and sleep RPM resource states for >>> every clock, keeping them non-zero until a consumer takes over. If there >>> is no consumer, those clocks will remain active in the idle scenario as >>> well, and the sleep vote is never cleared, blocking XO shutdown. >>> >>> Introduce the skip_clks_handoff flag to handle this on QCM2290 clocks, >>> keeping other targets unaffected. >>> >>> Fixes: 00f64b58874e ("clk: qcom: Add support for SMD-RPM Clocks") >>> Signed-off-by: Imran Shaik >>> --- >> >> Are you booting with clk_ignore_unused? >> > > No Konrad, clk_ignore_unused is not present. > > Irrespective of clk_ignore_unused, the proxy votes are placed to RPM > during handoff. If no consumer takes over, those votes remain active, > keeping the resource ON in idle and preventing XO shutdown. I re-read this and yeah you're right Is the handoff functionality necessary at all for non-icc clocks? I'm suspecting that this was just a port of the ancient msm-3.10 logic where the (modified) clock framework had a handoff mechanism similar to today's sync_state, except the toning-down of these clocks was never added Konrad